* [PATCH] clk: mediatek: fix dependency of MT7986 ADC clocks
@ 2022-10-20 19:52 Daniel Golle
2022-10-21 8:06 ` AngeloGioacchino Del Regno
2022-10-21 8:08 ` AngeloGioacchino Del Regno
0 siblings, 2 replies; 8+ messages in thread
From: Daniel Golle @ 2022-10-20 19:52 UTC (permalink / raw)
To: linux-clk, linux-arm-kernel, linux-mediatek, linux-kernel,
Michael Turquette, Stephen Boyd, Matthias Brugger
Cc: Sam Shih, Miles Chen, AngeloGioacchino Del Regno, Chen-Yu Tsai
It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
driver clk-mt7986-infracfg.c.
Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/clk/mediatek/clk-mt7986-infracfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mt7986-infracfg.c b/drivers/clk/mediatek/clk-mt7986-infracfg.c
index d90727a53283c7..49666047bf0ed5 100644
--- a/drivers/clk/mediatek/clk-mt7986-infracfg.c
+++ b/drivers/clk/mediatek/clk-mt7986-infracfg.c
@@ -153,7 +153,7 @@ static const struct mtk_gate infra_clks[] = {
18),
GATE_INFRA1(CLK_INFRA_MSDC_66M_CK, "infra_msdc_66m", "infra_sysaxi_d2",
19),
- GATE_INFRA1(CLK_INFRA_ADC_26M_CK, "infra_adc_26m", "csw_f26m_sel", 20),
+ GATE_INFRA1(CLK_INFRA_ADC_26M_CK, "infra_adc_26m", "infra_adc_frc", 20),
GATE_INFRA1(CLK_INFRA_ADC_FRC_CK, "infra_adc_frc", "csw_f26m_sel", 21),
GATE_INFRA1(CLK_INFRA_FBIST2FPC_CK, "infra_fbist2fpc", "nfi1x_sel", 23),
/* INFRA2 */
--
2.38.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: mediatek: fix dependency of MT7986 ADC clocks
2022-10-20 19:52 [PATCH] clk: mediatek: fix dependency of MT7986 ADC clocks Daniel Golle
@ 2022-10-21 8:06 ` AngeloGioacchino Del Regno
2022-10-21 8:08 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-21 8:06 UTC (permalink / raw)
To: Daniel Golle, linux-clk, linux-arm-kernel, linux-mediatek,
linux-kernel, Michael Turquette, Stephen Boyd, Matthias Brugger
Cc: Sam Shih, Miles Chen, Chen-Yu Tsai
Il 20/10/22 21:52, Daniel Golle ha scritto:
> It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
> CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
> mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
> driver clk-mt7986-infracfg.c.
>
> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: mediatek: fix dependency of MT7986 ADC clocks
2022-10-20 19:52 [PATCH] clk: mediatek: fix dependency of MT7986 ADC clocks Daniel Golle
2022-10-21 8:06 ` AngeloGioacchino Del Regno
@ 2022-10-21 8:08 ` AngeloGioacchino Del Regno
2022-10-26 16:18 ` [PATCH v2] " Daniel Golle
1 sibling, 1 reply; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-10-21 8:08 UTC (permalink / raw)
To: Daniel Golle, linux-clk, linux-arm-kernel, linux-mediatek,
linux-kernel, Michael Turquette, Stephen Boyd, Matthias Brugger
Cc: Sam Shih, Miles Chen, Chen-Yu Tsai
Il 20/10/22 21:52, Daniel Golle ha scritto:
> It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
> CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
> mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
> driver clk-mt7986-infracfg.c.
>
> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Sorry, I gave you my Reviewed-by tag, but I've just realized that you're missing
a Fixes tag.
Please send a v2 with:
Fixes: ec97d23c8e22 ("clk: mediatek: add mt7986 clock support")
...and retain my reviewed-by tag after that.
Cheers,
Angelo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks
2022-10-21 8:08 ` AngeloGioacchino Del Regno
@ 2022-10-26 16:18 ` Daniel Golle
2022-10-27 21:41 ` Stephen Boyd
2022-11-29 7:04 ` Chen-Yu Tsai
0 siblings, 2 replies; 8+ messages in thread
From: Daniel Golle @ 2022-10-26 16:18 UTC (permalink / raw)
To: linux-clk, linux-arm-kernel, linux-mediatek, linux-kernel,
Michael Turquette, Stephen Boyd, Matthias Brugger
Cc: Sam Shih, Miles Chen, AngeloGioacchino Del Regno, Chen-Yu Tsai
It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
driver clk-mt7986-infracfg.c.
Fixes: ec97d23c8e22 ("clk: mediatek: add mt7986 clock support")
Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v2: add Fixes: tag
drivers/clk/mediatek/clk-mt7986-infracfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mt7986-infracfg.c b/drivers/clk/mediatek/clk-mt7986-infracfg.c
index d90727a53283c7..49666047bf0ed5 100644
--- a/drivers/clk/mediatek/clk-mt7986-infracfg.c
+++ b/drivers/clk/mediatek/clk-mt7986-infracfg.c
@@ -153,7 +153,7 @@ static const struct mtk_gate infra_clks[] = {
18),
GATE_INFRA1(CLK_INFRA_MSDC_66M_CK, "infra_msdc_66m", "infra_sysaxi_d2",
19),
- GATE_INFRA1(CLK_INFRA_ADC_26M_CK, "infra_adc_26m", "csw_f26m_sel", 20),
+ GATE_INFRA1(CLK_INFRA_ADC_26M_CK, "infra_adc_26m", "infra_adc_frc", 20),
GATE_INFRA1(CLK_INFRA_ADC_FRC_CK, "infra_adc_frc", "csw_f26m_sel", 21),
GATE_INFRA1(CLK_INFRA_FBIST2FPC_CK, "infra_fbist2fpc", "nfi1x_sel", 23),
/* INFRA2 */
--
2.38.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks
2022-10-26 16:18 ` [PATCH v2] " Daniel Golle
@ 2022-10-27 21:41 ` Stephen Boyd
2022-10-27 23:24 ` Daniel Golle
2022-11-29 7:04 ` Chen-Yu Tsai
1 sibling, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2022-10-27 21:41 UTC (permalink / raw)
To: Daniel Golle, Matthias Brugger, Michael Turquette,
linux-arm-kernel, linux-clk, linux-kernel, linux-mediatek
Cc: Sam Shih, Miles Chen, AngeloGioacchino Del Regno, Chen-Yu Tsai
Quoting Daniel Golle (2022-10-26 09:18:07)
> It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
> CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
> mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
> driver clk-mt7986-infracfg.c.
Is this a cleanup patch? Or a pre-requisite for thermal and auxadc
drivers? I don't understand the priority of this patch. Should I apply
it to fix a regression?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks
2022-10-27 21:41 ` Stephen Boyd
@ 2022-10-27 23:24 ` Daniel Golle
2022-10-27 23:30 ` Stephen Boyd
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Golle @ 2022-10-27 23:24 UTC (permalink / raw)
To: Stephen Boyd
Cc: Matthias Brugger, Michael Turquette, linux-arm-kernel, linux-clk,
linux-kernel, linux-mediatek, Sam Shih, Miles Chen,
AngeloGioacchino Del Regno, Chen-Yu Tsai
On Thu, Oct 27, 2022 at 02:41:49PM -0700, Stephen Boyd wrote:
> Quoting Daniel Golle (2022-10-26 09:18:07)
> > It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
> > CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
> > mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
> > driver clk-mt7986-infracfg.c.
>
> Is this a cleanup patch? Or a pre-requisite for thermal and auxadc
> drivers? I don't understand the priority of this patch. Should I apply
> it to fix a regression?
I'd say 'no', as AUXADC and thermal has not yet been added to
mt7986a.dtsi, also the corresponding clocks are currently still unused.
So while this commit does fix a previous commit, it doesn't have a direct
impact and will only matter once thermal and auxadc units are added to
mt7986.dtsi.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks
2022-10-27 23:24 ` Daniel Golle
@ 2022-10-27 23:30 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2022-10-27 23:30 UTC (permalink / raw)
To: Daniel Golle
Cc: Matthias Brugger, Michael Turquette, linux-arm-kernel, linux-clk,
linux-kernel, linux-mediatek, Sam Shih, Miles Chen,
AngeloGioacchino Del Regno, Chen-Yu Tsai
Quoting Daniel Golle (2022-10-27 16:24:35)
> On Thu, Oct 27, 2022 at 02:41:49PM -0700, Stephen Boyd wrote:
> > Quoting Daniel Golle (2022-10-26 09:18:07)
> > > It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
> > > CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
> > > mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
> > > driver clk-mt7986-infracfg.c.
> >
> > Is this a cleanup patch? Or a pre-requisite for thermal and auxadc
> > drivers? I don't understand the priority of this patch. Should I apply
> > it to fix a regression?
>
> I'd say 'no', as AUXADC and thermal has not yet been added to
> mt7986a.dtsi, also the corresponding clocks are currently still unused.
> So while this commit does fix a previous commit, it doesn't have a direct
> impact and will only matter once thermal and auxadc units are added to
> mt7986.dtsi.
Thanks! Please include these details next time.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks
2022-10-26 16:18 ` [PATCH v2] " Daniel Golle
2022-10-27 21:41 ` Stephen Boyd
@ 2022-11-29 7:04 ` Chen-Yu Tsai
1 sibling, 0 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2022-11-29 7:04 UTC (permalink / raw)
To: daniel, linux-clk, Stephen Boyd, Matthias Brugger,
linux-mediatek, Michael Turquette, linux-arm-kernel,
linux-kernel
Cc: angelogioacchino.delregno, sam.shih, Miles Chen
On Wed, 26 Oct 2022 17:18:07 +0100, Daniel Golle wrote:
> It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for
> CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the
> mtk-thermal and mt6577_auxadc drivers, add dependency to the clock
> driver clk-mt7986-infracfg.c.
>
>
Applied, thanks!
[1/1] clk: mediatek: fix dependency of MT7986 ADC clocks
commit: a46315295489933209e902638cd287aeb5f982ab
Best regards,
--
Chen-Yu Tsai <wenst@chromium.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-29 7:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 19:52 [PATCH] clk: mediatek: fix dependency of MT7986 ADC clocks Daniel Golle
2022-10-21 8:06 ` AngeloGioacchino Del Regno
2022-10-21 8:08 ` AngeloGioacchino Del Regno
2022-10-26 16:18 ` [PATCH v2] " Daniel Golle
2022-10-27 21:41 ` Stephen Boyd
2022-10-27 23:24 ` Daniel Golle
2022-10-27 23:30 ` Stephen Boyd
2022-11-29 7:04 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).