* [PATCH next v10 1/2] i2c: hisi: Add initial device tree support
@ 2022-11-01 8:07 Weilong Chen
2022-11-01 8:07 ` [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c Weilong Chen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Weilong Chen @ 2022-11-01 8:07 UTC (permalink / raw)
To: chenweilong, yangyicong, robh+dt, krzysztof.kozlowski+dt, wsa,
andriy.shevchenko, f.fainelli, jarkko.nikula, jdelvare,
william.zhang, jsd, conor.dooley, phil.edworthy,
tharunkumar.pasumarthi, semen.protsenko, kfting
Cc: linux-i2c, devicetree, linux-kernel
The HiSilicon I2C controller can be used on embedded platform, which
boot from devicetree.
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Acked-by: Yicong Yang <yangyicong@hisilicon.com>
---
Change since v9:
- Drop wrong use ACPI_PTR/of_match_ptr
Link: https://lore.kernel.org/lkml/dfc1c006-61c0-8f28-6164-060347c69d04@huawei.com/T/
drivers/i2c/busses/Kconfig | 2 +-
drivers/i2c/busses/i2c-hisi.c | 7 +++++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index e50f9603d189..a7bfddf08fa7 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -673,7 +673,7 @@ config I2C_HIGHLANDER
config I2C_HISI
tristate "HiSilicon I2C controller"
- depends on (ARM64 && ACPI) || COMPILE_TEST
+ depends on ARM64 || COMPILE_TEST
help
Say Y here if you want to have Hisilicon I2C controller support
available on the Kunpeng Server.
diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c
index 76c3d8f6fc3c..bcc97e4fcb65 100644
--- a/drivers/i2c/busses/i2c-hisi.c
+++ b/drivers/i2c/busses/i2c-hisi.c
@@ -489,11 +489,18 @@ static const struct acpi_device_id hisi_i2c_acpi_ids[] = {
};
MODULE_DEVICE_TABLE(acpi, hisi_i2c_acpi_ids);
+static const struct of_device_id hisi_i2c_dts_ids[] = {
+ { .compatible = "hisilicon,ascend910-i2c", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, hisi_i2c_dts_ids);
+
static struct platform_driver hisi_i2c_driver = {
.probe = hisi_i2c_probe,
.driver = {
.name = "hisi-i2c",
.acpi_match_table = hisi_i2c_acpi_ids,
+ .of_match_table = hisi_i2c_dts_ids,
},
};
module_platform_driver(hisi_i2c_driver);
--
2.31.GIT
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c
2022-11-01 8:07 [PATCH next v10 1/2] i2c: hisi: Add initial device tree support Weilong Chen
@ 2022-11-01 8:07 ` Weilong Chen
2022-11-01 12:54 ` Yicong Yang
2022-11-02 20:24 ` Wolfram Sang
2022-11-01 14:56 ` [PATCH next v10 1/2] i2c: hisi: Add initial device tree support Andy Shevchenko
2022-11-02 20:24 ` Wolfram Sang
2 siblings, 2 replies; 6+ messages in thread
From: Weilong Chen @ 2022-11-01 8:07 UTC (permalink / raw)
To: chenweilong, yangyicong, robh+dt, krzysztof.kozlowski+dt, wsa,
andriy.shevchenko, f.fainelli, jarkko.nikula, jdelvare,
william.zhang, jsd, conor.dooley, phil.edworthy,
tharunkumar.pasumarthi, semen.protsenko, kfting
Cc: linux-i2c, devicetree, linux-kernel
Add the new compatible for HiSilicon i2c.
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Change since v9:
- No change
Link: https://lore.kernel.org/lkml/20221029115937.179788-2-chenweilong@huawei.com/
Change since v8:
- Use vendor,soc-ipblock format.
- Drop quotes.
- Drop "Device Tree bindings".
- Description goes to top level description.
- Use defines for constants.
Link: https://lore.kernel.org/lkml/20221024015151.342651-2-chenweilong@huawei.com/
.../bindings/i2c/hisilicon,ascend910-i2c.yaml | 73 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 74 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
diff --git a/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml b/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
new file mode 100644
index 000000000000..7d7a8de7bcd8
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/hisilicon,ascend910-i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: HiSilicon common I2C controller
+
+maintainers:
+ - Yicong Yang <yangyicong@hisilicon.com>
+
+description:
+ The HiSilicon common I2C controller can be used for many different
+ types of SoC such as Huawei Ascend AI series chips.
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ compatible:
+ const: hisilicon,ascend910-i2c
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-frequency:
+ default: 400000
+
+ i2c-sda-falling-time-ns:
+ default: 343
+
+ i2c-scl-falling-time-ns:
+ default: 203
+
+ i2c-sda-hold-time-ns:
+ default: 830
+
+ i2c-scl-rising-time-ns:
+ default: 365
+
+ i2c-digital-filter-width-ns:
+ default: 0
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ i2c@38b0000 {
+ compatible = "hisilicon,ascend910-i2c";
+ reg = <0x38b0000 0x10000>;
+ interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
+ i2c-sda-falling-time-ns = <56>;
+ i2c-scl-falling-time-ns = <56>;
+ i2c-sda-hold-time-ns = <56>;
+ i2c-scl-rising-time-ns = <56>;
+ i2c-digital-filter;
+ i2c-digital-filter-width-ns = <0x0>;
+ clocks = <&alg_clk>;
+ clock-frequency = <400000>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index d1214d83c2df..d42e34d1e8e2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9228,6 +9228,7 @@ M: Yicong Yang <yangyicong@hisilicon.com>
L: linux-i2c@vger.kernel.org
S: Maintained
W: https://www.hisilicon.com
+F: Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
F: drivers/i2c/busses/i2c-hisi.c
HISILICON LPC BUS DRIVER
--
2.31.GIT
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c
2022-11-01 8:07 ` [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c Weilong Chen
@ 2022-11-01 12:54 ` Yicong Yang
2022-11-02 20:24 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Yicong Yang @ 2022-11-01 12:54 UTC (permalink / raw)
To: Weilong Chen
Cc: linux-i2c, devicetree, jdelvare, semen.protsenko, jarkko.nikula,
tharunkumar.pasumarthi, linux-kernel, f.fainelli, yangyicong,
robh+dt, krzysztof.kozlowski+dt, andriy.shevchenko, wsa,
william.zhang, conor.dooley, jsd, phil.edworthy, kfting
On 2022/11/1 16:07, Weilong Chen wrote:
> Add the new compatible for HiSilicon i2c.
>
Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Change since v9:
> - No change
> Link: https://lore.kernel.org/lkml/20221029115937.179788-2-chenweilong@huawei.com/
>
> Change since v8:
> - Use vendor,soc-ipblock format.
> - Drop quotes.
> - Drop "Device Tree bindings".
> - Description goes to top level description.
> - Use defines for constants.
> Link: https://lore.kernel.org/lkml/20221024015151.342651-2-chenweilong@huawei.com/
>
> .../bindings/i2c/hisilicon,ascend910-i2c.yaml | 73 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 74 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml b/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
> new file mode 100644
> index 000000000000..7d7a8de7bcd8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/hisilicon,ascend910-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon common I2C controller
> +
> +maintainers:
> + - Yicong Yang <yangyicong@hisilicon.com>
> +
> +description:
> + The HiSilicon common I2C controller can be used for many different
> + types of SoC such as Huawei Ascend AI series chips.
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + const: hisilicon,ascend910-i2c
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-frequency:
> + default: 400000
> +
> + i2c-sda-falling-time-ns:
> + default: 343
> +
> + i2c-scl-falling-time-ns:
> + default: 203
> +
> + i2c-sda-hold-time-ns:
> + default: 830
> +
> + i2c-scl-rising-time-ns:
> + default: 365
> +
> + i2c-digital-filter-width-ns:
> + default: 0
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + i2c@38b0000 {
> + compatible = "hisilicon,ascend910-i2c";
> + reg = <0x38b0000 0x10000>;
> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> + i2c-sda-falling-time-ns = <56>;
> + i2c-scl-falling-time-ns = <56>;
> + i2c-sda-hold-time-ns = <56>;
> + i2c-scl-rising-time-ns = <56>;
> + i2c-digital-filter;
> + i2c-digital-filter-width-ns = <0x0>;
> + clocks = <&alg_clk>;
> + clock-frequency = <400000>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d1214d83c2df..d42e34d1e8e2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9228,6 +9228,7 @@ M: Yicong Yang <yangyicong@hisilicon.com>
> L: linux-i2c@vger.kernel.org
> S: Maintained
> W: https://www.hisilicon.com
> +F: Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
> F: drivers/i2c/busses/i2c-hisi.c
>
> HISILICON LPC BUS DRIVER
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH next v10 1/2] i2c: hisi: Add initial device tree support
2022-11-01 8:07 [PATCH next v10 1/2] i2c: hisi: Add initial device tree support Weilong Chen
2022-11-01 8:07 ` [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c Weilong Chen
@ 2022-11-01 14:56 ` Andy Shevchenko
2022-11-02 20:24 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2022-11-01 14:56 UTC (permalink / raw)
To: Weilong Chen
Cc: yangyicong, robh+dt, krzysztof.kozlowski+dt, wsa, f.fainelli,
jarkko.nikula, jdelvare, william.zhang, jsd, conor.dooley,
phil.edworthy, tharunkumar.pasumarthi, semen.protsenko, kfting,
linux-i2c, devicetree, linux-kernel
On Tue, Nov 01, 2022 at 04:07:27PM +0800, Weilong Chen wrote:
> The HiSilicon I2C controller can be used on embedded platform, which
> boot from devicetree.
Thanks, This version LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> Acked-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
> Change since v9:
> - Drop wrong use ACPI_PTR/of_match_ptr
> Link: https://lore.kernel.org/lkml/dfc1c006-61c0-8f28-6164-060347c69d04@huawei.com/T/
>
> drivers/i2c/busses/Kconfig | 2 +-
> drivers/i2c/busses/i2c-hisi.c | 7 +++++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index e50f9603d189..a7bfddf08fa7 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -673,7 +673,7 @@ config I2C_HIGHLANDER
>
> config I2C_HISI
> tristate "HiSilicon I2C controller"
> - depends on (ARM64 && ACPI) || COMPILE_TEST
> + depends on ARM64 || COMPILE_TEST
> help
> Say Y here if you want to have Hisilicon I2C controller support
> available on the Kunpeng Server.
> diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c
> index 76c3d8f6fc3c..bcc97e4fcb65 100644
> --- a/drivers/i2c/busses/i2c-hisi.c
> +++ b/drivers/i2c/busses/i2c-hisi.c
> @@ -489,11 +489,18 @@ static const struct acpi_device_id hisi_i2c_acpi_ids[] = {
> };
> MODULE_DEVICE_TABLE(acpi, hisi_i2c_acpi_ids);
>
> +static const struct of_device_id hisi_i2c_dts_ids[] = {
> + { .compatible = "hisilicon,ascend910-i2c", },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, hisi_i2c_dts_ids);
> +
> static struct platform_driver hisi_i2c_driver = {
> .probe = hisi_i2c_probe,
> .driver = {
> .name = "hisi-i2c",
> .acpi_match_table = hisi_i2c_acpi_ids,
> + .of_match_table = hisi_i2c_dts_ids,
> },
> };
> module_platform_driver(hisi_i2c_driver);
> --
> 2.31.GIT
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH next v10 1/2] i2c: hisi: Add initial device tree support
2022-11-01 8:07 [PATCH next v10 1/2] i2c: hisi: Add initial device tree support Weilong Chen
2022-11-01 8:07 ` [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c Weilong Chen
2022-11-01 14:56 ` [PATCH next v10 1/2] i2c: hisi: Add initial device tree support Andy Shevchenko
@ 2022-11-02 20:24 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2022-11-02 20:24 UTC (permalink / raw)
To: Weilong Chen
Cc: yangyicong, robh+dt, krzysztof.kozlowski+dt, andriy.shevchenko,
f.fainelli, jarkko.nikula, jdelvare, william.zhang, jsd,
conor.dooley, phil.edworthy, tharunkumar.pasumarthi,
semen.protsenko, kfting, linux-i2c, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On Tue, Nov 01, 2022 at 04:07:27PM +0800, Weilong Chen wrote:
> The HiSilicon I2C controller can be used on embedded platform, which
> boot from devicetree.
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> Acked-by: Yicong Yang <yangyicong@hisilicon.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c
2022-11-01 8:07 ` [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c Weilong Chen
2022-11-01 12:54 ` Yicong Yang
@ 2022-11-02 20:24 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2022-11-02 20:24 UTC (permalink / raw)
To: Weilong Chen
Cc: yangyicong, robh+dt, krzysztof.kozlowski+dt, andriy.shevchenko,
f.fainelli, jarkko.nikula, jdelvare, william.zhang, jsd,
conor.dooley, phil.edworthy, tharunkumar.pasumarthi,
semen.protsenko, kfting, linux-i2c, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
On Tue, Nov 01, 2022 at 04:07:28PM +0800, Weilong Chen wrote:
> Add the new compatible for HiSilicon i2c.
>
> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-02 20:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 8:07 [PATCH next v10 1/2] i2c: hisi: Add initial device tree support Weilong Chen
2022-11-01 8:07 ` [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c Weilong Chen
2022-11-01 12:54 ` Yicong Yang
2022-11-02 20:24 ` Wolfram Sang
2022-11-01 14:56 ` [PATCH next v10 1/2] i2c: hisi: Add initial device tree support Andy Shevchenko
2022-11-02 20:24 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).