* [RESEND PATCH v3] staging: most: dim2: hal: aligning function parameters
@ 2022-11-01 10:57 UMWARI JOVIAL
2022-11-01 18:04 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: UMWARI JOVIAL @ 2022-11-01 10:57 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel, outreachy
To improve readability, start the list of
function parameters on the same line as the function name.
Issue reported by checkpatch.
Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
---
Changes in v3:
1.Updated the commit message to well explain the changes made
drivers/staging/most/dim2/hal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index a5d40b5b138a..6abe3ab2b2cf 100644
--- a/drivers/staging/most/dim2/hal.c
+++ b/drivers/staging/most/dim2/hal.c
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
dim2_clear_ctr(ctr_addr);
}
-static void dim2_configure_channel(
- u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
- u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+ u16 hw_buffer_size, u16 packet_length)
{
dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH v3] staging: most: dim2: hal: aligning function parameters
2022-11-01 10:57 [RESEND PATCH v3] staging: most: dim2: hal: aligning function parameters UMWARI JOVIAL
@ 2022-11-01 18:04 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-11-01 18:04 UTC (permalink / raw)
To: UMWARI JOVIAL; +Cc: linux-staging, linux-kernel, outreachy
On Tue, Nov 01, 2022 at 01:57:27PM +0300, UMWARI JOVIAL wrote:
> To improve readability, start the list of
> function parameters on the same line as the function name.
Odd line-wrapping, please fix.
> Issue reported by checkpatch.
>
> Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> ---
>
> Changes in v3:
> 1.Updated the commit message to well explain the changes made
What were the changes in v2?
Also, why do you have "RESEND" in the subject line? This is not a
resend of the v3 patch, it is the first time we have seen it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-01 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 10:57 [RESEND PATCH v3] staging: most: dim2: hal: aligning function parameters UMWARI JOVIAL
2022-11-01 18:04 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).