* [PATCH v2] block: sed-opal: Don't include <linux/kernel.h>
@ 2022-12-05 19:16 Christophe JAILLET
2022-12-06 8:29 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2022-12-05 19:16 UTC (permalink / raw)
To: Christoph Hellwig, Jonathan Derrick
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-block
There is no need to include <linux/kernel.h> here.
Prefer the less invasive <linux/types.h> and <linux/compiler_types.h>
which are needed in this .h file itself.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Change in v2:
* No need to add a useless comment [Christoph Hellwig]
* No need to add a new empty line [Christoph Hellwig]
v1: https://lore.kernel.org/all/a2de79b3de30fe70c457953af935dadd49441f00.1670069909.git.christophe.jaillet@wanadoo.fr/
Let see if build-bots agree with me!
---
include/linux/sed-opal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/sed-opal.h b/include/linux/sed-opal.h
index 6f837bb6c715..87f981c70894 100644
--- a/include/linux/sed-opal.h
+++ b/include/linux/sed-opal.h
@@ -11,7 +11,8 @@
#define LINUX_OPAL_H
#include <uapi/linux/sed-opal.h>
-#include <linux/kernel.h>
+#include <linux/compiler_types.h>
+#include <linux/types.h>
struct opal_dev;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] block: sed-opal: Don't include <linux/kernel.h>
2022-12-05 19:16 [PATCH v2] block: sed-opal: Don't include <linux/kernel.h> Christophe JAILLET
@ 2022-12-06 8:29 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-12-06 8:29 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Christoph Hellwig, Jonathan Derrick, linux-kernel,
kernel-janitors, linux-block
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] block: sed-opal: Don't include <linux/kernel.h>
@ 2022-12-08 16:20 Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-12-08 16:20 UTC (permalink / raw)
To: Christoph Hellwig, Jonathan Derrick, Christophe JAILLET
Cc: linux-kernel, kernel-janitors, linux-block
On Mon, 05 Dec 2022 20:16:48 +0100, Christophe JAILLET wrote:
> There is no need to include <linux/kernel.h> here.
>
> Prefer the less invasive <linux/types.h> and <linux/compiler_types.h>
> which are needed in this .h file itself.
>
>
Applied, thanks!
[1/1] block: sed-opal: Don't include <linux/kernel.h>
commit: 56fb8d90031f71fa8af48fdff8498b9263b9c759
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-08 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-05 19:16 [PATCH v2] block: sed-opal: Don't include <linux/kernel.h> Christophe JAILLET
2022-12-06 8:29 ` Christoph Hellwig
2022-12-08 16:20 Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).