linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: am335x: align LED node names with dtschema
@ 2022-11-25 14:41 Krzysztof Kozlowski
  2022-11-28  6:47 ` Tony Lindgren
  2022-12-01 17:06 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 14:41 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, Rob Herring,
	Krzysztof Kozlowski, linux-omap, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

The node names should be generic and DT schema expects certain pattern:

  am335x-baltos-ir2110.dtb: leds: 'app', 'power', 'wlan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/am335x-baltos-leds.dtsi | 6 +++---
 arch/arm/boot/dts/am335x-pocketbeagle.dts | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/am335x-baltos-leds.dtsi b/arch/arm/boot/dts/am335x-baltos-leds.dtsi
index 9a79f727baf6..025014657d12 100644
--- a/arch/arm/boot/dts/am335x-baltos-leds.dtsi
+++ b/arch/arm/boot/dts/am335x-baltos-leds.dtsi
@@ -17,18 +17,18 @@ leds {
 
 		compatible = "gpio-leds";
 
-		power {
+		led-power {
 			label = "onrisc:red:power";
 			linux,default-trigger = "default-on";
 			gpios = <&gpio3 0 GPIO_ACTIVE_LOW>;
 			default-state = "on";
 		};
-		wlan {
+		led-wlan {
 			label = "onrisc:blue:wlan";
 			gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
 			default-state = "off";
 		};
-		app {
+		led-app {
 			label = "onrisc:green:app";
 			gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>;
 			default-state = "off";
diff --git a/arch/arm/boot/dts/am335x-pocketbeagle.dts b/arch/arm/boot/dts/am335x-pocketbeagle.dts
index 5e415d8ffdd8..0ba4883cd4ef 100644
--- a/arch/arm/boot/dts/am335x-pocketbeagle.dts
+++ b/arch/arm/boot/dts/am335x-pocketbeagle.dts
@@ -23,28 +23,28 @@ leds {
 
 		compatible = "gpio-leds";
 
-		usr0 {
+		led-usr0 {
 			label = "beaglebone:green:usr0";
 			gpios = <&gpio1 21 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 			default-state = "off";
 		};
 
-		usr1 {
+		led-usr1 {
 			label = "beaglebone:green:usr1";
 			gpios = <&gpio1 22 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "mmc0";
 			default-state = "off";
 		};
 
-		usr2 {
+		led-usr2 {
 			label = "beaglebone:green:usr2";
 			gpios = <&gpio1 23 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "cpu0";
 			default-state = "off";
 		};
 
-		usr3 {
+		led-usr3 {
 			label = "beaglebone:green:usr3";
 			gpios = <&gpio1 24 GPIO_ACTIVE_HIGH>;
 			default-state = "off";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: am335x: align LED node names with dtschema
  2022-11-25 14:41 [PATCH] ARM: dts: am335x: align LED node names with dtschema Krzysztof Kozlowski
@ 2022-11-28  6:47 ` Tony Lindgren
  2022-12-01 17:06 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2022-11-28  6:47 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Benoît Cousson, Rob Herring, Krzysztof Kozlowski,
	linux-omap, devicetree, linux-kernel

* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [221125 14:41]:
> The node names should be generic and DT schema expects certain pattern:
> 
>   am335x-baltos-ir2110.dtb: leds: 'app', 'power', 'wlan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Feel free to apply this along with your other clean up patches:

Acked-by: Tony Lindgren <tony@atomide.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: am335x: align LED node names with dtschema
  2022-11-25 14:41 [PATCH] ARM: dts: am335x: align LED node names with dtschema Krzysztof Kozlowski
  2022-11-28  6:47 ` Tony Lindgren
@ 2022-12-01 17:06 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-01 17:06 UTC (permalink / raw)
  To: Tony Lindgren, devicetree, linux-omap, linux-kernel,
	Benoît Cousson, Rob Herring, Krzysztof Kozlowski,
	Krzysztof Kozlowski

On Fri, 25 Nov 2022 15:41:18 +0100, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern:
> 
>   am335x-baltos-ir2110.dtb: leds: 'app', 'power', 'wlan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> 
> 

Applied, thanks!

[1/1] ARM: dts: am335x: align LED node names with dtschema
      https://git.kernel.org/krzk/linux-dt/c/37dddd7f7621bd5e0234fb3b8288248f165833b4

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-01 17:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 14:41 [PATCH] ARM: dts: am335x: align LED node names with dtschema Krzysztof Kozlowski
2022-11-28  6:47 ` Tony Lindgren
2022-12-01 17:06 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).