From: Matthias Kaehlcke <mka@chromium.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Doug Anderson" <dianders@chromium.org>,
楊宗翰 <ecs.taipeikernel@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"Bob Moragues" <moragues@chromium.org>,
"Stephen Boyd" <swboyd@chromium.org>, Harvey <hunge@google.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Gavin.Lee@ecs.com.tw, Darren.Chen@ecs.com.tw,
Abner.Yen@ecs.com.tw, Vicy.Lee@ecs.com.tw,
Jason.Huang@ecs.com.tw
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie
Date: Mon, 28 Nov 2022 17:41:14 +0000 [thread overview]
Message-ID: <Y4TyuqPQtZBFChKD@google.com> (raw)
In-Reply-To: <f92ce2ed-80b5-eb26-36a4-2384a7a8510f@linaro.org>
On Mon, Nov 28, 2022 at 06:22:39PM +0100, Krzysztof Kozlowski wrote:
> On 28/11/2022 16:56, Doug Anderson wrote:
> > Hi,
> >
> > On Thu, Nov 24, 2022 at 3:27 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 24/11/2022 12:20, 楊宗翰 wrote:
> >>> Hi Krzysztof, Matthias,
> >>>
> >>> How to use "get_maintainers.pl"?
> >>>
> >>> I find this script in path "<MyCodebase>/kernel/v5.15/script", and output
> >>
> >> This looks like v5.15 kernel which is heavily outdated. Please never
> >> work on such kernels when interacting with upstream. The rule is you
> >> work on either last mainline kernel (v6.1-rc6), maintainers for-next
> >> branch (you should know who is the maintainer of subsystem you submit
> >> to, get_maintainers.pl gives this information) or on moderately recent
> >> linux-next. For bigger patchsets there might be exceptions for these
> >> rules, but it's not the case here.
> >
> > Just to add context here, it's a fairly standard workflow for ChromeOS
> > kernel engineers to work in a "versioned" kernel directory but still
> > checkout and work with the upstream kernel. I'm sure it's confusing to
> > anyone not used to working with the ChromeOS source tree and build
> > system. Sorry! :( So the fact that Owen is in a directory called
> > "v5.15" doesn't mean that he's actually working with the v5.15 kernel.
> > The fact that Bjorn's address is correct in his CC list implies to me
> > that he's actually got a proper upstream kernel.
> >
> > I had previously [0] instructed Owen to send against Bjorn's tree, so
> > hopefully it's correct.
>
> If it was on Bjorn's tree, get_maintainers.pl would not produce such result:
>
> ---
> Series-to: LKML <linux-kernel@vger.kernel.org>
> Series-cc: Douglas Anderson <dianders@chromium.org>
> Series-cc: Bob Moragues <moragues@chromium.org>
> Series-cc: Harvey <hunge@google.com>
> Series-cc: Stephen Boyd <swboyd@chromium.org>
> Series-cc: Matthias Kaehlcke <mka@chromium.org>
> Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
These look like manual entries for patman
> or this:
>
> ---
> owen@buildsvr-HP-ProDesk-600-G4-MT:~/chromebook_zombie_os/src/third_party/kernel/v5.15$
> perl scripts/get_maintainer.pl -f MAINTAINERS --email
> linux-kernel@vger.kernel.org (open list)
> ---
>
> as Owen indicated earlier. They are either incomplete or not correct.
>
> Of course I don't know whether the base tree is the problem or usage of
> get_maintainers.pl...
That looks like an operator error, the above command produces the same result with
an upstream tree.
Issue one is the use of '-f' which seems to expect a file with a list of e-mail
addresses, which MAINTAINERS is not. The second issue is that no patch file or
directory is specified.
next prev parent reply other threads:[~2022-11-28 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 3:57 [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie Owen Yang
2022-11-24 3:57 ` [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie Owen Yang
[not found] ` <CAPao8GK93KMrtaXw7mNWOCE60zk=uCENLfBXhNRVxJXEnnaGFg@mail.gmail.com>
2022-11-24 9:29 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie Krzysztof Kozlowski
[not found] ` <CAPao8GKbdK79Z7w91x0T6JW9v6VFoeYSaXGGAuzB_=ukR9g0_w@mail.gmail.com>
2022-11-24 11:27 ` Krzysztof Kozlowski
2022-11-28 15:56 ` Doug Anderson
2022-11-28 17:22 ` Krzysztof Kozlowski
2022-11-28 17:41 ` Matthias Kaehlcke [this message]
2022-11-28 18:55 ` Doug Anderson
2022-11-28 15:51 ` Doug Anderson
2022-11-28 17:30 ` Krzysztof Kozlowski
2022-11-28 19:01 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4TyuqPQtZBFChKD@google.com \
--to=mka@chromium.org \
--cc=Abner.Yen@ecs.com.tw \
--cc=Darren.Chen@ecs.com.tw \
--cc=Gavin.Lee@ecs.com.tw \
--cc=Jason.Huang@ecs.com.tw \
--cc=Vicy.Lee@ecs.com.tw \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=ecs.taipeikernel@gmail.com \
--cc=hunge@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).