Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: 楊宗翰 <ecs.taipeikernel@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Bob Moragues" <moragues@chromium.org>,
	"Stephen Boyd" <swboyd@chromium.org>, Harvey <hunge@google.com>,
	"Matthias Kaehlcke" <mka@chromium.org>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Gavin.Lee@ecs.com.tw, Darren.Chen@ecs.com.tw,
	Abner.Yen@ecs.com.tw, Vicy.Lee@ecs.com.tw,
	Jason.Huang@ecs.com.tw
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Add zombie
Date: Mon, 28 Nov 2022 18:22:39 +0100	[thread overview]
Message-ID: <f92ce2ed-80b5-eb26-36a4-2384a7a8510f@linaro.org> (raw)
In-Reply-To: <CAD=FV=X9C8nLDrEpZE2tLtq6Brn9cd-15+1JWFOL4cPYdJs5Dg@mail.gmail.com>

On 28/11/2022 16:56, Doug Anderson wrote:
> Hi,
> 
> On Thu, Nov 24, 2022 at 3:27 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 24/11/2022 12:20, 楊宗翰 wrote:
>>> Hi Krzysztof, Matthias,
>>>
>>> How to use "get_maintainers.pl"?
>>>
>>> I find this script in path "<MyCodebase>/kernel/v5.15/script", and output
>>
>> This looks like v5.15 kernel which is heavily outdated. Please never
>> work on such kernels when interacting with upstream. The rule is you
>> work on either last mainline kernel (v6.1-rc6), maintainers for-next
>> branch (you should know who is the maintainer of subsystem you submit
>> to, get_maintainers.pl gives this information) or on moderately recent
>> linux-next. For bigger patchsets there might be exceptions for these
>> rules, but it's not the case here.
> 
> Just to add context here, it's a fairly standard workflow for ChromeOS
> kernel engineers to work in a "versioned" kernel directory but still
> checkout and work with the upstream kernel. I'm sure it's confusing to
> anyone not used to working with the ChromeOS source tree and build
> system. Sorry! :( So the fact that Owen is in a directory called
> "v5.15" doesn't mean that he's actually working with the v5.15 kernel.
> The fact that Bjorn's address is correct in his CC list implies to me
> that he's actually got a proper upstream kernel.
> 
> I had previously [0] instructed Owen to send against Bjorn's tree, so
> hopefully it's correct.

If it was on Bjorn's tree, get_maintainers.pl would not produce such result:

---
Series-to: LKML <linux-kernel@vger.kernel.org>
Series-cc: Douglas Anderson <dianders@chromium.org>
Series-cc: Bob Moragues <moragues@chromium.org>
Series-cc: Harvey <hunge@google.com>
Series-cc: Stephen Boyd <swboyd@chromium.org>
Series-cc: Matthias Kaehlcke <mka@chromium.org>
Series-cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

or this:

---
owen@buildsvr-HP-ProDesk-600-G4-MT:~/chromebook_zombie_os/src/third_party/kernel/v5.15$
perl scripts/get_maintainer.pl -f MAINTAINERS --email
linux-kernel@vger.kernel.org (open list)
---

as Owen indicated earlier. They are either incomplete or not correct.

Of course I don't know whether the base tree is the problem or usage of
get_maintainers.pl...

Best regards,
Krzysztof