* [PATCH -next] net/mlx5: fix missing mutex_unlock in mlx5_fw_fatal_reporter_err_work()
@ 2023-01-05 11:42 Yang Yingliang
2023-01-05 13:16 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2023-01-05 11:42 UTC (permalink / raw)
To: linux-kernel, linux-rdma; +Cc: saeedm, moshe, shayd, yangyingliang
Add missing mutex_unlock() before returning from
mlx5_fw_fatal_reporter_err_work().
Fixes: 9078e843efec ("net/mlx5: Avoid recovery in probe flows")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/health.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
index 96417c5feed7..879555ba847d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
@@ -677,6 +677,7 @@ static void mlx5_fw_fatal_reporter_err_work(struct work_struct *work)
mutex_lock(&dev->intf_state_mutex);
if (test_bit(MLX5_DROP_NEW_HEALTH_WORK, &health->flags)) {
mlx5_core_err(dev, "health works are not permitted at this stage\n");
+ mutex_unlock(&dev->intf_state_mutex);
return;
}
mutex_unlock(&dev->intf_state_mutex);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net/mlx5: fix missing mutex_unlock in mlx5_fw_fatal_reporter_err_work()
2023-01-05 11:42 [PATCH -next] net/mlx5: fix missing mutex_unlock in mlx5_fw_fatal_reporter_err_work() Yang Yingliang
@ 2023-01-05 13:16 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2023-01-05 13:16 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, linux-rdma, saeedm, moshe, shayd
On Thu, Jan 05, 2023 at 07:42:20PM +0800, Yang Yingliang wrote:
> Add missing mutex_unlock() before returning from
> mlx5_fw_fatal_reporter_err_work().
>
> Fixes: 9078e843efec ("net/mlx5: Avoid recovery in probe flows")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/health.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
> index 96417c5feed7..879555ba847d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
> @@ -677,6 +677,7 @@ static void mlx5_fw_fatal_reporter_err_work(struct work_struct *work)
> mutex_lock(&dev->intf_state_mutex);
> if (test_bit(MLX5_DROP_NEW_HEALTH_WORK, &health->flags)) {
> mlx5_core_err(dev, "health works are not permitted at this stage\n");
> + mutex_unlock(&dev->intf_state_mutex);
> return;
> }
> mutex_unlock(&dev->intf_state_mutex);
Shay is working to rewrite 9078e843efec ("net/mlx5: Avoid recovery in probe flows") completely.
Thanks
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-05 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 11:42 [PATCH -next] net/mlx5: fix missing mutex_unlock in mlx5_fw_fatal_reporter_err_work() Yang Yingliang
2023-01-05 13:16 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).