* [PATCH RESEND 4/4] backlight: tosa: Use backlight helper
@ 2023-01-06 16:48 Stephen Kitt
2023-01-06 17:47 ` Sam Ravnborg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stephen Kitt @ 2023-01-06 16:48 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han
Cc: Sam Ravnborg, Stephen Kitt, Helge Deller, dri-devel, linux-fbdev,
linux-kernel
Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.
Signed-off-by: Stephen Kitt <steve@sk2.org>
---
drivers/video/backlight/tosa_bl.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
index 77b71f6c19b5..e338b1f00f6a 100644
--- a/drivers/video/backlight/tosa_bl.c
+++ b/drivers/video/backlight/tosa_bl.c
@@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness)
static int tosa_bl_update_status(struct backlight_device *dev)
{
- struct backlight_properties *props = &dev->props;
struct tosa_bl_data *data = bl_get_data(dev);
- int power = max(props->power, props->fb_blank);
- int brightness = props->brightness;
-
- if (power)
- brightness = 0;
+ int brightness = backlight_get_brightness(dev);
tosa_bl_set_backlight(data, brightness);
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND 4/4] backlight: tosa: Use backlight helper
2023-01-06 16:48 [PATCH RESEND 4/4] backlight: tosa: Use backlight helper Stephen Kitt
@ 2023-01-06 17:47 ` Sam Ravnborg
2023-01-06 22:26 ` Sam Ravnborg
2023-01-09 10:18 ` Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2023-01-06 17:47 UTC (permalink / raw)
To: Stephen Kitt
Cc: Lee Jones, Daniel Thompson, Jingoo Han, linux-fbdev,
Helge Deller, linux-kernel, dri-devel
On Fri, Jan 06, 2023 at 05:48:55PM +0100, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/video/backlight/tosa_bl.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
> index 77b71f6c19b5..e338b1f00f6a 100644
> --- a/drivers/video/backlight/tosa_bl.c
> +++ b/drivers/video/backlight/tosa_bl.c
> @@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness)
>
> static int tosa_bl_update_status(struct backlight_device *dev)
> {
> - struct backlight_properties *props = &dev->props;
> struct tosa_bl_data *data = bl_get_data(dev);
> - int power = max(props->power, props->fb_blank);
> - int brightness = props->brightness;
> -
> - if (power)
> - brightness = 0;
> + int brightness = backlight_get_brightness(dev);
>
> tosa_bl_set_backlight(data, brightness);
>
> --
> 2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND 4/4] backlight: tosa: Use backlight helper
2023-01-06 16:48 [PATCH RESEND 4/4] backlight: tosa: Use backlight helper Stephen Kitt
2023-01-06 17:47 ` Sam Ravnborg
@ 2023-01-06 22:26 ` Sam Ravnborg
2023-01-09 10:18 ` Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2023-01-06 22:26 UTC (permalink / raw)
To: Stephen Kitt
Cc: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, dri-devel,
linux-fbdev, linux-kernel
On Fri, Jan 06, 2023 at 05:48:55PM +0100, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
I just realized...
This driver is about to be deleted by Arnd's effort to remove
the PXA platform, so the patch is not relevant and can be ignored.
See https://lore.kernel.org/dri-devel/20221019161831.3864786-1-arnd@kernel.org/
Sam
> ---
> drivers/video/backlight/tosa_bl.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
> index 77b71f6c19b5..e338b1f00f6a 100644
> --- a/drivers/video/backlight/tosa_bl.c
> +++ b/drivers/video/backlight/tosa_bl.c
> @@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness)
>
> static int tosa_bl_update_status(struct backlight_device *dev)
> {
> - struct backlight_properties *props = &dev->props;
> struct tosa_bl_data *data = bl_get_data(dev);
> - int power = max(props->power, props->fb_blank);
> - int brightness = props->brightness;
> -
> - if (power)
> - brightness = 0;
> + int brightness = backlight_get_brightness(dev);
>
> tosa_bl_set_backlight(data, brightness);
>
> --
> 2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND 4/4] backlight: tosa: Use backlight helper
2023-01-06 16:48 [PATCH RESEND 4/4] backlight: tosa: Use backlight helper Stephen Kitt
2023-01-06 17:47 ` Sam Ravnborg
2023-01-06 22:26 ` Sam Ravnborg
@ 2023-01-09 10:18 ` Daniel Thompson
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Thompson @ 2023-01-09 10:18 UTC (permalink / raw)
To: Stephen Kitt
Cc: Lee Jones, Jingoo Han, Sam Ravnborg, Helge Deller, dri-devel,
linux-fbdev, linux-kernel
On Fri, Jan 06, 2023 at 05:48:55PM +0100, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
For the tools:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
D.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-09 10:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 16:48 [PATCH RESEND 4/4] backlight: tosa: Use backlight helper Stephen Kitt
2023-01-06 17:47 ` Sam Ravnborg
2023-01-06 22:26 ` Sam Ravnborg
2023-01-09 10:18 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).