[PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[Luis Chamberlain]

After discussions internally at the company, Javier has been volunteered
and is willing to be the embargoed hardware contact for Samsung.

Cc: Javier González <javier.gonz@samsung.com>
Signed-off-by: Luis Chamberlain <mcgrof.c@samsung.com>
---
 Documentation/process/embargoed-hardware-issues.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/process/embargoed-hardware-issues.rst b/Documentation/process/embargoed-hardware-issues.rst
index b6b4481e2474..fbb754253cf7 100644
--- a/Documentation/process/embargoed-hardware-issues.rst
+++ b/Documentation/process/embargoed-hardware-issues.rst
@@ -251,6 +251,7 @@ an involved disclosed party. The current ambassadors list:
   IBM Z		Christian Borntraeger <borntraeger@de.ibm.com>
   Intel		Tony Luck <tony.luck@intel.com>
   Qualcomm	Trilok Soni <tsoni@codeaurora.org>
+  Samsung       Javier González <javier.gonz@samsung.com>
 
   Microsoft	James Morris <jamorris@linux.microsoft.com>
   VMware
-- 
2.35.1

Re: [PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[Greg KH]

On Mon, Jan 23, 2023 at 10:39:26AM -0800, Luis Chamberlain wrote:
> After discussions internally at the company, Javier has been volunteered
> and is willing to be the embargoed hardware contact for Samsung.
> 
> Cc: Javier González <javier.gonz@samsung.com>
> Signed-off-by: Luis Chamberlain <mcgrof.c@samsung.com>
> ---
>  Documentation/process/embargoed-hardware-issues.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/process/embargoed-hardware-issues.rst b/Documentation/process/embargoed-hardware-issues.rst
> index b6b4481e2474..fbb754253cf7 100644
> --- a/Documentation/process/embargoed-hardware-issues.rst
> +++ b/Documentation/process/embargoed-hardware-issues.rst
> @@ -251,6 +251,7 @@ an involved disclosed party. The current ambassadors list:
>    IBM Z		Christian Borntraeger <borntraeger@de.ibm.com>
>    Intel		Tony Luck <tony.luck@intel.com>
>    Qualcomm	Trilok Soni <tsoni@codeaurora.org>
> +  Samsung       Javier González <javier.gonz@samsung.com>

No tab?  :(

Re: [PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[Luis Chamberlain]

On Mon, Jan 23, 2023 at 07:54:34PM +0100, Greg KH wrote:
> On Mon, Jan 23, 2023 at 10:39:26AM -0800, Luis Chamberlain wrote:
> > After discussions internally at the company, Javier has been volunteered
> > and is willing to be the embargoed hardware contact for Samsung.
> > 
> > Cc: Javier González <javier.gonz@samsung.com>
> > Signed-off-by: Luis Chamberlain <mcgrof.c@samsung.com>
> > ---
> >  Documentation/process/embargoed-hardware-issues.rst | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/process/embargoed-hardware-issues.rst b/Documentation/process/embargoed-hardware-issues.rst
> > index b6b4481e2474..fbb754253cf7 100644
> > --- a/Documentation/process/embargoed-hardware-issues.rst
> > +++ b/Documentation/process/embargoed-hardware-issues.rst
> > @@ -251,6 +251,7 @@ an involved disclosed party. The current ambassadors list:
> >    IBM Z		Christian Borntraeger <borntraeger@de.ibm.com>
> >    Intel		Tony Luck <tony.luck@intel.com>
> >    Qualcomm	Trilok Soni <tsoni@codeaurora.org>
> > +  Samsung       Javier González <javier.gonz@samsung.com>
> 
> No tab?  :(

I'll send a fix on v2.

BTW while at it, it got me wondering, since most of the emails on
this hw embargo page are not required to have kernel.org accounts
not all of the folks on that page have a PGP key on the pgpkeys git
tree [0]. Today we constrain kernel.org accounts to folks that send
pull requests to Linus. Not all folks on the embargo list need to also
be active kernel developers. Given the issues reported before by Konstantin
on PGP keyservers we rely on our own git tree for keys we wish to get access
to in our community. The below email addresses do not have any PGP
key associated on the pgpkeys tree as of this day.

  * Tom Lendacky <thomas.lendacky@amd.com>
  * Catalin Marinas <catalin.marinas@arm.com>
  * Anton Blanchard <anton@linux.ibm.com>
  * Trilok Soni <tsoni@codeaurora.org>
  * James Morris <jamorris@linux.microsoft.com

So it occurs to me to perhaps modify pgpg keys documentation to welcome
community related keys to at least include folks like the above for the
hw embargo emails should communication via PGP be required. Thoughts?

[0] https://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git

  Luis

Re: [PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[Matthew Wilcox]

On Mon, Jan 23, 2023 at 01:48:03PM -0800, Luis Chamberlain wrote:
> > > @@ -251,6 +251,7 @@ an involved disclosed party. The current ambassadors list:
> > >    IBM Z		Christian Borntraeger <borntraeger@de.ibm.com>
> > >    Intel		Tony Luck <tony.luck@intel.com>
> > >    Qualcomm	Trilok Soni <tsoni@codeaurora.org>
> > > +  Samsung       Javier González <javier.gonz@samsung.com>
> 
> I'll send a fix on v2.
> 
> BTW while at it, it got me wondering, since most of the emails on
> this hw embargo page are not required to have kernel.org accounts

This isn't the list of hw embargo people.  This is the list of
"ambassadors" who can help people work through the security disclosure
process.  My impression is that it's to tell me that I should contact
Konrad, since he also works at Oracle, to help me through the process.
It's not for people outside Oracle to contact.

If I have the wrong impression of that list, perhaps the description
could be clarified.

> not all of the folks on that page have a PGP key on the pgpkeys git
> tree [0]. Today we constrain kernel.org accounts to folks that send
> pull requests to Linus. Not all folks on the embargo list need to also
> be active kernel developers. Given the issues reported before by Konstantin
> on PGP keyservers we rely on our own git tree for keys we wish to get access
> to in our community. The below email addresses do not have any PGP
> key associated on the pgpkeys tree as of this day.
> 
>   * Tom Lendacky <thomas.lendacky@amd.com>
>   * Catalin Marinas <catalin.marinas@arm.com>
>   * Anton Blanchard <anton@linux.ibm.com>
>   * Trilok Soni <tsoni@codeaurora.org>
>   * James Morris <jamorris@linux.microsoft.com
> 
> So it occurs to me to perhaps modify pgpg keys documentation to welcome
> community related keys to at least include folks like the above for the
> hw embargo emails should communication via PGP be required. Thoughts?
> 
> [0] https://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git
> 
>   Luis

Re: [PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[Greg KH]

On Tue, Jan 24, 2023 at 02:39:53AM +0000, Matthew Wilcox wrote:
> On Mon, Jan 23, 2023 at 01:48:03PM -0800, Luis Chamberlain wrote:
> > > > @@ -251,6 +251,7 @@ an involved disclosed party. The current ambassadors list:
> > > >    IBM Z		Christian Borntraeger <borntraeger@de.ibm.com>
> > > >    Intel		Tony Luck <tony.luck@intel.com>
> > > >    Qualcomm	Trilok Soni <tsoni@codeaurora.org>
> > > > +  Samsung       Javier González <javier.gonz@samsung.com>
> > 
> > I'll send a fix on v2.
> > 
> > BTW while at it, it got me wondering, since most of the emails on
> > this hw embargo page are not required to have kernel.org accounts
> 
> This isn't the list of hw embargo people.  This is the list of
> "ambassadors" who can help people work through the security disclosure
> process.  My impression is that it's to tell me that I should contact
> Konrad, since he also works at Oracle, to help me through the process.
> It's not for people outside Oracle to contact.
> 
> If I have the wrong impression of that list, perhaps the description
> could be clarified.

That is correct, but it is primarily a list that I use when needing to
contact companies about potential issues in their hardware.  For that I
don't need a GPG key, that's only required if they need to get added to
a secure mailing list, and at that point I can have a key sent to me, it
does not have to be in our kernel.org keyring at all (and list
participants usually are not there.)

So there's no need for any of these addresses to be part of the kernel
gpg ring of trust for any of their activities.

thanks,

greg k-h

Re: [PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[Catalin Marinas]

On Mon, Jan 23, 2023 at 01:48:03PM -0800, Luis Chamberlain wrote:
> The below email addresses do not have any PGP
> key associated on the pgpkeys tree as of this day.
[...]
>   * Catalin Marinas <catalin.marinas@arm.com>

FWIW, this one does have a key: keys/6BD6B12D00C85EF1.asc

-- 
Catalin

Re: [PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[Luis Chamberlain]

On Tue, Jan 24, 2023 at 06:20:46AM +0100, Greg KH wrote:
> On Tue, Jan 24, 2023 at 02:39:53AM +0000, Matthew Wilcox wrote:
> > On Mon, Jan 23, 2023 at 01:48:03PM -0800, Luis Chamberlain wrote:
> > > > > @@ -251,6 +251,7 @@ an involved disclosed party. The current ambassadors list:
> > > > >    IBM Z		Christian Borntraeger <borntraeger@de.ibm.com>
> > > > >    Intel		Tony Luck <tony.luck@intel.com>
> > > > >    Qualcomm	Trilok Soni <tsoni@codeaurora.org>
> > > > > +  Samsung       Javier González <javier.gonz@samsung.com>
> > > 
> > > I'll send a fix on v2.
> > > 
> > > BTW while at it, it got me wondering, since most of the emails on
> > > this hw embargo page are not required to have kernel.org accounts
> > 
> > This isn't the list of hw embargo people.  This is the list of
> > "ambassadors" who can help people work through the security disclosure
> > process.  My impression is that it's to tell me that I should contact
> > Konrad, since he also works at Oracle, to help me through the process.
> > It's not for people outside Oracle to contact.
> > 
> > If I have the wrong impression of that list, perhaps the description
> > could be clarified.
> 
> That is correct, but it is primarily a list that I use when needing to
> contact companies about potential issues in their hardware. 

That is the impression I gathered.

> For that I
> don't need a GPG key, that's only required if they need to get added to
> a secure mailing list, and at that point I can have a key sent to me, it
> does not have to be in our kernel.org keyring at all (and list
> participants usually are not there.)

That might be useful to explain in the documentation.

> So there's no need for any of these addresses to be part of the kernel
> gpg ring of trust for any of their activities.

Sounds good.

  Luis

Re: [PATCH] docs: embargoed-hardware-issues: add embargoed HW contact for Samsung

[Greg KH]

On Tue, Jan 24, 2023 at 08:22:45AM -0800, Luis Chamberlain wrote:
> On Tue, Jan 24, 2023 at 06:20:46AM +0100, Greg KH wrote:
> > On Tue, Jan 24, 2023 at 02:39:53AM +0000, Matthew Wilcox wrote:
> > > On Mon, Jan 23, 2023 at 01:48:03PM -0800, Luis Chamberlain wrote:
> > > > > > @@ -251,6 +251,7 @@ an involved disclosed party. The current ambassadors list:
> > > > > >    IBM Z		Christian Borntraeger <borntraeger@de.ibm.com>
> > > > > >    Intel		Tony Luck <tony.luck@intel.com>
> > > > > >    Qualcomm	Trilok Soni <tsoni@codeaurora.org>
> > > > > > +  Samsung       Javier González <javier.gonz@samsung.com>
> > > > 
> > > > I'll send a fix on v2.
> > > > 
> > > > BTW while at it, it got me wondering, since most of the emails on
> > > > this hw embargo page are not required to have kernel.org accounts
> > > 
> > > This isn't the list of hw embargo people.  This is the list of
> > > "ambassadors" who can help people work through the security disclosure
> > > process.  My impression is that it's to tell me that I should contact
> > > Konrad, since he also works at Oracle, to help me through the process.
> > > It's not for people outside Oracle to contact.
> > > 
> > > If I have the wrong impression of that list, perhaps the description
> > > could be clarified.
> > 
> > That is correct, but it is primarily a list that I use when needing to
> > contact companies about potential issues in their hardware. 
> 
> That is the impression I gathered.
> 
> > For that I
> > don't need a GPG key, that's only required if they need to get added to
> > a secure mailing list, and at that point I can have a key sent to me, it
> > does not have to be in our kernel.org keyring at all (and list
> > participants usually are not there.)
> 
> That might be useful to explain in the documentation.

It is not really needed as the kernel.org gpg keyring has nothing to do
with this list or the people on it.  No need to say "that other thing
over there has nothing to do with this thing here", otherwise we would
be enumerating everything in this file :)

thanks,

greg k-h