linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel
@ 2023-01-28  6:35 Frank Sae
  2023-01-28  6:35 ` [PATCH net-next v1] net: phy: motorcomm: change the phy id of yt8521 and yt8531s to lowercase Frank Sae
  2023-01-28 15:01 ` [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel Andrew Lunn
  0 siblings, 2 replies; 4+ messages in thread
From: Frank Sae @ 2023-01-28  6:35 UTC (permalink / raw)
  To: Peter Geis, Andrew Lunn, Heiner Kallweit, Russell King,
	David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: xiaogang.fan, fei.zhang, hua.sun, netdev, linux-kernel, Frank

 CHECK: 'sentinal' may be misspelled - perhaps 'sentinel'?

Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>
---
 drivers/net/phy/motorcomm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index 685190db72de..b6968c78c303 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -1804,7 +1804,7 @@ static const struct mdio_device_id __maybe_unused motorcomm_tbl[] = {
 	{ PHY_ID_MATCH_EXACT(PHY_ID_YT8511) },
 	{ PHY_ID_MATCH_EXACT(PHY_ID_YT8521) },
 	{ PHY_ID_MATCH_EXACT(PHY_ID_YT8531S) },
-	{ /* sentinal */ }
+	{ /* sentinel */ }
 };
 
 MODULE_DEVICE_TABLE(mdio, motorcomm_tbl);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH net-next v1] net: phy: motorcomm: change the phy id of yt8521 and yt8531s to lowercase
  2023-01-28  6:35 [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel Frank Sae
@ 2023-01-28  6:35 ` Frank Sae
  2023-01-28 15:01   ` Andrew Lunn
  2023-01-28 15:01 ` [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel Andrew Lunn
  1 sibling, 1 reply; 4+ messages in thread
From: Frank Sae @ 2023-01-28  6:35 UTC (permalink / raw)
  To: Peter Geis, Andrew Lunn, Heiner Kallweit, Russell King,
	David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: xiaogang.fan, fei.zhang, hua.sun, netdev, linux-kernel, Frank

 The phy id is usually defined in lower case.

Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>
---
 drivers/net/phy/motorcomm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index b6968c78c303..aa02e722c51d 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -12,8 +12,8 @@
 #include <linux/phy.h>
 
 #define PHY_ID_YT8511		0x0000010a
-#define PHY_ID_YT8521		0x0000011A
-#define PHY_ID_YT8531S		0x4F51E91A
+#define PHY_ID_YT8521		0x0000011a
+#define PHY_ID_YT8531S		0x4f51e91a
 
 /* YT8521/YT8531S Register Overview
  *	UTP Register space	|	FIBER Register space
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel
  2023-01-28  6:35 [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel Frank Sae
  2023-01-28  6:35 ` [PATCH net-next v1] net: phy: motorcomm: change the phy id of yt8521 and yt8531s to lowercase Frank Sae
@ 2023-01-28 15:01 ` Andrew Lunn
  1 sibling, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2023-01-28 15:01 UTC (permalink / raw)
  To: Frank Sae
  Cc: Peter Geis, Heiner Kallweit, Russell King, David S . Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, xiaogang.fan,
	fei.zhang, hua.sun, netdev, linux-kernel

On Sat, Jan 28, 2023 at 02:35:57PM +0800, Frank Sae wrote:
>  CHECK: 'sentinal' may be misspelled - perhaps 'sentinel'?
> 
> Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next v1] net: phy: motorcomm: change the phy id of yt8521 and yt8531s to lowercase
  2023-01-28  6:35 ` [PATCH net-next v1] net: phy: motorcomm: change the phy id of yt8521 and yt8531s to lowercase Frank Sae
@ 2023-01-28 15:01   ` Andrew Lunn
  0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2023-01-28 15:01 UTC (permalink / raw)
  To: Frank Sae
  Cc: Peter Geis, Heiner Kallweit, Russell King, David S . Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, xiaogang.fan,
	fei.zhang, hua.sun, netdev, linux-kernel

On Sat, Jan 28, 2023 at 02:35:58PM +0800, Frank Sae wrote:
>  The phy id is usually defined in lower case.
> 
> Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-28 15:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28  6:35 [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel Frank Sae
2023-01-28  6:35 ` [PATCH net-next v1] net: phy: motorcomm: change the phy id of yt8521 and yt8531s to lowercase Frank Sae
2023-01-28 15:01   ` Andrew Lunn
2023-01-28 15:01 ` [PATCH net-next v1] net: phy: fix the spelling problem of Sentinel Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).