archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <>
To: Dmitry Torokhov <>
Cc: Wei Fang <>, Jakub Kicinski <>,
	Arnd Bergmann <>,
	Shenwei Wang <>,
	Clark Wang <>,
	NXP Linux Team <>,
	"David S. Miller" <>,
	Eric Dumazet <>,
	Paolo Abeni <>,
	Marc Kleine-Budde <>,,
Subject: Re: [PATCH v2] net: fec: fix conversion to gpiod API
Date: Wed, 1 Feb 2023 19:04:29 +0100	[thread overview]
Message-ID: <Y9qprbyr/> (raw)
In-Reply-To: <Y9nbJJP/>

On Tue, Jan 31, 2023 at 07:23:16PM -0800, Dmitry Torokhov wrote:
> The reset line is optional, so we should be using devm_gpiod_get_optional()
> and not abort probing if it is not available. Also, there is a quirk in
> gpiolib (introduced in b02c85c9458cdd15e2c43413d7d2541a468cde57) that
> transparently handles "phy-reset-active-high" property. Remove handling
> from the driver to avoid ending up with the double inversion/flipped
> logic.
> Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
> Signed-off-by: Dmitry Torokhov <>

Please split this into two:

1) Fix for it being optional
2) Removing support for phy-reset-active-high

The breakage is in net-next, so we are not in a rush, and we don't
need a minimum of patches. So since this is two logical changes, it
should be two patches.

Please also update the binding document to indicate that
'phy-reset-active-high' is no longer deprecated, it has actually been
removed. So we want the DT checking tools to error out if such a
property is found.


  parent reply	other threads:[~2023-02-01 18:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01  3:23 [PATCH v2] net: fec: fix conversion to gpiod API Dmitry Torokhov
2023-02-01  8:46 ` Marc Kleine-Budde
2023-02-01 18:04 ` Andrew Lunn [this message]
2023-02-01 18:25   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9qprbyr/ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).