* [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c
@ 2021-02-03 15:15 Bhaskar Chowdhury
2021-02-03 17:54 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Bhaskar Chowdhury @ 2021-02-03 15:15 UTC (permalink / raw)
To: linux, davem, kuba, linux-arm-kernel, netdev, linux-kernel
Cc: rdunlap, Bhaskar Chowdhury
s/initialsation/initialisation/
s/specifiing/specifying/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
drivers/net/ethernet/i825xx/ether1.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
index a0bfb509e002..0233fb6e222d 100644
--- a/drivers/net/ethernet/i825xx/ether1.c
+++ b/drivers/net/ethernet/i825xx/ether1.c
@@ -20,7 +20,7 @@
* 1.02 RMK 25/05/1997 Added code to restart RU if it goes not ready
* 1.03 RMK 14/09/1997 Cleaned up the handling of a reset during the TX interrupt.
* Should prevent lockup.
- * 1.04 RMK 17/09/1997 Added more info when initialsation of chip goes wrong.
+ * 1.04 RMK 17/09/1997 Added more info when initialisation of chip goes wrong.
* TDR now only reports failure when chip reports non-zero
* TDR time-distance.
* 1.05 RMK 31/12/1997 Removed calls to dev_tint for 2.1
@@ -117,7 +117,7 @@ ether1_outw_p (struct net_device *dev, unsigned short val, int addr, int svflgs)
* Some inline assembler to allow fast transfers on to/off of the card.
* Since this driver depends on some features presented by the ARM
* specific architecture, and that you can't configure this driver
- * without specifiing ARM mode, this is not a problem.
+ * without specifying ARM mode, this is not a problem.
*
* This routine is essentially an optimised memcpy from the card's
* onboard RAM to kernel memory.
@@ -885,7 +885,7 @@ ether1_recv_done (struct net_device *dev)
ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_command, NORMALIRQS);
ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_status, NORMALIRQS);
ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_rbdoffset, NORMALIRQS);
-
+
priv(dev)->rx_tail = nexttail;
priv(dev)->rx_head = ether1_readw(dev, priv(dev)->rx_head, rfd_t, rfd_link, NORMALIRQS);
} while (1);
@@ -1031,7 +1031,7 @@ ether1_probe(struct expansion_card *ec, const struct ecard_id *id)
printk(KERN_INFO "%s: ether1 in slot %d, %pM\n",
dev->name, ec->slot_no, dev->dev_addr);
-
+
ecard_set_drvdata(ec, dev);
return 0;
@@ -1047,7 +1047,7 @@ static void ether1_remove(struct expansion_card *ec)
{
struct net_device *dev = ecard_get_drvdata(ec);
- ecard_set_drvdata(ec, NULL);
+ ecard_set_drvdata(ec, NULL);
unregister_netdev(dev);
free_netdev(dev);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c
2021-02-03 15:15 [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c Bhaskar Chowdhury
@ 2021-02-03 17:54 ` Randy Dunlap
2021-02-03 20:13 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-02-03 17:54 UTC (permalink / raw)
To: Bhaskar Chowdhury, linux, davem, kuba, linux-arm-kernel, netdev,
linux-kernel
On 2/3/21 7:15 AM, Bhaskar Chowdhury wrote:
>
> s/initialsation/initialisation/
> s/specifiing/specifying/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
Hi,
$Subject has a typo/spello.
The 2 fixes below look good (as explained in the patch description),
but:
can you explain the 3 changes below that AFAICT do nothing?
> ---
> drivers/net/ethernet/i825xx/ether1.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
> index a0bfb509e002..0233fb6e222d 100644
> --- a/drivers/net/ethernet/i825xx/ether1.c
> +++ b/drivers/net/ethernet/i825xx/ether1.c
> @@ -885,7 +885,7 @@ ether1_recv_done (struct net_device *dev)
> ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_command, NORMALIRQS);
> ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_status, NORMALIRQS);
> ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_rbdoffset, NORMALIRQS);
> -
> +
> priv(dev)->rx_tail = nexttail;
> priv(dev)->rx_head = ether1_readw(dev, priv(dev)->rx_head, rfd_t, rfd_link, NORMALIRQS);
> } while (1);
> @@ -1031,7 +1031,7 @@ ether1_probe(struct expansion_card *ec, const struct ecard_id *id)
>
> printk(KERN_INFO "%s: ether1 in slot %d, %pM\n",
> dev->name, ec->slot_no, dev->dev_addr);
> -
> +
> ecard_set_drvdata(ec, dev);
> return 0;
>
> @@ -1047,7 +1047,7 @@ static void ether1_remove(struct expansion_card *ec)
> {
> struct net_device *dev = ecard_get_drvdata(ec);
>
> - ecard_set_drvdata(ec, NULL);
> + ecard_set_drvdata(ec, NULL);
>
> unregister_netdev(dev);
> free_netdev(dev);
> --
> 2.26.2
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c
2021-02-03 17:54 ` Randy Dunlap
@ 2021-02-03 20:13 ` Jakub Kicinski
2021-02-03 23:51 ` Bhaskar Chowdhury
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2021-02-03 20:13 UTC (permalink / raw)
To: Randy Dunlap
Cc: Bhaskar Chowdhury, linux, davem, linux-arm-kernel, netdev, linux-kernel
On Wed, 3 Feb 2021 09:54:22 -0800 Randy Dunlap wrote:
> On 2/3/21 7:15 AM, Bhaskar Chowdhury wrote:
> >
> > s/initialsation/initialisation/
> > s/specifiing/specifying/
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>
> Hi,
>
> $Subject has a typo/spello.
This happens more than you'd think with spell fixies. Always makes me
chuckle. FWIW "net: i825xx:" is enough of a prefix, no need to
transcribe the entire directory path.
> The 2 fixes below look good (as explained in the patch description),
> but:
> can you explain the 3 changes below that AFAICT do nothing?
I think we can jump to the conclusion that Bhaskar's editor cleanup up
trailing white space.
Bhaskar please make sure that the patch does not make unrelated white
space changes.
> > drivers/net/ethernet/i825xx/ether1.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
> > index a0bfb509e002..0233fb6e222d 100644
> > --- a/drivers/net/ethernet/i825xx/ether1.c
> > +++ b/drivers/net/ethernet/i825xx/ether1.c
> > @@ -885,7 +885,7 @@ ether1_recv_done (struct net_device *dev)
> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_command, NORMALIRQS);
> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_status, NORMALIRQS);
> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_rbdoffset, NORMALIRQS);
> > -
> > +
> > priv(dev)->rx_tail = nexttail;
> > priv(dev)->rx_head = ether1_readw(dev, priv(dev)->rx_head, rfd_t, rfd_link, NORMALIRQS);
> > } while (1);
> > @@ -1031,7 +1031,7 @@ ether1_probe(struct expansion_card *ec, const struct ecard_id *id)
> >
> > printk(KERN_INFO "%s: ether1 in slot %d, %pM\n",
> > dev->name, ec->slot_no, dev->dev_addr);
> > -
> > +
> > ecard_set_drvdata(ec, dev);
> > return 0;
> >
> > @@ -1047,7 +1047,7 @@ static void ether1_remove(struct expansion_card *ec)
> > {
> > struct net_device *dev = ecard_get_drvdata(ec);
> >
> > - ecard_set_drvdata(ec, NULL);
> > + ecard_set_drvdata(ec, NULL);
> >
> > unregister_netdev(dev);
> > free_netdev(dev);
> > --
> > 2.26.2
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c
2021-02-03 20:13 ` Jakub Kicinski
@ 2021-02-03 23:51 ` Bhaskar Chowdhury
0 siblings, 0 replies; 4+ messages in thread
From: Bhaskar Chowdhury @ 2021-02-03 23:51 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Randy Dunlap, linux, davem, linux-arm-kernel, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]
On 12:13 Wed 03 Feb 2021, Jakub Kicinski wrote:
>On Wed, 3 Feb 2021 09:54:22 -0800 Randy Dunlap wrote:
>> On 2/3/21 7:15 AM, Bhaskar Chowdhury wrote:
>> >
>> > s/initialsation/initialisation/
>> > s/specifiing/specifying/
>> >
>> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>
>> Hi,
>>
>> $Subject has a typo/spello.
>
>This happens more than you'd think with spell fixies. Always makes me
>chuckle. FWIW "net: i825xx:" is enough of a prefix, no need to
>transcribe the entire directory path.
>
>> The 2 fixes below look good (as explained in the patch description),
>> but:
>> can you explain the 3 changes below that AFAICT do nothing?
>
I am so sorry that error like this lean in . I will fix that Randy..thank
you...
>I think we can jump to the conclusion that Bhaskar's editor cleanup up
>trailing white space.
>
>Bhaskar please make sure that the patch does not make unrelated white
>space changes.
>
>> > drivers/net/ethernet/i825xx/ether1.c | 10 +++++-----
>> > 1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
>> > index a0bfb509e002..0233fb6e222d 100644
>> > --- a/drivers/net/ethernet/i825xx/ether1.c
>> > +++ b/drivers/net/ethernet/i825xx/ether1.c
>> > @@ -885,7 +885,7 @@ ether1_recv_done (struct net_device *dev)
>> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_command, NORMALIRQS);
>> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_status, NORMALIRQS);
>> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_rbdoffset, NORMALIRQS);
>> > -
>> > +
>> > priv(dev)->rx_tail = nexttail;
>> > priv(dev)->rx_head = ether1_readw(dev, priv(dev)->rx_head, rfd_t, rfd_link, NORMALIRQS);
>> > } while (1);
>> > @@ -1031,7 +1031,7 @@ ether1_probe(struct expansion_card *ec, const struct ecard_id *id)
>> >
>> > printk(KERN_INFO "%s: ether1 in slot %d, %pM\n",
>> > dev->name, ec->slot_no, dev->dev_addr);
>> > -
>> > +
>> > ecard_set_drvdata(ec, dev);
>> > return 0;
>> >
>> > @@ -1047,7 +1047,7 @@ static void ether1_remove(struct expansion_card *ec)
>> > {
>> > struct net_device *dev = ecard_get_drvdata(ec);
>> >
>> > - ecard_set_drvdata(ec, NULL);
>> > + ecard_set_drvdata(ec, NULL);
>> >
>> > unregister_netdev(dev);
>> > free_netdev(dev);
>> > --
>> > 2.26.2
>> >
>>
>>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-03 23:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 15:15 [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c Bhaskar Chowdhury
2021-02-03 17:54 ` Randy Dunlap
2021-02-03 20:13 ` Jakub Kicinski
2021-02-03 23:51 ` Bhaskar Chowdhury
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).