From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-arch@vger.kernel.org, linux-sh@vger.kernel.org,
Alexey Klimov <aklimov@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, David Sterba <dsterba@suse.com>,
Dennis Zhou <dennis@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jianpeng Ma <jianpeng.ma@intel.com>,
Joe Perches <joe@perches.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Rich Felker <dalias@libc.org>,
Stefano Brivio <sbrivio@redhat.com>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH 08/14] lib/Kconfig: introduce FAST_PATH option
Date: Thu, 18 Feb 2021 17:15:43 +0200 [thread overview]
Message-ID: <YC6EnzFUXDuroy0+@smile.fi.intel.com> (raw)
In-Reply-To: <20210218040512.709186-9-yury.norov@gmail.com>
On Wed, Feb 17, 2021 at 08:05:06PM -0800, Yury Norov wrote:
> This series introduces fast paths for find_bit() routines. It is
> beneficial for typical systems, but those who limited in I-cache
> may be concerned about increasing the .text size of the Image.
>
> To address this concern, one can disable FAST_PATH option in the config
> and some save memory.
>
> The effect of this option on my arm64 next-20210217 build is:
(Maybe bloat-o-meter will give better view on this, i.e. more human-readable)
> Before:
> Sections:
> Idx Name Size VMA LMA File off Algn
> 0 .head.text 00010000 ffff800010000000 ffff800010000000 00010000 2**16
> CONTENTS, ALLOC, LOAD, READONLY, CODE
> 1 .text 0115e3a8 ffff800010010000 ffff800010010000 00020000 2**16
> CONTENTS, ALLOC, LOAD, READONLY, CODE
> 2 .got.plt 00000018 ffff80001116e3a8 ffff80001116e3a8 0117e3a8 2**3
> CONTENTS, ALLOC, LOAD, DATA
> 3 .rodata 007a72ca ffff800011170000 ffff800011170000 01180000 2**12
> CONTENTS, ALLOC, LOAD, DATA
> ...
>
> After:
> Sections:
> Idx Name Size VMA LMA File off Algn
> 0 .head.text 00010000 ffff800010000000 ffff800010000000 00010000 2**16
> CONTENTS, ALLOC, LOAD, READONLY, CODE
> 1 .text 011623a8 ffff800010010000 ffff800010010000 00020000 2**16
> CONTENTS, ALLOC, LOAD, READONLY, CODE
> 2 .got.plt 00000018 ffff8000111723a8 ffff8000111723a8 011823a8 2**3
> CONTENTS, ALLOC, LOAD, DATA
> 3 .rodata 007a772a ffff800011180000 ffff800011180000 01190000 2**12
> CONTENTS, ALLOC, LOAD, DATA
> ...
>
> Notice that this is the cumulive effect on already existing fast paths
> controlled by SMALL_CONST() together with ones added by this series.
...
> +config FAST_PATH
I think the name is to broad for this cases, perhaps BITS_FAST_PATH? or BITMAP?
> + bool "Enable fast path code generation"
> + default y
> + help
> + This option enables fast path optimization with the cost of increasing
> + the text section.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-18 18:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 4:04 [PATCH v3 00/14] lib/find_bit: fast path for small bitmaps Yury Norov
2021-02-18 4:04 ` [PATCH 01/14] tools: disable -Wno-type-limits Yury Norov
2021-02-18 4:05 ` [PATCH 02/14] tools: bitmap: sync function declarations with the kernel Yury Norov
2021-02-18 4:05 ` [PATCH 03/14] arch: rearrange headers inclusion order in asm/bitops for m68k and sh Yury Norov
2021-02-18 4:05 ` [PATCH 04/14] lib: introduce BITS_{FIRST,LAST} macro Yury Norov
2021-02-18 22:51 ` Rasmus Villemoes
2021-03-12 4:30 ` Yury Norov
2021-02-18 4:05 ` [PATCH 05/14] tools: sync BITS_MASK macros with the kernel Yury Norov
2021-02-18 4:05 ` [PATCH 06/14] bitsperlong.h: introduce SMALL_CONST() macro Yury Norov
2021-02-18 23:07 ` Rasmus Villemoes
2021-03-12 5:28 ` Yury Norov
2021-03-12 9:12 ` Rasmus Villemoes
2021-03-12 21:53 ` Yury Norov
2021-02-18 4:05 ` [PATCH 07/14] tools: " Yury Norov
2021-02-18 4:05 ` [PATCH 08/14] lib/Kconfig: introduce FAST_PATH option Yury Norov
2021-02-18 15:15 ` Andy Shevchenko [this message]
2021-02-18 19:24 ` Yury Norov
2021-02-19 10:52 ` Andy Shevchenko
2021-02-18 4:05 ` [PATCH 09/14] lib: inline _find_next_bit() wrappers Yury Norov
2021-02-18 4:05 ` [PATCH 10/14] tools: sync find_next_bit implementation Yury Norov
2021-02-18 4:05 ` [PATCH 11/14] lib: add fast path for find_next_*_bit() Yury Norov
2021-02-18 15:24 ` Andy Shevchenko
2021-02-18 4:05 ` [PATCH 12/14] lib: add fast path for find_first_*_bit() and find_last_bit() Yury Norov
2021-02-18 4:05 ` [PATCH 13/14] tools: sync lib/find_bit implementation Yury Norov
2021-02-18 4:05 ` [PATCH 14/14] MAINTAINERS: Add entry for the bitmap API Yury Norov
2021-02-18 15:28 ` Andy Shevchenko
2021-02-18 15:34 ` Yury Norov
2021-03-12 9:15 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC6EnzFUXDuroy0+@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aklimov@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=dennis@kernel.org \
--cc=dsterba@suse.com \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jianpeng.ma@intel.com \
--cc=joe@perches.com \
--cc=jpoimboe@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=richard.weiyang@linux.alibaba.com \
--cc=sbrivio@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=ysato@users.sourceforge.jp \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).