* [PATCH] staging: fwserial: match alignment with open parenthesis
@ 2021-02-18 19:43 Nikolay Kyx
2021-02-19 8:14 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Nikolay Kyx @ 2021-02-18 19:43 UTC (permalink / raw)
To: gregkh, adawesomeguy222, dinghao.liu; +Cc: Nikolay Kyx, devel, linux-kernel
fwserial.c:
fix CHECK: Alignment should match open parenthesis
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index c368082aae1a..137e97c9406c 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
if (state == -1) {
set_bit(STOP_TX, &port->flags);
ret = wait_event_interruptible_timeout(port->wait_tx,
- !test_bit(IN_TX, &port->flags),
- 10);
+ !test_bit(IN_TX, &port->flags),
+ 10);
if (ret == 0 || ret == -ERESTARTSYS) {
clear_bit(STOP_TX, &port->flags);
fwtty_restart_tx(port);
--
2.30.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: fwserial: match alignment with open parenthesis
2021-02-18 19:43 [PATCH] staging: fwserial: match alignment with open parenthesis Nikolay Kyx
@ 2021-02-19 8:14 ` Greg KH
2021-02-19 9:03 ` [PATCH v2] " Nikolay Kyx
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2021-02-19 8:14 UTC (permalink / raw)
To: Nikolay Kyx; +Cc: adawesomeguy222, dinghao.liu, devel, linux-kernel
On Thu, Feb 18, 2021 at 10:43:33PM +0300, Nikolay Kyx wrote:
> fwserial.c:
Why is this here?
> fix CHECK: Alignment should match open parenthesis
What does this mean?
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what is needed in order
to properly describe the change.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: fwserial: match alignment with open parenthesis
2021-02-19 8:14 ` Greg KH
@ 2021-02-19 9:03 ` Nikolay Kyx
2021-02-19 9:29 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Nikolay Kyx @ 2021-02-19 9:03 UTC (permalink / raw)
To: gregkh, adawesomeguy222, dinghao.liu; +Cc: Nikolay Kyx, devel, linux-kernel
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in file fwserial.c
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
v2: Edited changelog, as suggested by Greg KH <gregkh@linuxfoundation.org>
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index c368082aae1a..137e97c9406c 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
if (state == -1) {
set_bit(STOP_TX, &port->flags);
ret = wait_event_interruptible_timeout(port->wait_tx,
- !test_bit(IN_TX, &port->flags),
- 10);
+ !test_bit(IN_TX, &port->flags),
+ 10);
if (ret == 0 || ret == -ERESTARTSYS) {
clear_bit(STOP_TX, &port->flags);
fwtty_restart_tx(port);
--
2.30.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] staging: fwserial: match alignment with open parenthesis
2021-02-19 9:03 ` [PATCH v2] " Nikolay Kyx
@ 2021-02-19 9:29 ` Dan Carpenter
2021-02-19 15:49 ` [PATCH v3] " Nikolay Kyx
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2021-02-19 9:29 UTC (permalink / raw)
To: Nikolay Kyx; +Cc: gregkh, adawesomeguy222, dinghao.liu, devel, linux-kernel
On Fri, Feb 19, 2021 at 12:03:18PM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> in file fwserial.c
>
> Additionally some style warnings remain valid here and could be fixed by
> another patch.
>
Don't put comments like this in the git log, put them under the ---
cut off line.
> Signed-off-by: Nikolay Kyx <knv418@gmail.com>
> ---
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3] staging: fwserial: match alignment with open parenthesis
2021-02-19 9:29 ` Dan Carpenter
@ 2021-02-19 15:49 ` Nikolay Kyx
0 siblings, 0 replies; 5+ messages in thread
From: Nikolay Kyx @ 2021-02-19 15:49 UTC (permalink / raw)
To: gregkh, adawesomeguy222, dinghao.liu; +Cc: Nikolay Kyx, devel, linux-kernel
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in file fwserial.c
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH <gregkh@linuxfoundation.org>
v3: Moved comment about remaining warnings under the cut-off line,
as suggested by Dan Carpenter <dan.carpenter@oracle.com>
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index c368082aae1a..137e97c9406c 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
if (state == -1) {
set_bit(STOP_TX, &port->flags);
ret = wait_event_interruptible_timeout(port->wait_tx,
- !test_bit(IN_TX, &port->flags),
- 10);
+ !test_bit(IN_TX, &port->flags),
+ 10);
if (ret == 0 || ret == -ERESTARTSYS) {
clear_bit(STOP_TX, &port->flags);
fwtty_restart_tx(port);
--
2.30.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-19 15:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 19:43 [PATCH] staging: fwserial: match alignment with open parenthesis Nikolay Kyx
2021-02-19 8:14 ` Greg KH
2021-02-19 9:03 ` [PATCH v2] " Nikolay Kyx
2021-02-19 9:29 ` Dan Carpenter
2021-02-19 15:49 ` [PATCH v3] " Nikolay Kyx
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).