From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Ricardo Ribalda <ribalda@chromium.org>,
Tomasz Figa <tfiga@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2][next] media: uvcvideo: Remove duplicate assignments to pointer dma_dev
Date: Thu, 11 Feb 2021 01:42:07 +0200 [thread overview]
Message-ID: <YCRvTzUhnACWcNPT@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210210210149.GA842694@embeddedor>
Hi Gustavo,
Thank you for the patch.
On Wed, Feb 10, 2021 at 03:01:49PM -0600, Gustavo A. R. Silva wrote:
> Remove redundant assignments to pointer dma_dev.
>
> Fixes: fdcd02a641e2 ("media: uvcvideo: Use dma_alloc_noncontiguos API")
> Addresses-Coverity-ID: 1501703 ("Evaluation order violation")
> Addresses-Coverity-ID: 1501692 ("Evaluation order violation")
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Colin King has already submitted the same patch ("[PATCH][next][V2]
media: uvcvideo: remove duplicated dma_dev assignments"). As they're
identical, I can only decide to use the first patch that reached my
mailbox.
> ---
> Changes in v2:
> - Remove another redundant assignment in function
> uvc_free_urb_buffers().
>
> drivers/media/usb/uvc/uvc_video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> index dc81f9a86eca..6f2f308d86fe 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1105,7 +1105,7 @@ static inline struct device *stream_to_dmadev(struct uvc_streaming *stream)
>
> static void uvc_urb_dma_sync(struct uvc_urb *uvc_urb, bool for_device)
> {
> - struct device *dma_dev = dma_dev = stream_to_dmadev(uvc_urb->stream);
> + struct device *dma_dev = stream_to_dmadev(uvc_urb->stream);
>
> if (for_device) {
> dma_sync_sgtable_for_device(dma_dev, uvc_urb->sgt,
> @@ -1586,7 +1586,7 @@ static void uvc_video_complete(struct urb *urb)
> */
> static void uvc_free_urb_buffers(struct uvc_streaming *stream)
> {
> - struct device *dma_dev = dma_dev = stream_to_dmadev(stream);
> + struct device *dma_dev = stream_to_dmadev(stream);
> struct uvc_urb *uvc_urb;
>
> for_each_uvc_urb(uvc_urb, stream) {
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2021-02-10 23:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 21:01 [PATCH v2][next] media: uvcvideo: Remove duplicate assignments to pointer dma_dev Gustavo A. R. Silva
2021-02-10 23:42 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCRvTzUhnACWcNPT@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).