linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb: gadget: function: fix typo in f_printer.c
@ 2021-02-14 11:35 AristoChen
  2021-02-14 11:47 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: AristoChen @ 2021-02-14 11:35 UTC (permalink / raw)
  To: linux-kernel; +Cc: balbi, linux-usb, AristoChen

In line 824, it is trying to enable `out_ep`, so I
believe that in line 826, it should print `out_ep`
instead of `in_ep`.

Signed-off-by: AristoChen <jj251510319013@gmail.com>
---
 drivers/usb/gadget/function/f_printer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index 2f1eb2e81d30..a3b17ec00bf0 100644
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -823,7 +823,7 @@ set_printer_interface(struct printer_dev *dev)
 
 	result = usb_ep_enable(dev->out_ep);
 	if (result != 0) {
-		DBG(dev, "enable %s --> %d\n", dev->in_ep->name, result);
+		DBG(dev, "enable %s --> %d\n", dev->out_ep->name, result);
 		goto done;
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: gadget: function: fix typo in f_printer.c
  2021-02-14 11:35 [PATCH] usb: gadget: function: fix typo in f_printer.c AristoChen
@ 2021-02-14 11:47 ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-02-14 11:47 UTC (permalink / raw)
  To: AristoChen; +Cc: linux-kernel, balbi, linux-usb

On Sun, Feb 14, 2021 at 07:35:25PM +0800, AristoChen wrote:
> In line 824, it is trying to enable `out_ep`, so I
> believe that in line 826, it should print `out_ep`
> instead of `in_ep`.
> 
> Signed-off-by: AristoChen <jj251510319013@gmail.com>

Is this the name you use to sign legal documents?  If not, please resend
with your real name, as the documentation requires.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] usb: gadget: function: fix typo in f_printer.c
@ 2021-02-14 12:19 Wei Ming Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Ming Chen @ 2021-02-14 12:19 UTC (permalink / raw)
  To: linux-kernel; +Cc: balbi, linux-usb, Wei Ming Chen

In line 824, it is trying to enable `out_ep`, so I
believe that in line 826, it should print `out_ep`
instead of `in_ep`.

Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
---
 drivers/usb/gadget/function/f_printer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index 2f1eb2e81d30..a3b17ec00bf0 100644
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -823,7 +823,7 @@ set_printer_interface(struct printer_dev *dev)
 
 	result = usb_ep_enable(dev->out_ep);
 	if (result != 0) {
-		DBG(dev, "enable %s --> %d\n", dev->in_ep->name, result);
+		DBG(dev, "enable %s --> %d\n", dev->out_ep->name, result);
 		goto done;
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-14 12:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-14 11:35 [PATCH] usb: gadget: function: fix typo in f_printer.c AristoChen
2021-02-14 11:47 ` Greg KH
2021-02-14 12:19 Wei Ming Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).