* [PATCH] usb: dwc3: document usb_psy in struct dwc3
@ 2021-03-03 6:48 Ray Chi
2021-03-03 6:57 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ray Chi @ 2021-03-03 6:48 UTC (permalink / raw)
To: balbi, gregkh; +Cc: linux-usb, linux-kernel, kyletso, Ray Chi
The new struct member was added to struct dwc3, but
a documentation was missing:
drivers/usb/dwc3/core.h:1273: warning: Function parameter or member 'usb_psy' not described in 'dwc3'
Signed-off-by: Ray Chi <raychi@google.com>
---
drivers/usb/dwc3/core.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 6708fdf358b3..ce6bd84e2b39 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -988,6 +988,7 @@ struct dwc3_scratchpad_array {
* @role_sw: usb_role_switch handle
* @role_switch_default_mode: default operation mode of controller while
* usb role is USB_ROLE_NONE.
+ * @usb_psy: pointer to power supply interface.
* @usb2_phy: pointer to USB2 PHY
* @usb3_phy: pointer to USB3 PHY
* @usb2_generic_phy: pointer to USB2 PHY
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc3: document usb_psy in struct dwc3
2021-03-03 6:48 [PATCH] usb: dwc3: document usb_psy in struct dwc3 Ray Chi
@ 2021-03-03 6:57 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-03-03 6:57 UTC (permalink / raw)
To: Ray Chi; +Cc: balbi, linux-usb, linux-kernel, kyletso
On Wed, Mar 03, 2021 at 02:48:42PM +0800, Ray Chi wrote:
> The new struct member was added to struct dwc3, but
> a documentation was missing:
>
> drivers/usb/dwc3/core.h:1273: warning: Function parameter or member 'usb_psy' not described in 'dwc3'
>
> Signed-off-by: Ray Chi <raychi@google.com>
You forgot the "Reported-by:" line here.
Please fix up and resend a v2.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-03 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 6:48 [PATCH] usb: dwc3: document usb_psy in struct dwc3 Ray Chi
2021-03-03 6:57 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).