* [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO
@ 2021-02-19 23:14 Julian Braha
2021-02-20 7:02 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Julian Braha @ 2021-02-19 23:14 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, devel
commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0
Author: Julian Braha <julianbraha@gmail.com>
Date: Fri Feb 19 17:02:24 2021 -0500
staging: rtl8192e: fix kconfig dependency on CRYPTO
When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
Depends on [n]: CRYPTO [=n]
Selected by [m]:
- RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
Depends on [n]: CRYPTO [=n]
Selected by [m]:
- RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
- RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and CRYPTO_LIB_ARC4,
without depending on or selecting CRYPTO, despite those config options
being subordinate to CRYPTO.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig
index 03fcc23516fd..6e7d84ac06f5 100644
--- a/drivers/staging/rtl8192e/Kconfig
+++ b/drivers/staging/rtl8192e/Kconfig
@@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP
config RTLLIB_CRYPTO_TKIP
tristate "Support for rtllib TKIP crypto"
depends on RTLLIB
+ select CRYPTO
select CRYPTO_LIB_ARC4
select CRYPTO_MICHAEL_MIC
default y
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO
2021-02-19 23:14 [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO Julian Braha
@ 2021-02-20 7:02 ` Greg KH
2021-02-20 17:22 ` [PATCH v1] " Julian Braha
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2021-02-20 7:02 UTC (permalink / raw)
To: Julian Braha; +Cc: devel, linux-kernel
On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote:
> commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0
> Author: Julian Braha <julianbraha@gmail.com>
> Date: Fri Feb 19 17:02:24 2021 -0500
>
> staging: rtl8192e: fix kconfig dependency on CRYPTO
>
> When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
> Depends on [n]: CRYPTO [=n]
> Selected by [m]:
> - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
>
> WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
> Depends on [n]: CRYPTO [=n]
> Selected by [m]:
> - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
> - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
>
> This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and CRYPTO_LIB_ARC4,
> without depending on or selecting CRYPTO, despite those config options
> being subordinate to CRYPTO.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
>
> diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig
> index 03fcc23516fd..6e7d84ac06f5 100644
> --- a/drivers/staging/rtl8192e/Kconfig
> +++ b/drivers/staging/rtl8192e/Kconfig
> @@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP
> config RTLLIB_CRYPTO_TKIP
> tristate "Support for rtllib TKIP crypto"
> depends on RTLLIB
> + select CRYPTO
> select CRYPTO_LIB_ARC4
> select CRYPTO_MICHAEL_MIC
> default y
Odd indentation :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] Staging: rtl8192e: fix kconfig dependency on CRYPTO
2021-02-20 7:02 ` Greg KH
@ 2021-02-20 17:22 ` Julian Braha
2021-02-21 13:07 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Julian Braha @ 2021-02-20 17:22 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, devel
From fd949b204eeb6b685bbf5dc9a329c931fcf8b0da Mon Sep 17 00:00:00 2001
From: Julian Braha <julianbraha@gmail.com>
Date: Sat, 20 Feb 2021 12:07:30 -0500
Subject: [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO
When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
Depends on [n]: CRYPTO [=n]
Selected by [m]:
- RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
Depends on [n]: CRYPTO [=n]
Selected by [m]:
- RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
- RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and
CRYPTO_LIB_ARC4, without depending on or selecting CRYPTO,
despite those config options being subordinate to CRYPTO.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/staging/rtl8192e/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig
index 03fcc23516fd..6e7d84ac06f5 100644
--- a/drivers/staging/rtl8192e/Kconfig
+++ b/drivers/staging/rtl8192e/Kconfig
@@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP
config RTLLIB_CRYPTO_TKIP
tristate "Support for rtllib TKIP crypto"
depends on RTLLIB
+ select CRYPTO
select CRYPTO_LIB_ARC4
select CRYPTO_MICHAEL_MIC
default y
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1] Staging: rtl8192e: fix kconfig dependency on CRYPTO
2021-02-20 17:22 ` [PATCH v1] " Julian Braha
@ 2021-02-21 13:07 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-02-21 13:07 UTC (permalink / raw)
To: Julian Braha; +Cc: devel, linux-kernel
On Sat, Feb 20, 2021 at 12:22:43PM -0500, Julian Braha wrote:
> >From fd949b204eeb6b685bbf5dc9a329c931fcf8b0da Mon Sep 17 00:00:00 2001
> From: Julian Braha <julianbraha@gmail.com>
> Date: Sat, 20 Feb 2021 12:07:30 -0500
> Subject: [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO
Why is this all in the body of the email? Please just use 'git
send-email' to send the patch out, do not attach it all to the message
like this :(
>
> When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
> Depends on [n]: CRYPTO [=n]
> Selected by [m]:
> - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
>
> WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
> Depends on [n]: CRYPTO [=n]
> Selected by [m]:
> - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
> - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
>
> This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and
> CRYPTO_LIB_ARC4, without depending on or selecting CRYPTO,
> despite those config options being subordinate to CRYPTO.
trailing whitespace in your commit log :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO
@ 2021-02-22 18:06 Julian Braha
2021-02-22 21:13 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Julian Braha @ 2021-02-22 18:06 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, devel
When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
Depends on [n]: CRYPTO [=n]
Selected by [m]:
- RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
Depends on [n]: CRYPTO [=n]
Selected by [m]:
- RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
- RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and
CRYPTO_LIB_ARC4, without depending on or selecting CRYPTO,
despite those config options being subordinate to CRYPTO.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/staging/rtl8192e/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig
index 03fcc23516fd..6e7d84ac06f5 100644
--- a/drivers/staging/rtl8192e/Kconfig
+++ b/drivers/staging/rtl8192e/Kconfig
@@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP
config RTLLIB_CRYPTO_TKIP
tristate "Support for rtllib TKIP crypto"
depends on RTLLIB
+ select CRYPTO
select CRYPTO_LIB_ARC4
select CRYPTO_MICHAEL_MIC
default y
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO
2021-02-22 18:06 [PATCH] staging: " Julian Braha
@ 2021-02-22 21:13 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-02-22 21:13 UTC (permalink / raw)
To: Julian Braha, gregkh; +Cc: linux-kernel, devel
On 2/22/21 10:06 AM, Julian Braha wrote:
> When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
> Depends on [n]: CRYPTO [=n]
> Selected by [m]:
> - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
>
> WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
> Depends on [n]: CRYPTO [=n]
> Selected by [m]:
> - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
> - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
>
> This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and
> CRYPTO_LIB_ARC4, without depending on or selecting CRYPTO,
> despite those config options being subordinate to CRYPTO.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/staging/rtl8192e/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig
> index 03fcc23516fd..6e7d84ac06f5 100644
> --- a/drivers/staging/rtl8192e/Kconfig
> +++ b/drivers/staging/rtl8192e/Kconfig
> @@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP
> config RTLLIB_CRYPTO_TKIP
> tristate "Support for rtllib TKIP crypto"
> depends on RTLLIB
> + select CRYPTO
> select CRYPTO_LIB_ARC4
> select CRYPTO_MICHAEL_MIC
> default y
>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-22 21:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 23:14 [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO Julian Braha
2021-02-20 7:02 ` Greg KH
2021-02-20 17:22 ` [PATCH v1] " Julian Braha
2021-02-21 13:07 ` Greg KH
2021-02-22 18:06 [PATCH] staging: " Julian Braha
2021-02-22 21:13 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).