* [PATCH] phy: marvell: ARMADA375_USBCLUSTER_PHY should not default to y, unconditionally
@ 2021-02-08 15:02 Geert Uytterhoeven
2021-03-15 9:59 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-02-08 15:02 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Gregory CLEMENT, Thomas Petazzoni
Cc: linux-kernel, Geert Uytterhoeven
Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, restrict the automatic enabling of ARMADA375_USBCLUSTER_PHY
to MACH_ARMADA_375, and ask the user in case of compile-testing.
Fixes: eee47538ec1f2619 ("phy: add support for USB cluster on the Armada 375 SoC")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/phy/marvell/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/marvell/Kconfig b/drivers/phy/marvell/Kconfig
index 6c96f2bf52665789..c8ee23fc3a83d360 100644
--- a/drivers/phy/marvell/Kconfig
+++ b/drivers/phy/marvell/Kconfig
@@ -3,8 +3,8 @@
# Phy drivers for Marvell platforms
#
config ARMADA375_USBCLUSTER_PHY
- def_bool y
- depends on MACH_ARMADA_375 || COMPILE_TEST
+ bool "Armada 375 USB cluster PHY support" if COMPILE_TEST
+ default y if MACH_ARMADA_375
depends on OF && HAS_IOMEM
select GENERIC_PHY
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: marvell: ARMADA375_USBCLUSTER_PHY should not default to y, unconditionally
2021-02-08 15:02 [PATCH] phy: marvell: ARMADA375_USBCLUSTER_PHY should not default to y, unconditionally Geert Uytterhoeven
@ 2021-03-15 9:59 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-03-15 9:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Kishon Vijay Abraham I, Gregory CLEMENT, Thomas Petazzoni, linux-kernel
On 08-02-21, 16:02, Geert Uytterhoeven wrote:
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, restrict the automatic enabling of ARMADA375_USBCLUSTER_PHY
> to MACH_ARMADA_375, and ask the user in case of compile-testing.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-15 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 15:02 [PATCH] phy: marvell: ARMADA375_USBCLUSTER_PHY should not default to y, unconditionally Geert Uytterhoeven
2021-03-15 9:59 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).