linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: pm8150: Enable RTC
@ 2021-01-06  0:10 Bjorn Andersson
  2021-03-12 18:16 ` Dmitry Baryshkov
  2021-03-13 10:15 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-01-06  0:10 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Herring
  Cc: linux-arm-msm, devicetree, linux-kernel, dmitry.baryshkov

The PM8150 comes with everything the RTC needs, so let's just leave it
enabled instead of having to explicitly enable it for all boards.
In effect this patch enables the RTC on the SM8150 MTP and the SM8250
HDK.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm8150.dtsi     | 4 +---
 arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 4 ----
 arch/arm64/boot/dts/qcom/sm8250-mtp.dts  | 4 ----
 3 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi b/arch/arm64/boot/dts/qcom/pm8150.dtsi
index a53eccf2b695..027f55d53584 100644
--- a/arch/arm64/boot/dts/qcom/pm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
@@ -97,13 +97,11 @@ die-temp@6 {
 			};
 		};
 
-		pm8150_rtc: rtc@6000 {
+		rtc@6000 {
 			compatible = "qcom,pm8941-rtc";
 			reg = <0x6000>;
 			reg-names = "rtc", "alarm";
 			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
-
-			status = "disabled";
 		};
 
 		pm8150_gpios: gpio@c000 {
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index d7799a6fb489..546b7fb9cf55 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -609,10 +609,6 @@ lt9611_rst_pin: lt9611-rst-pin {
 	};
 };
 
-&pm8150_rtc {
-	status = "okay";
-};
-
 &qupv3_id_0 {
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
index 767a2e446248..c291422fa096 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
@@ -392,10 +392,6 @@ &i2c15 {
 	/* rtc6226 @ 64 */
 };
 
-&pm8150_rtc {
-	status = "okay";
-};
-
 &qupv3_id_0 {
 	status = "okay";
 };
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: pm8150: Enable RTC
  2021-01-06  0:10 [PATCH] arm64: dts: qcom: pm8150: Enable RTC Bjorn Andersson
@ 2021-03-12 18:16 ` Dmitry Baryshkov
  2021-03-13 10:15 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2021-03-12 18:16 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Andy Gross, Rob Herring, open list:DRM DRIVER FOR MSM ADRENO GPU,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list

On Wed, 6 Jan 2021 at 03:09, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> The PM8150 comes with everything the RTC needs, so let's just leave it
> enabled instead of having to explicitly enable it for all boards.
> In effect this patch enables the RTC on the SM8150 MTP and the SM8250
> HDK.

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/pm8150.dtsi     | 4 +---
>  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 4 ----
>  arch/arm64/boot/dts/qcom/sm8250-mtp.dts  | 4 ----
>  3 files changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> index a53eccf2b695..027f55d53584 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> @@ -97,13 +97,11 @@ die-temp@6 {
>                         };
>                 };
>
> -               pm8150_rtc: rtc@6000 {
> +               rtc@6000 {
>                         compatible = "qcom,pm8941-rtc";
>                         reg = <0x6000>;
>                         reg-names = "rtc", "alarm";
>                         interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
> -
> -                       status = "disabled";
>                 };
>
>                 pm8150_gpios: gpio@c000 {
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index d7799a6fb489..546b7fb9cf55 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -609,10 +609,6 @@ lt9611_rst_pin: lt9611-rst-pin {
>         };
>  };
>
> -&pm8150_rtc {
> -       status = "okay";
> -};
> -
>  &qupv3_id_0 {
>         status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> index 767a2e446248..c291422fa096 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
> @@ -392,10 +392,6 @@ &i2c15 {
>         /* rtc6226 @ 64 */
>  };
>
> -&pm8150_rtc {
> -       status = "okay";
> -};
> -
>  &qupv3_id_0 {
>         status = "okay";
>  };
> --
> 2.29.2
>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: pm8150: Enable RTC
  2021-01-06  0:10 [PATCH] arm64: dts: qcom: pm8150: Enable RTC Bjorn Andersson
  2021-03-12 18:16 ` Dmitry Baryshkov
@ 2021-03-13 10:15 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-03-13 10:15 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree, linux-kernel,
	dmitry.baryshkov

On 05-01-21, 16:10, Bjorn Andersson wrote:
> The PM8150 comes with everything the RTC needs, so let's just leave it
> enabled instead of having to explicitly enable it for all boards.
> In effect this patch enables the RTC on the SM8150 MTP and the SM8250
> HDK.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-13 10:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06  0:10 [PATCH] arm64: dts: qcom: pm8150: Enable RTC Bjorn Andersson
2021-03-12 18:16 ` Dmitry Baryshkov
2021-03-13 10:15 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).