From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c
Date: Thu, 18 Mar 2021 00:59:54 +0530 [thread overview]
Message-ID: <YFJYshIZjo+Xcgo5@ArchLinux> (raw)
In-Reply-To: <99a7e1fc-0a05-9222-f913-b2d85141a08a@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]
On 11:01 Wed 17 Mar 2021, Randy Dunlap wrote:
>On 3/17/21 10:54 AM, Reinette Chatre wrote:
>> Hi Bhaskar,
>>
>> Thank you very much for catching this typo.
>>
>> My feedback [1] to a previous patch from you applies here also. The prefix should be "x86/resctrl:" for contributions to this area.
>
>Bhaskar,
>Pretty much all of your patches need to have improved Subject: lines.
>The file name that is being modified should not be at the end of the Subject.
>
Noted, ...I was trying to feed the owner of the file as much as possible , so
the person can struggle less to understand and hover,considering the load they
might have on their shoulder.
>>
>> [1] https://lore.kernel.org/lkml/7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com/
>>
>> On 3/17/2021 1:40 AM, Bhaskar Chowdhury wrote:
>>>
>>> s/derefence/dereference/
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>> arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>>> index e916646adc69..43990a882b36 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>>> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>>> @@ -1307,7 +1307,7 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
>>> * If the thread does not get on the CPU for whatever
>>> * reason and the process which sets up the region is
>>> * interrupted then this will leave the thread in runnable
>>> - * state and once it gets on the CPU it will derefence
>>> + * state and once it gets on the CPU it will dereference
>>> * the cleared, but not freed, plr struct resulting in an
>>> * empty pseudo-locking loop.
>>> */
>>> --
>>> 2.30.2
>>>
>>
>> Reinette
>
>
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-17 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 8:40 [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c Bhaskar Chowdhury
2021-03-17 17:54 ` Reinette Chatre
2021-03-17 18:01 ` Randy Dunlap
2021-03-17 19:29 ` Bhaskar Chowdhury [this message]
2021-03-17 19:33 ` Bhaskar Chowdhury
2021-03-17 20:31 ` Reinette Chatre
2021-03-17 22:21 ` Bhaskar Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFJYshIZjo+Xcgo5@ArchLinux \
--to=unixbhaskar@gmail.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).