* [PATCH] drm/radeon/r600_cs: Couple of typo fixes
@ 2021-03-24 13:50 Bhaskar Chowdhury
2021-03-24 21:48 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-24 13:50 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, amd-gfx,
dri-devel, linux-kernel
Cc: rdunlap, Bhaskar Chowdhury
s/miror/mirror/
s/needind/needing/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
drivers/gpu/drm/radeon/r600_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
index 34b7c6f16479..aded1f2264e0 100644
--- a/drivers/gpu/drm/radeon/r600_cs.c
+++ b/drivers/gpu/drm/radeon/r600_cs.c
@@ -38,7 +38,7 @@ extern void r600_cs_legacy_get_tiling_conf(struct drm_device *dev, u32 *npipes,
struct r600_cs_track {
- /* configuration we miror so that we use same code btw kms/ums */
+ /* configuration we mirror so that we use same code btw kms/ums */
u32 group_size;
u32 nbanks;
u32 npipes;
@@ -963,7 +963,7 @@ static int r600_cs_parse_packet0(struct radeon_cs_parser *p,
*
* This function will test against r600_reg_safe_bm and return 0
* if register is safe. If register is not flag as safe this function
- * will test it against a list of register needind special handling.
+ * will test it against a list of register needing special handling.
*/
static int r600_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
{
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/radeon/r600_cs: Couple of typo fixes
2021-03-24 13:50 [PATCH] drm/radeon/r600_cs: Couple of typo fixes Bhaskar Chowdhury
@ 2021-03-24 21:48 ` Randy Dunlap
2021-03-24 23:30 ` Bhaskar Chowdhury
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-03-24 21:48 UTC (permalink / raw)
To: Bhaskar Chowdhury, alexander.deucher, christian.koenig, airlied,
daniel, amd-gfx, dri-devel, linux-kernel
On 3/24/21 6:50 AM, Bhaskar Chowdhury wrote:
>
> s/miror/mirror/
> s/needind/needing/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> drivers/gpu/drm/radeon/r600_cs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
> index 34b7c6f16479..aded1f2264e0 100644
> --- a/drivers/gpu/drm/radeon/r600_cs.c
> +++ b/drivers/gpu/drm/radeon/r600_cs.c
> @@ -38,7 +38,7 @@ extern void r600_cs_legacy_get_tiling_conf(struct drm_device *dev, u32 *npipes,
>
>
> struct r600_cs_track {
> - /* configuration we miror so that we use same code btw kms/ums */
> + /* configuration we mirror so that we use same code btw kms/ums */
> u32 group_size;
> u32 nbanks;
> u32 npipes;
> @@ -963,7 +963,7 @@ static int r600_cs_parse_packet0(struct radeon_cs_parser *p,
> *
> * This function will test against r600_reg_safe_bm and return 0
> * if register is safe. If register is not flag as safe this function
> - * will test it against a list of register needind special handling.
> + * will test it against a list of register needing special handling.
> */
> static int r600_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
> {
> --
Those 2 LGTM, but please fix this while you are touching this file:
drivers/gpu/drm/radeon/r600_cs.c:2339: informations ==> information
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/radeon/r600_cs: Couple of typo fixes
2021-03-24 21:48 ` Randy Dunlap
@ 2021-03-24 23:30 ` Bhaskar Chowdhury
0 siblings, 0 replies; 3+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-24 23:30 UTC (permalink / raw)
To: Randy Dunlap
Cc: alexander.deucher, christian.koenig, airlied, daniel, amd-gfx,
dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]
On 14:48 Wed 24 Mar 2021, Randy Dunlap wrote:
>On 3/24/21 6:50 AM, Bhaskar Chowdhury wrote:
>>
>> s/miror/mirror/
>> s/needind/needing/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> drivers/gpu/drm/radeon/r600_cs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
>> index 34b7c6f16479..aded1f2264e0 100644
>> --- a/drivers/gpu/drm/radeon/r600_cs.c
>> +++ b/drivers/gpu/drm/radeon/r600_cs.c
>> @@ -38,7 +38,7 @@ extern void r600_cs_legacy_get_tiling_conf(struct drm_device *dev, u32 *npipes,
>>
>>
>> struct r600_cs_track {
>> - /* configuration we miror so that we use same code btw kms/ums */
>> + /* configuration we mirror so that we use same code btw kms/ums */
>> u32 group_size;
>> u32 nbanks;
>> u32 npipes;
>> @@ -963,7 +963,7 @@ static int r600_cs_parse_packet0(struct radeon_cs_parser *p,
>> *
>> * This function will test against r600_reg_safe_bm and return 0
>> * if register is safe. If register is not flag as safe this function
>> - * will test it against a list of register needind special handling.
>> + * will test it against a list of register needing special handling.
>> */
>> static int r600_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
>> {
>> --
>
>Those 2 LGTM, but please fix this while you are touching this file:
>
>drivers/gpu/drm/radeon/r600_cs.c:2339: informations ==> information
>
Thanks, I have sent a V2 with the change...
>
>thanks.
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-24 23:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 13:50 [PATCH] drm/radeon/r600_cs: Couple of typo fixes Bhaskar Chowdhury
2021-03-24 21:48 ` Randy Dunlap
2021-03-24 23:30 ` Bhaskar Chowdhury
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).