* [PATCH] include: linux: debug_locks: Remove duplicate declaration
@ 2021-03-25 2:26 Wan Jiabing
2021-03-25 13:22 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-03-25 2:26 UTC (permalink / raw)
To: Thomas Gleixner, Sergey Senozhatsky, Petr Mladek, Peter Zijlstra,
Andy Shevchenko, Wan Jiabing, linux-kernel
Cc: kael_w
struct task_struct is declared at 9th line. Remove the duplicate.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
include/linux/debug_locks.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
index 2915f56ad421..0b3187a5290d 100644
--- a/include/linux/debug_locks.h
+++ b/include/linux/debug_locks.h
@@ -46,7 +46,6 @@ extern int debug_locks_off(void);
# define locking_selftest() do { } while (0)
#endif
-struct task_struct;
#ifdef CONFIG_LOCKDEP
extern void debug_show_all_locks(void);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration
2021-03-25 2:26 [PATCH] include: linux: debug_locks: Remove duplicate declaration Wan Jiabing
@ 2021-03-25 13:22 ` Andy Shevchenko
2021-03-25 13:23 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-03-25 13:22 UTC (permalink / raw)
To: Wan Jiabing
Cc: Thomas Gleixner, Sergey Senozhatsky, Petr Mladek, Peter Zijlstra,
linux-kernel, kael_w
On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote:
> struct task_struct is declared at 9th line. Remove the duplicate.
It seems the duplicate is the other one and you removed wrong one.
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> include/linux/debug_locks.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 2915f56ad421..0b3187a5290d 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -46,7 +46,6 @@ extern int debug_locks_off(void);
> # define locking_selftest() do { } while (0)
> #endif
>
> -struct task_struct;
>
> #ifdef CONFIG_LOCKDEP
> extern void debug_show_all_locks(void);
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration
2021-03-25 13:22 ` Andy Shevchenko
@ 2021-03-25 13:23 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-03-25 13:23 UTC (permalink / raw)
To: Wan Jiabing
Cc: Thomas Gleixner, Sergey Senozhatsky, Petr Mladek, Peter Zijlstra,
linux-kernel, kael_w
On Thu, Mar 25, 2021 at 03:22:22PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote:
> > struct task_struct is declared at 9th line. Remove the duplicate.
>
> It seems the duplicate is the other one and you removed wrong one.
Okay, they are on the same level of ifdeffery, technically there is no
difference. Practically the other one closer to its user.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-25 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 2:26 [PATCH] include: linux: debug_locks: Remove duplicate declaration Wan Jiabing
2021-03-25 13:22 ` Andy Shevchenko
2021-03-25 13:23 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).