* [PATCH] [v2] include: linux: debug_locks: Remove duplicate declaration
@ 2021-03-25 15:20 Wan Jiabing
2021-03-25 15:45 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-03-25 15:20 UTC (permalink / raw)
To: Thomas Gleixner, Wan Jiabing, Andy Shevchenko, Peter Zijlstra,
Sergey Senozhatsky, linux-kernel
Cc: keal_w
struct task_struct has been declared.
Remove the duplicate.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Changelog:
v2:
- Remove another duplicate declaration for being closer
to its user.
---
include/linux/debug_locks.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
index 2915f56ad421..32f6a37a3d3f 100644
--- a/include/linux/debug_locks.h
+++ b/include/linux/debug_locks.h
@@ -6,8 +6,6 @@
#include <linux/bug.h>
#include <linux/printk.h>
-struct task_struct;
-
extern int debug_locks __read_mostly;
extern int debug_locks_silent __read_mostly;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [v2] include: linux: debug_locks: Remove duplicate declaration
2021-03-25 15:20 [PATCH] [v2] include: linux: debug_locks: Remove duplicate declaration Wan Jiabing
@ 2021-03-25 15:45 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-03-25 15:45 UTC (permalink / raw)
To: Wan Jiabing
Cc: Thomas Gleixner, Peter Zijlstra, Sergey Senozhatsky,
linux-kernel, keal_w
On Thu, Mar 25, 2021 at 11:20:28PM +0800, Wan Jiabing wrote:
> struct task_struct has been declared.
"...declared twice."
In the subject line the "include: linux: " part is not needed.
FWIW, after addressing above,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> Changelog:
> v2:
> - Remove another duplicate declaration for being closer
> to its user.
> ---
> include/linux/debug_locks.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 2915f56ad421..32f6a37a3d3f 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -6,8 +6,6 @@
> #include <linux/bug.h>
> #include <linux/printk.h>
>
> -struct task_struct;
> -
> extern int debug_locks __read_mostly;
> extern int debug_locks_silent __read_mostly;
>
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 15:20 [PATCH] [v2] include: linux: debug_locks: Remove duplicate declaration Wan Jiabing
2021-03-25 15:45 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).