linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h
@ 2021-04-07  7:57 Mitali Borkar
  2021-04-07  8:05 ` Greg KH
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mitali Borkar @ 2021-04-07  7:57 UTC (permalink / raw)
  To: Larry.Finger, florian.c.schilhabel, gregkh
  Cc: linux-staging, linux-kernel, outreachy-kernel, mitali_s

Fixed Check:Avoid CamelCase by renaming SetFilter to set_filter
Reported by checkpatch.

Signed-off-by: Mitali Borkar <mitaliborkar810@example.com>
---
 drivers/staging/rtl8712/xmit_osdep.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/xmit_osdep.h b/drivers/staging/rtl8712/xmit_osdep.h
index b76021b568f8..7ad2ac6f5ff0 100644
--- a/drivers/staging/rtl8712/xmit_osdep.h
+++ b/drivers/staging/rtl8712/xmit_osdep.h
@@ -35,7 +35,7 @@ struct xmit_frame;
 struct xmit_buf;
 
 int r8712_xmit_entry(_pkt *pkt, struct  net_device *pnetdev);
-void r8712_SetFilter(struct work_struct *work);
+void r8712_set_filter(struct work_struct *work);
 int r8712_xmit_resource_alloc(struct _adapter *padapter,
 			      struct xmit_buf *pxmitbuf);
 void r8712_xmit_resource_free(struct _adapter *padapter,
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h
  2021-04-07  7:57 [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h Mitali Borkar
@ 2021-04-07  8:05 ` Greg KH
  2021-04-07 10:45 ` kernel test robot
  2021-04-07 16:21 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-04-07  8:05 UTC (permalink / raw)
  To: Mitali Borkar
  Cc: Larry.Finger, florian.c.schilhabel, linux-staging, linux-kernel,
	outreachy-kernel, mitali_s

On Wed, Apr 07, 2021 at 01:27:29PM +0530, Mitali Borkar wrote:
> Fixed Check:Avoid CamelCase by renaming SetFilter to set_filter
> Reported by checkpatch.
> 
> Signed-off-by: Mitali Borkar <mitaliborkar810@example.com>
> ---
>  drivers/staging/rtl8712/xmit_osdep.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/xmit_osdep.h b/drivers/staging/rtl8712/xmit_osdep.h
> index b76021b568f8..7ad2ac6f5ff0 100644
> --- a/drivers/staging/rtl8712/xmit_osdep.h
> +++ b/drivers/staging/rtl8712/xmit_osdep.h
> @@ -35,7 +35,7 @@ struct xmit_frame;
>  struct xmit_buf;
>  
>  int r8712_xmit_entry(_pkt *pkt, struct  net_device *pnetdev);
> -void r8712_SetFilter(struct work_struct *work);
> +void r8712_set_filter(struct work_struct *work);
>  int r8712_xmit_resource_alloc(struct _adapter *padapter,
>  			      struct xmit_buf *pxmitbuf);
>  void r8712_xmit_resource_free(struct _adapter *padapter,
> -- 
> 2.30.2
> 
> 

Did you try test-building your change?  Always do so :(



^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h
  2021-04-07  7:57 [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h Mitali Borkar
  2021-04-07  8:05 ` Greg KH
@ 2021-04-07 10:45 ` kernel test robot
  2021-04-07 16:21 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-04-07 10:45 UTC (permalink / raw)
  To: Mitali Borkar, Larry.Finger, florian.c.schilhabel, gregkh
  Cc: kbuild-all, linux-staging, linux-kernel, outreachy-kernel, mitali_s

[-- Attachment #1: Type: text/plain, Size: 3060 bytes --]

Hi Mitali,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git e91cafdf3c18b927e61eb4ee18e4865b8485f24f
config: i386-randconfig-a014-20210407 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/9f510deed38aa66173f9ffc8f21c7d61d96f583f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925
        git checkout 9f510deed38aa66173f9ffc8f21c7d61d96f583f
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/rtl8712/xmit_linux.c:94:6: warning: no previous prototype for 'r8712_SetFilter' [-Wmissing-prototypes]
      94 | void r8712_SetFilter(struct work_struct *work)
         |      ^~~~~~~~~~~~~~~


vim +/r8712_SetFilter +94 drivers/staging/rtl8712/xmit_linux.c

2865d42c78a912 Larry Finger    2010-08-20   93  
f95302eed91061 Ali Bahar       2011-09-04  @94  void r8712_SetFilter(struct work_struct *work)
f95302eed91061 Ali Bahar       2011-09-04   95  {
3f35d9022761e4 Nishka Dasgupta 2019-06-07   96  	struct _adapter *adapter = container_of(work, struct _adapter,
8810493fc54e75 Deepak Mishra   2019-06-12   97  						wk_filter_rx_ff0);
f95302eed91061 Ali Bahar       2011-09-04   98  	u8  oldvalue = 0x00, newvalue = 0x00;
f95302eed91061 Ali Bahar       2011-09-04   99  	unsigned long irqL;
f95302eed91061 Ali Bahar       2011-09-04  100  
3f35d9022761e4 Nishka Dasgupta 2019-06-07  101  	oldvalue = r8712_read8(adapter, 0x117);
f95302eed91061 Ali Bahar       2011-09-04  102  	newvalue = oldvalue & 0xfe;
3f35d9022761e4 Nishka Dasgupta 2019-06-07  103  	r8712_write8(adapter, 0x117, newvalue);
f95302eed91061 Ali Bahar       2011-09-04  104  
6cc6677aee4346 Deepak Mishra   2019-06-12  105  	spin_lock_irqsave(&adapter->lock_rx_ff0_filter, irqL);
3f35d9022761e4 Nishka Dasgupta 2019-06-07  106  	adapter->blnEnableRxFF0Filter = 1;
6cc6677aee4346 Deepak Mishra   2019-06-12  107  	spin_unlock_irqrestore(&adapter->lock_rx_ff0_filter, irqL);
f95302eed91061 Ali Bahar       2011-09-04  108  	do {
f95302eed91061 Ali Bahar       2011-09-04  109  		msleep(100);
3f35d9022761e4 Nishka Dasgupta 2019-06-07  110  	} while (adapter->blnEnableRxFF0Filter == 1);
3f35d9022761e4 Nishka Dasgupta 2019-06-07  111  	r8712_write8(adapter, 0x117, oldvalue);
f95302eed91061 Ali Bahar       2011-09-04  112  }
f95302eed91061 Ali Bahar       2011-09-04  113  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42103 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h
  2021-04-07  7:57 [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h Mitali Borkar
  2021-04-07  8:05 ` Greg KH
  2021-04-07 10:45 ` kernel test robot
@ 2021-04-07 16:21 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-04-07 16:21 UTC (permalink / raw)
  To: Mitali Borkar, Larry.Finger, florian.c.schilhabel, gregkh
  Cc: kbuild-all, linux-staging, linux-kernel, outreachy-kernel, mitali_s

[-- Attachment #1: Type: text/plain, Size: 14136 bytes --]

Hi Mitali,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git e91cafdf3c18b927e61eb4ee18e4865b8485f24f
config: i386-randconfig-a014-20210407 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/9f510deed38aa66173f9ffc8f21c7d61d96f583f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925
        git checkout 9f510deed38aa66173f9ffc8f21c7d61d96f583f
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/interrupt.h:15,
                    from drivers/staging/rtl8712/osdep_service.h:22,
                    from drivers/staging/rtl8712/rtl871x_xmit.c:19:
   drivers/staging/rtl8712/rtl871x_xmit.c: In function '_r8712_init_xmit_priv':
>> drivers/staging/rtl8712/rtl871x_xmit.c:144:41: error: 'r8712_SetFilter' undeclared (first use in this function); did you mean 'r8712_set_filter'?
     144 |  INIT_WORK(&padapter->wk_filter_rx_ff0, r8712_SetFilter);
         |                                         ^~~~~~~~~~~~~~~
   include/linux/workqueue.h:237:20: note: in definition of macro '__INIT_WORK'
     237 |   (_work)->func = (_func);    \
         |                    ^~~~~
   drivers/staging/rtl8712/rtl871x_xmit.c:144:2: note: in expansion of macro 'INIT_WORK'
     144 |  INIT_WORK(&padapter->wk_filter_rx_ff0, r8712_SetFilter);
         |  ^~~~~~~~~
   drivers/staging/rtl8712/rtl871x_xmit.c:144:41: note: each undeclared identifier is reported only once for each function it appears in
     144 |  INIT_WORK(&padapter->wk_filter_rx_ff0, r8712_SetFilter);
         |                                         ^~~~~~~~~~~~~~~
   include/linux/workqueue.h:237:20: note: in definition of macro '__INIT_WORK'
     237 |   (_work)->func = (_func);    \
         |                    ^~~~~
   drivers/staging/rtl8712/rtl871x_xmit.c:144:2: note: in expansion of macro 'INIT_WORK'
     144 |  INIT_WORK(&padapter->wk_filter_rx_ff0, r8712_SetFilter);
         |  ^~~~~~~~~


vim +144 drivers/staging/rtl8712/rtl871x_xmit.c

2865d42c78a912 Larry Finger        2010-08-20   18  
2865d42c78a912 Larry Finger        2010-08-20  @19  #include "osdep_service.h"
2865d42c78a912 Larry Finger        2010-08-20   20  #include "drv_types.h"
2865d42c78a912 Larry Finger        2010-08-20   21  #include "wifi.h"
2865d42c78a912 Larry Finger        2010-08-20   22  #include "osdep_intf.h"
2865d42c78a912 Larry Finger        2010-08-20   23  #include "usb_ops.h"
2865d42c78a912 Larry Finger        2010-08-20   24  
2865d42c78a912 Larry Finger        2010-08-20   25  
2865d42c78a912 Larry Finger        2010-08-20   26  static const u8 P802_1H_OUI[P80211_OUI_LEN] = {0x00, 0x00, 0xf8};
2865d42c78a912 Larry Finger        2010-08-20   27  static const u8 RFC1042_OUI[P80211_OUI_LEN] = {0x00, 0x00, 0x00};
2865d42c78a912 Larry Finger        2010-08-20   28  static void init_hwxmits(struct hw_xmit *phwxmit, sint entry);
2865d42c78a912 Larry Finger        2010-08-20   29  static void alloc_hwxmits(struct _adapter *padapter);
2865d42c78a912 Larry Finger        2010-08-20   30  static void free_hwxmits(struct _adapter *padapter);
2865d42c78a912 Larry Finger        2010-08-20   31  
2865d42c78a912 Larry Finger        2010-08-20   32  static void _init_txservq(struct tx_servq *ptxservq)
2865d42c78a912 Larry Finger        2010-08-20   33  {
534c4acd1d4594 James A Shackleford 2014-06-24   34  	INIT_LIST_HEAD(&ptxservq->tx_pending);
2865d42c78a912 Larry Finger        2010-08-20   35  	_init_queue(&ptxservq->sta_pending);
2865d42c78a912 Larry Finger        2010-08-20   36  	ptxservq->qcnt = 0;
2865d42c78a912 Larry Finger        2010-08-20   37  }
2865d42c78a912 Larry Finger        2010-08-20   38  
2865d42c78a912 Larry Finger        2010-08-20   39  void _r8712_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv)
2865d42c78a912 Larry Finger        2010-08-20   40  {
2865d42c78a912 Larry Finger        2010-08-20   41  	memset((unsigned char *)psta_xmitpriv, 0,
2865d42c78a912 Larry Finger        2010-08-20   42  		 sizeof(struct sta_xmit_priv));
2865d42c78a912 Larry Finger        2010-08-20   43  	spin_lock_init(&psta_xmitpriv->lock);
2865d42c78a912 Larry Finger        2010-08-20   44  	_init_txservq(&psta_xmitpriv->be_q);
2865d42c78a912 Larry Finger        2010-08-20   45  	_init_txservq(&psta_xmitpriv->bk_q);
2865d42c78a912 Larry Finger        2010-08-20   46  	_init_txservq(&psta_xmitpriv->vi_q);
2865d42c78a912 Larry Finger        2010-08-20   47  	_init_txservq(&psta_xmitpriv->vo_q);
534c4acd1d4594 James A Shackleford 2014-06-24   48  	INIT_LIST_HEAD(&psta_xmitpriv->legacy_dz);
534c4acd1d4594 James A Shackleford 2014-06-24   49  	INIT_LIST_HEAD(&psta_xmitpriv->apsd);
2865d42c78a912 Larry Finger        2010-08-20   50  }
2865d42c78a912 Larry Finger        2010-08-20   51  
ed5d2eaf5f5d59 Nishka Dasgupta     2019-08-09   52  int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,
2865d42c78a912 Larry Finger        2010-08-20   53  			  struct _adapter *padapter)
2865d42c78a912 Larry Finger        2010-08-20   54  {
2865d42c78a912 Larry Finger        2010-08-20   55  	sint i;
2865d42c78a912 Larry Finger        2010-08-20   56  	struct xmit_buf *pxmitbuf;
2865d42c78a912 Larry Finger        2010-08-20   57  	struct xmit_frame *pxframe;
2865d42c78a912 Larry Finger        2010-08-20   58  
2865d42c78a912 Larry Finger        2010-08-20   59  	memset((unsigned char *)pxmitpriv, 0, sizeof(struct xmit_priv));
2865d42c78a912 Larry Finger        2010-08-20   60  	spin_lock_init(&pxmitpriv->lock);
2865d42c78a912 Larry Finger        2010-08-20   61  	/*
09b080f73a4191 Vijai Kumar K       2016-11-20   62  	 *Please insert all the queue initialization using _init_queue below
2865d42c78a912 Larry Finger        2010-08-20   63  	 */
2865d42c78a912 Larry Finger        2010-08-20   64  	pxmitpriv->adapter = padapter;
2865d42c78a912 Larry Finger        2010-08-20   65  	_init_queue(&pxmitpriv->be_pending);
2865d42c78a912 Larry Finger        2010-08-20   66  	_init_queue(&pxmitpriv->bk_pending);
2865d42c78a912 Larry Finger        2010-08-20   67  	_init_queue(&pxmitpriv->vi_pending);
2865d42c78a912 Larry Finger        2010-08-20   68  	_init_queue(&pxmitpriv->vo_pending);
2865d42c78a912 Larry Finger        2010-08-20   69  	_init_queue(&pxmitpriv->bm_pending);
2865d42c78a912 Larry Finger        2010-08-20   70  	_init_queue(&pxmitpriv->legacy_dz_queue);
2865d42c78a912 Larry Finger        2010-08-20   71  	_init_queue(&pxmitpriv->apsd_queue);
2865d42c78a912 Larry Finger        2010-08-20   72  	_init_queue(&pxmitpriv->free_xmit_queue);
2865d42c78a912 Larry Finger        2010-08-20   73  	/*
d7e6ede6acd4fb Aiman Najjar        2020-03-29   74  	 * Please allocate memory with sz = (struct xmit_frame) * NR_XMITFRAME,
09b080f73a4191 Vijai Kumar K       2016-11-20   75  	 * and initialize free_xmit_frame below.
09b080f73a4191 Vijai Kumar K       2016-11-20   76  	 * Please also apply  free_txobj to link_up all the xmit_frames...
2865d42c78a912 Larry Finger        2010-08-20   77  	 */
a77a40cf8b42b3 Bhagyashri Dighole  2019-03-12   78  	pxmitpriv->pallocated_frame_buf =
d7e6ede6acd4fb Aiman Najjar        2020-03-29   79  		kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4,
d7e6ede6acd4fb Aiman Najjar        2020-03-29   80  			GFP_ATOMIC);
9155c92463ecbb Bhumika Goyal       2016-02-24   81  	if (!pxmitpriv->pallocated_frame_buf) {
2865d42c78a912 Larry Finger        2010-08-20   82  		pxmitpriv->pxmit_frame_buf = NULL;
ed5d2eaf5f5d59 Nishka Dasgupta     2019-08-09   83  		return -ENOMEM;
2865d42c78a912 Larry Finger        2010-08-20   84  	}
2865d42c78a912 Larry Finger        2010-08-20   85  	pxmitpriv->pxmit_frame_buf = pxmitpriv->pallocated_frame_buf + 4 -
2865d42c78a912 Larry Finger        2010-08-20   86  			((addr_t) (pxmitpriv->pallocated_frame_buf) & 3);
2865d42c78a912 Larry Finger        2010-08-20   87  	pxframe = (struct xmit_frame *) pxmitpriv->pxmit_frame_buf;
2865d42c78a912 Larry Finger        2010-08-20   88  	for (i = 0; i < NR_XMITFRAME; i++) {
534c4acd1d4594 James A Shackleford 2014-06-24   89  		INIT_LIST_HEAD(&(pxframe->list));
2865d42c78a912 Larry Finger        2010-08-20   90  		pxframe->padapter = padapter;
2865d42c78a912 Larry Finger        2010-08-20   91  		pxframe->frame_tag = DATA_FRAMETAG;
2865d42c78a912 Larry Finger        2010-08-20   92  		pxframe->pkt = NULL;
2865d42c78a912 Larry Finger        2010-08-20   93  		pxframe->buf_addr = NULL;
2865d42c78a912 Larry Finger        2010-08-20   94  		pxframe->pxmitbuf = NULL;
fdfbf7890dcac9 James A Shackleford 2014-06-24   95  		list_add_tail(&(pxframe->list),
2865d42c78a912 Larry Finger        2010-08-20   96  				 &(pxmitpriv->free_xmit_queue.queue));
2865d42c78a912 Larry Finger        2010-08-20   97  		pxframe++;
2865d42c78a912 Larry Finger        2010-08-20   98  	}
2865d42c78a912 Larry Finger        2010-08-20   99  	pxmitpriv->free_xmitframe_cnt = NR_XMITFRAME;
2865d42c78a912 Larry Finger        2010-08-20  100  	/*
09b080f73a4191 Vijai Kumar K       2016-11-20  101  	 * init xmit hw_txqueue
2865d42c78a912 Larry Finger        2010-08-20  102  	 */
2865d42c78a912 Larry Finger        2010-08-20  103  	_r8712_init_hw_txqueue(&pxmitpriv->be_txqueue, BE_QUEUE_INX);
2865d42c78a912 Larry Finger        2010-08-20  104  	_r8712_init_hw_txqueue(&pxmitpriv->bk_txqueue, BK_QUEUE_INX);
2865d42c78a912 Larry Finger        2010-08-20  105  	_r8712_init_hw_txqueue(&pxmitpriv->vi_txqueue, VI_QUEUE_INX);
2865d42c78a912 Larry Finger        2010-08-20  106  	_r8712_init_hw_txqueue(&pxmitpriv->vo_txqueue, VO_QUEUE_INX);
2865d42c78a912 Larry Finger        2010-08-20  107  	_r8712_init_hw_txqueue(&pxmitpriv->bmc_txqueue, BMC_QUEUE_INX);
2865d42c78a912 Larry Finger        2010-08-20  108  	pxmitpriv->frag_len = MAX_FRAG_THRESHOLD;
2865d42c78a912 Larry Finger        2010-08-20  109  	pxmitpriv->txirp_cnt = 1;
2865d42c78a912 Larry Finger        2010-08-20  110  	/*per AC pending irp*/
2865d42c78a912 Larry Finger        2010-08-20  111  	pxmitpriv->beq_cnt = 0;
2865d42c78a912 Larry Finger        2010-08-20  112  	pxmitpriv->bkq_cnt = 0;
2865d42c78a912 Larry Finger        2010-08-20  113  	pxmitpriv->viq_cnt = 0;
2865d42c78a912 Larry Finger        2010-08-20  114  	pxmitpriv->voq_cnt = 0;
2865d42c78a912 Larry Finger        2010-08-20  115  	/*init xmit_buf*/
2865d42c78a912 Larry Finger        2010-08-20  116  	_init_queue(&pxmitpriv->free_xmitbuf_queue);
2865d42c78a912 Larry Finger        2010-08-20  117  	_init_queue(&pxmitpriv->pending_xmitbuf_queue);
a77a40cf8b42b3 Bhagyashri Dighole  2019-03-12  118  	pxmitpriv->pallocated_xmitbuf =
a77a40cf8b42b3 Bhagyashri Dighole  2019-03-12  119  		kmalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4, GFP_ATOMIC);
bd4fcdaddc8d8d Souptick Joarder    2016-10-31  120  	if (!pxmitpriv->pallocated_xmitbuf) {
bd4fcdaddc8d8d Souptick Joarder    2016-10-31  121  		kfree(pxmitpriv->pallocated_frame_buf);
bd4fcdaddc8d8d Souptick Joarder    2016-10-31  122  		pxmitpriv->pallocated_frame_buf = NULL;
ed5d2eaf5f5d59 Nishka Dasgupta     2019-08-09  123  		return -ENOMEM;
bd4fcdaddc8d8d Souptick Joarder    2016-10-31  124  	}
2865d42c78a912 Larry Finger        2010-08-20  125  	pxmitpriv->pxmitbuf = pxmitpriv->pallocated_xmitbuf + 4 -
2865d42c78a912 Larry Finger        2010-08-20  126  			      ((addr_t)(pxmitpriv->pallocated_xmitbuf) & 3);
2865d42c78a912 Larry Finger        2010-08-20  127  	pxmitbuf = (struct xmit_buf *)pxmitpriv->pxmitbuf;
2865d42c78a912 Larry Finger        2010-08-20  128  	for (i = 0; i < NR_XMITBUFF; i++) {
534c4acd1d4594 James A Shackleford 2014-06-24  129  		INIT_LIST_HEAD(&pxmitbuf->list);
45afa5637b85d7 Aiman Najjar        2020-03-29  130  		pxmitbuf->pallocated_buf =
45afa5637b85d7 Aiman Najjar        2020-03-29  131  			kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, GFP_ATOMIC);
9155c92463ecbb Bhumika Goyal       2016-02-24  132  		if (!pxmitbuf->pallocated_buf)
ed5d2eaf5f5d59 Nishka Dasgupta     2019-08-09  133  			return -ENOMEM;
2865d42c78a912 Larry Finger        2010-08-20  134  		pxmitbuf->pbuf = pxmitbuf->pallocated_buf + XMITBUF_ALIGN_SZ -
2865d42c78a912 Larry Finger        2010-08-20  135  				 ((addr_t) (pxmitbuf->pallocated_buf) &
2865d42c78a912 Larry Finger        2010-08-20  136  				 (XMITBUF_ALIGN_SZ - 1));
a4898e78c368fb Nishka Dasgupta     2019-06-26  137  		if (r8712_xmit_resource_alloc(padapter, pxmitbuf))
ed5d2eaf5f5d59 Nishka Dasgupta     2019-08-09  138  			return -ENOMEM;
fdfbf7890dcac9 James A Shackleford 2014-06-24  139  		list_add_tail(&pxmitbuf->list,
2865d42c78a912 Larry Finger        2010-08-20  140  				 &(pxmitpriv->free_xmitbuf_queue.queue));
2865d42c78a912 Larry Finger        2010-08-20  141  		pxmitbuf++;
2865d42c78a912 Larry Finger        2010-08-20  142  	}
2865d42c78a912 Larry Finger        2010-08-20  143  	pxmitpriv->free_xmitbuf_cnt = NR_XMITBUFF;
8810493fc54e75 Deepak Mishra       2019-06-12 @144  	INIT_WORK(&padapter->wk_filter_rx_ff0, r8712_SetFilter);
2865d42c78a912 Larry Finger        2010-08-20  145  	alloc_hwxmits(padapter);
2865d42c78a912 Larry Finger        2010-08-20  146  	init_hwxmits(pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry);
1062aa9e99e6d9 Allen Pais          2020-09-16  147  	tasklet_setup(&pxmitpriv->xmit_tasklet, r8712_xmit_bh);
ed5d2eaf5f5d59 Nishka Dasgupta     2019-08-09  148  	return 0;
2865d42c78a912 Larry Finger        2010-08-20  149  }
2865d42c78a912 Larry Finger        2010-08-20  150  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42103 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-07 16:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07  7:57 [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h Mitali Borkar
2021-04-07  8:05 ` Greg KH
2021-04-07 10:45 ` kernel test robot
2021-04-07 16:21 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).