* [PATCH] phy: ti: j721e-wiz: Configure 'p_standard_mode' only for DP/QSGMII
@ 2021-03-31 13:14 Kishon Vijay Abraham I
2021-03-31 15:41 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2021-03-31 13:14 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul; +Cc: linux-kernel, linux-phy, Lokesh Vutla
Configure 'p_standard_mode' only for DP/QSGMII as for other modes
it's not used as per the programming sequence. Add "continue" in the
else to prevent random value from being written to p_standard_mode.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/ti/phy-j721e-wiz.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 95905e5c4f3d..fc636233dbd6 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -340,6 +340,8 @@ static int wiz_mode_select(struct wiz *wiz)
mode = LANE_MODE_GEN1;
else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII)
mode = LANE_MODE_GEN2;
+ else
+ continue;
ret = regmap_field_write(wiz->p_standard_mode[i], mode);
if (ret)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: ti: j721e-wiz: Configure 'p_standard_mode' only for DP/QSGMII
2021-03-31 13:14 [PATCH] phy: ti: j721e-wiz: Configure 'p_standard_mode' only for DP/QSGMII Kishon Vijay Abraham I
@ 2021-03-31 15:41 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-03-31 15:41 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-kernel, linux-phy, Lokesh Vutla
On 31-03-21, 18:44, Kishon Vijay Abraham I wrote:
> Configure 'p_standard_mode' only for DP/QSGMII as for other modes
> it's not used as per the programming sequence. Add "continue" in the
> else to prevent random value from being written to p_standard_mode.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 13:14 [PATCH] phy: ti: j721e-wiz: Configure 'p_standard_mode' only for DP/QSGMII Kishon Vijay Abraham I
2021-03-31 15:41 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).