From: Al Viro <viro@zeniv.linux.org.uk>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation
Date: Thu, 1 Apr 2021 02:19:12 +0000 [thread overview]
Message-ID: <YGUtoI+rsdm1cKWr@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <87r1jvjclp.fsf@meer.lwn.net>
On Wed, Mar 31, 2021 at 02:24:18PM -0600, Jonathan Corbet wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
>
> > Fix kernel-doc warnings in fs/namespace.c:
> >
> > ./fs/namespace.c:1379: warning: Function parameter or member 'm' not described in 'may_umount_tree'
> > ./fs/namespace.c:1379: warning: Excess function parameter 'mnt' description in 'may_umount_tree'
> > ./fs/namespace.c:1950: warning: Function parameter or member 'path' not described in 'clone_private_mount'
> >
> > Also convert path_is_mountpoint() comments to kernel-doc.
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: linux-doc@vger.kernel.org
> > ---
> > Jon, Al has OK-ed you to merge this patch (and the next one, please).
> >
> > fs/namespace.c | 14 ++++++++------
> > 1 file changed, 8 insertions(+), 6 deletions(-)
>
> An actual acked-by would have been nice, oh well. Meanwhile, I've
> applied them with fixes to the typos in both changelogs :)
Generally speaking, I'm only glad to leave handling kernel-doc patches
to somebody else, especially when they are that trivial ;-)
Anyway,
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
prev parent reply other threads:[~2021-04-01 2:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 2:52 [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation Randy Dunlap
2021-03-18 2:52 ` [PATCH 2/2] Documentation: filesystesm api-summary: add namespace.c Randy Dunlap
2021-03-31 20:24 ` [PATCH 1/2] fs/namespace: corrent/improve kernel-doc notation Jonathan Corbet
2021-04-01 2:19 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGUtoI+rsdm1cKWr@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).