* [PATCH] staging: qlge: remove else after break
@ 2021-04-05 0:41 Mitali Borkar
2021-04-05 1:13 ` [Outreachy kernel] " Matthew Wilcox
2021-04-05 6:21 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Mitali Borkar @ 2021-04-05 0:41 UTC (permalink / raw)
To: manish, GR-Linux-NIC-Dev, gregkh
Cc: outreachy-kernel, linux-staging, linux-kernel, mitaliborkar810
linux-staging@lists,linux-kernel@vger.kernel.org
Bcc:
Subject: [PATCH] staging: qlge:remove else after break
Reply-To:
Fixed Warning:- else is not needed after break
break terminates the loop if encountered. else is unnecessary and
increases indenatation
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
drivers/staging/qlge/qlge_mpi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 2630ebf50341..3a49f187203b 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -935,13 +935,11 @@ static int qlge_idc_wait(struct qlge_adapter *qdev)
netif_err(qdev, drv, qdev->ndev, "IDC Success.\n");
status = 0;
break;
- } else {
- netif_err(qdev, drv, qdev->ndev,
+ } netif_err(qdev, drv, qdev->ndev,
"IDC: Invalid State 0x%.04x.\n",
mbcp->mbox_out[0]);
status = -EIO;
break;
- }
}
return status;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: qlge: remove else after break
2021-04-05 0:41 [PATCH] staging: qlge: remove else after break Mitali Borkar
@ 2021-04-05 1:13 ` Matthew Wilcox
2021-04-05 6:21 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2021-04-05 1:13 UTC (permalink / raw)
To: Mitali Borkar
Cc: manish, GR-Linux-NIC-Dev, gregkh, outreachy-kernel,
linux-staging, linux-kernel
On Mon, Apr 05, 2021 at 06:11:43AM +0530, Mitali Borkar wrote:
> - } else {
> - netif_err(qdev, drv, qdev->ndev,
> + } netif_err(qdev, drv, qdev->ndev,
That's not the normal indentation style ... does checkpatch really not
complain about that?
> "IDC: Invalid State 0x%.04x.\n",
> mbcp->mbox_out[0]);
> status = -EIO;
> break;
> - }
> }
>
> return status;
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YGpcx9MZuZJFy0Z/%40kali.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: qlge: remove else after break
2021-04-05 0:41 [PATCH] staging: qlge: remove else after break Mitali Borkar
2021-04-05 1:13 ` [Outreachy kernel] " Matthew Wilcox
@ 2021-04-05 6:21 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-04-05 6:21 UTC (permalink / raw)
To: Mitali Borkar
Cc: manish, GR-Linux-NIC-Dev, outreachy-kernel, linux-staging, linux-kernel
On Mon, Apr 05, 2021 at 06:11:43AM +0530, Mitali Borkar wrote:
> linux-staging@lists,linux-kernel@vger.kernel.org
> Bcc:
> Subject: [PATCH] staging: qlge:remove else after break
> Reply-To:
Very odd, why is this in the body of the email?
>
> Fixed Warning:- else is not needed after break
> break terminates the loop if encountered. else is unnecessary and
> increases indenatation
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
> drivers/staging/qlge/qlge_mpi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> index 2630ebf50341..3a49f187203b 100644
> --- a/drivers/staging/qlge/qlge_mpi.c
> +++ b/drivers/staging/qlge/qlge_mpi.c
> @@ -935,13 +935,11 @@ static int qlge_idc_wait(struct qlge_adapter *qdev)
> netif_err(qdev, drv, qdev->ndev, "IDC Success.\n");
> status = 0;
> break;
> - } else {
> - netif_err(qdev, drv, qdev->ndev,
> + } netif_err(qdev, drv, qdev->ndev,
> "IDC: Invalid State 0x%.04x.\n",
> mbcp->mbox_out[0]);
> status = -EIO;
> break;
> - }
Indentation is now no longer correct :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-05 6:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-05 0:41 [PATCH] staging: qlge: remove else after break Mitali Borkar
2021-04-05 1:13 ` [Outreachy kernel] " Matthew Wilcox
2021-04-05 6:21 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).