* [PATCH v3] ext4: Fix ext4_error_err save negative errno into superblock
@ 2021-04-06 2:53 Ye Bin
2021-04-10 0:54 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Ye Bin @ 2021-04-06 2:53 UTC (permalink / raw)
To: tytso, adilger.kernel, linux-ext4, linux-kernel
Cc: Ye Bin, Liu Zhi Qiang, Andreas Dilger
As write_mmp_block return 1 when buffer isn't uptodate, return -EIO is
more appropriate.
Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")
Reported-by: Liu Zhi Qiang <liuzhiqiang26@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
---
fs/ext4/mmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 795c3ff2907c..68fbeedd627b 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -56,7 +56,7 @@ static int write_mmp_block(struct super_block *sb, struct buffer_head *bh)
wait_on_buffer(bh);
sb_end_write(sb);
if (unlikely(!buffer_uptodate(bh)))
- return 1;
+ return -EIO;
return 0;
}
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] ext4: Fix ext4_error_err save negative errno into superblock
2021-04-06 2:53 [PATCH v3] ext4: Fix ext4_error_err save negative errno into superblock Ye Bin
@ 2021-04-10 0:54 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2021-04-10 0:54 UTC (permalink / raw)
To: Ye Bin
Cc: adilger.kernel, linux-ext4, linux-kernel, Liu Zhi Qiang, Andreas Dilger
On Tue, Apr 06, 2021 at 10:53:31AM +0800, Ye Bin wrote:
> As write_mmp_block return 1 when buffer isn't uptodate, return -EIO is
> more appropriate.
>
> Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")
> Reported-by: Liu Zhi Qiang <liuzhiqiang26@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-10 0:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 2:53 [PATCH v3] ext4: Fix ext4_error_err save negative errno into superblock Ye Bin
2021-04-10 0:54 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).