From: Johan Hovold <johan@kernel.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: gregkh@linuxfoundation.org,
"Alan Stern" <stern@rowland.harvard.edu>,
penghao <penghao@uniontech.com>,
"Oliver Neukum" <oneukum@suse.com>,
"Jonathan Cox" <jonathan@jdcox.net>,
"Kars Mulder" <kerneldev@karsmulder.nl>,
"Tomasz Meresiński" <tomasz@meresinski.eu>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet
Date: Mon, 12 Apr 2021 15:09:25 +0200 [thread overview]
Message-ID: <YHRGhQ51LeouoWEv@hovoldconsulting.com> (raw)
In-Reply-To: <20210412130521.782373-1-kai.heng.feng@canonical.com>
On Mon, Apr 12, 2021 at 09:05:20PM +0800, Kai-Heng Feng wrote:
> This is another branded 8153 device that doesn't work well with LPM
> enabled:
> [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71
>
> So disable LPM to resolve the issue.
>
> BugLink: https://bugs.launchpad.net/bugs/1922651
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
> - Put the quirk in the right order.
Seriously... You sent the exact same patch again. Still not ordered.
>
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 76ac5d6555ae..dfedb51cf832 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> { USB_DEVICE(0x1532, 0x0116), .driver_info =
> USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>
> + /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */
> + { USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM },
> +
> /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */
> { USB_DEVICE(0x17ef, 0xa012), .driver_info =
> USB_QUIRK_DISCONNECT_SUSPEND },
Johan
next prev parent reply other threads:[~2021-04-12 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 13:05 [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet Kai-Heng Feng
2021-04-12 13:09 ` Johan Hovold [this message]
2021-04-12 13:10 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHRGhQ51LeouoWEv@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathan@jdcox.net \
--cc=kai.heng.feng@canonical.com \
--cc=kerneldev@karsmulder.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=penghao@uniontech.com \
--cc=stern@rowland.harvard.edu \
--cc=tomasz@meresinski.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).