* [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet
@ 2021-04-12 13:05 Kai-Heng Feng
2021-04-12 13:09 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Kai-Heng Feng @ 2021-04-12 13:05 UTC (permalink / raw)
To: gregkh
Cc: Kai-Heng Feng, Alan Stern, penghao, Oliver Neukum, Johan Hovold,
Jonathan Cox, Kars Mulder, Tomasz Meresiński,
open list:USB SUBSYSTEM, open list
This is another branded 8153 device that doesn't work well with LPM
enabled:
[ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71
So disable LPM to resolve the issue.
BugLink: https://bugs.launchpad.net/bugs/1922651
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2:
- Put the quirk in the right order.
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 76ac5d6555ae..dfedb51cf832 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x1532, 0x0116), .driver_info =
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
+ /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */
+ { USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM },
+
/* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */
{ USB_DEVICE(0x17ef, 0xa012), .driver_info =
USB_QUIRK_DISCONNECT_SUSPEND },
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet
2021-04-12 13:05 [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet Kai-Heng Feng
@ 2021-04-12 13:09 ` Johan Hovold
2021-04-12 13:10 ` Kai-Heng Feng
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2021-04-12 13:09 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: gregkh, Alan Stern, penghao, Oliver Neukum, Jonathan Cox,
Kars Mulder, Tomasz Meresiński, open list:USB SUBSYSTEM,
open list
On Mon, Apr 12, 2021 at 09:05:20PM +0800, Kai-Heng Feng wrote:
> This is another branded 8153 device that doesn't work well with LPM
> enabled:
> [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71
>
> So disable LPM to resolve the issue.
>
> BugLink: https://bugs.launchpad.net/bugs/1922651
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
> - Put the quirk in the right order.
Seriously... You sent the exact same patch again. Still not ordered.
>
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 76ac5d6555ae..dfedb51cf832 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> { USB_DEVICE(0x1532, 0x0116), .driver_info =
> USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>
> + /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */
> + { USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM },
> +
> /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */
> { USB_DEVICE(0x17ef, 0xa012), .driver_info =
> USB_QUIRK_DISCONNECT_SUSPEND },
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet
2021-04-12 13:09 ` Johan Hovold
@ 2021-04-12 13:10 ` Kai-Heng Feng
0 siblings, 0 replies; 3+ messages in thread
From: Kai-Heng Feng @ 2021-04-12 13:10 UTC (permalink / raw)
To: Johan Hovold
Cc: Greg Kroah-Hartman, Alan Stern, penghao, Oliver Neukum,
Jonathan Cox, Kars Mulder, Tomasz Meresiński,
open list:USB SUBSYSTEM, open list
On Mon, Apr 12, 2021 at 9:09 PM Johan Hovold <johan@kernel.org> wrote:
>
> On Mon, Apr 12, 2021 at 09:05:20PM +0800, Kai-Heng Feng wrote:
> > This is another branded 8153 device that doesn't work well with LPM
> > enabled:
> > [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71
> >
> > So disable LPM to resolve the issue.
> >
> > BugLink: https://bugs.launchpad.net/bugs/1922651
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> > ---
> > v2:
> > - Put the quirk in the right order.
>
> Seriously... You sent the exact same patch again. Still not ordered.
Oops, sorry for that, I mistyped the patch name :(
Will send a correct one.
Kai-Heng
>
> >
> > drivers/usb/core/quirks.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> > index 76ac5d6555ae..dfedb51cf832 100644
> > --- a/drivers/usb/core/quirks.c
> > +++ b/drivers/usb/core/quirks.c
> > @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> > { USB_DEVICE(0x1532, 0x0116), .driver_info =
> > USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
> >
> > + /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */
> > + { USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM },
> > +
> > /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */
> > { USB_DEVICE(0x17ef, 0xa012), .driver_info =
> > USB_QUIRK_DISCONNECT_SUSPEND },
>
> Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-12 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 13:05 [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet Kai-Heng Feng
2021-04-12 13:09 ` Johan Hovold
2021-04-12 13:10 ` Kai-Heng Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).