* [PATCH] rapidio: remove unused variable in rio_cm.c
@ 2021-05-01 5:50 Anirudh Rayabharam
2021-05-01 10:23 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Anirudh Rayabharam @ 2021-05-01 5:50 UTC (permalink / raw)
To: Matt Porter, Alexandre Bounine
Cc: gregkh, linux-kernel-mentees, Anirudh Rayabharam, linux-kernel
Remove unused variable 'rc' to fix gcc warning:
drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but
not used [-Wunused-but-set-variable]
Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
---
drivers/rapidio/rio_cm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index 50ec53d67a4c..545693bd86a3 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
*/
if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
struct tx_req *req, *_req;
- int rc;
list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
list_del(&req->node);
cm->tx_buf[cm->tx_slot] = req->buffer;
- rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
+ rio_add_outb_message(cm->mport, req->rdev, cmbox,
req->buffer, req->len);
kfree(req->buffer);
kfree(req);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rapidio: remove unused variable in rio_cm.c
2021-05-01 5:50 [PATCH] rapidio: remove unused variable in rio_cm.c Anirudh Rayabharam
@ 2021-05-01 10:23 ` Greg KH
2021-05-01 13:10 ` Anirudh Rayabharam
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-05-01 10:23 UTC (permalink / raw)
To: Anirudh Rayabharam
Cc: Matt Porter, Alexandre Bounine, linux-kernel-mentees, linux-kernel
On Sat, May 01, 2021 at 11:20:17AM +0530, Anirudh Rayabharam wrote:
> Remove unused variable 'rc' to fix gcc warning:
>
> drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
> drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but
> not used [-Wunused-but-set-variable]
>
> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> ---
> drivers/rapidio/rio_cm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
> index 50ec53d67a4c..545693bd86a3 100644
> --- a/drivers/rapidio/rio_cm.c
> +++ b/drivers/rapidio/rio_cm.c
> @@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
> */
> if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
> struct tx_req *req, *_req;
> - int rc;
>
> list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
> list_del(&req->node);
> cm->tx_buf[cm->tx_slot] = req->buffer;
> - rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
> + rio_add_outb_message(cm->mport, req->rdev, cmbox,
> req->buffer, req->len);
Why not handle the potential error sent here?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rapidio: remove unused variable in rio_cm.c
2021-05-01 10:23 ` Greg KH
@ 2021-05-01 13:10 ` Anirudh Rayabharam
0 siblings, 0 replies; 3+ messages in thread
From: Anirudh Rayabharam @ 2021-05-01 13:10 UTC (permalink / raw)
To: Greg KH
Cc: Matt Porter, Alexandre Bounine, linux-kernel-mentees, linux-kernel, mail
On Sat, May 01, 2021 at 12:23:30PM +0200, Greg KH wrote:
> On Sat, May 01, 2021 at 11:20:17AM +0530, Anirudh Rayabharam wrote:
> > Remove unused variable 'rc' to fix gcc warning:
> >
> > drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
> > drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but
> > not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> > ---
> > drivers/rapidio/rio_cm.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
> > index 50ec53d67a4c..545693bd86a3 100644
> > --- a/drivers/rapidio/rio_cm.c
> > +++ b/drivers/rapidio/rio_cm.c
> > @@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
> > */
> > if (!list_empty(&cm->tx_reqs) && (cm->tx_cnt < RIOCM_TX_RING_SIZE)) {
> > struct tx_req *req, *_req;
> > - int rc;
> >
> > list_for_each_entry_safe(req, _req, &cm->tx_reqs, node) {
> > list_del(&req->node);
> > cm->tx_buf[cm->tx_slot] = req->buffer;
> > - rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
> > + rio_add_outb_message(cm->mport, req->rdev, cmbox,
> > req->buffer, req->len);
>
> Why not handle the potential error sent here?
I don't know how it should be handled (these functions don't return anything).
I assumed that since it is not currently being handled, it's probably not
useful.
I'll look into it though. I guess we could simply log it at the very least.
Thanks!
- Anirudh.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-01 13:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-01 5:50 [PATCH] rapidio: remove unused variable in rio_cm.c Anirudh Rayabharam
2021-05-01 10:23 ` Greg KH
2021-05-01 13:10 ` Anirudh Rayabharam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).