linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: "Zanussi, Tom" <tom.zanussi@linux.intel.com>
Cc: peterz@infradead.org, acme@kernel.org, mingo@kernel.org,
	kan.liang@linux.intel.com, dave.jiang@intel.com,
	tony.luck@intel.com, dan.j.williams@intel.com,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support
Date: Wed, 21 Apr 2021 20:33:37 +0530	[thread overview]
Message-ID: <YIA+ycNfqwytoy/Z@vkoul-mobl.Dlink> (raw)
In-Reply-To: <410134d7-5a4d-3537-e9cc-c4c8e7068cde@linux.intel.com>

On 21-04-21, 07:50, Zanussi, Tom wrote:

> > > > > +static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
> > > > > +			    char *buf);
> > > > > +
> > > > > +static cpumask_t		perfmon_dsa_cpu_mask;
> > > > > +static bool			cpuhp_set_up;
> > > > > +static enum cpuhp_state		cpuhp_slot;
> > > > > +
> > > > > +static DEVICE_ATTR_RO(cpumask);
> > > > 
> > > > Pls document these new attributes added
> > 
> > ?
> > 
> 
> Yes, I'll add comments to all the attributes (also I'm assuming they don't need to be documented elsewhere).

They need to be, all new sysfs attributes are ABI and need to be
documented in Documentation/ABI/

Thanks
-- 
~Vinod

  reply	other threads:[~2021-04-21 15:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-03 16:45 [PATCH v2 0/1] dmaengine: idxd: IDXD pmu support Tom Zanussi
2021-04-03 16:45 ` [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support Tom Zanussi
2021-04-20 11:11   ` Vinod Koul
2021-04-20 14:13     ` Zanussi, Tom
2021-04-21  6:01       ` Vinod Koul
2021-04-21 12:50         ` Zanussi, Tom
2021-04-21 15:03           ` Vinod Koul [this message]
2021-04-21 15:47             ` Zanussi, Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIA+ycNfqwytoy/Z@vkoul-mobl.Dlink \
    --to=vkoul@kernel.org \
    --cc=acme@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tom.zanussi@linux.intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).