linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Zanussi, Tom" <tom.zanussi@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: peterz@infradead.org, acme@kernel.org, mingo@kernel.org,
	kan.liang@linux.intel.com, dave.jiang@intel.com,
	tony.luck@intel.com, dan.j.williams@intel.com,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support
Date: Wed, 21 Apr 2021 10:47:21 -0500	[thread overview]
Message-ID: <fa867751-0019-1950-bdc4-019737f29e4b@linux.intel.com> (raw)
In-Reply-To: <YIA+ycNfqwytoy/Z@vkoul-mobl.Dlink>



On 4/21/2021 10:03 AM, Vinod Koul wrote:
> On 21-04-21, 07:50, Zanussi, Tom wrote:
> 
>>>>>> +static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
>>>>>> +			    char *buf);
>>>>>> +
>>>>>> +static cpumask_t		perfmon_dsa_cpu_mask;
>>>>>> +static bool			cpuhp_set_up;
>>>>>> +static enum cpuhp_state		cpuhp_slot;
>>>>>> +
>>>>>> +static DEVICE_ATTR_RO(cpumask);
>>>>>
>>>>> Pls document these new attributes added
>>>
>>> ?
>>>
>>
>> Yes, I'll add comments to all the attributes (also I'm assuming they don't need to be documented elsewhere).
> 
> They need to be, all new sysfs attributes are ABI and need to be
> documented in Documentation/ABI/
> 

OK, will do that as well, thanks for letting me know.

Tom

> Thanks
> 

      reply	other threads:[~2021-04-21 15:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-03 16:45 [PATCH v2 0/1] dmaengine: idxd: IDXD pmu support Tom Zanussi
2021-04-03 16:45 ` [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support Tom Zanussi
2021-04-20 11:11   ` Vinod Koul
2021-04-20 14:13     ` Zanussi, Tom
2021-04-21  6:01       ` Vinod Koul
2021-04-21 12:50         ` Zanussi, Tom
2021-04-21 15:03           ` Vinod Koul
2021-04-21 15:47             ` Zanussi, Tom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa867751-0019-1950-bdc4-019737f29e4b@linux.intel.com \
    --to=tom.zanussi@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tony.luck@intel.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).