linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sabrina Dubroca <sd@queasysnail.net>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, edumazet@google.com, fw@strlen.de
Subject: Re: [PATCH v2] net: geneve: modify IP header check in geneve6_xmit_skb and geneve_xmit_skb
Date: Fri, 23 Apr 2021 15:41:17 +0200	[thread overview]
Message-ID: <YILOfTt6qKNwYtV6@hog> (raw)
In-Reply-To: <20210422234945.1190-1-phil@philpotter.co.uk>

2021-04-23, 00:49:45 +0100, Phillip Potter wrote:
> Modify the header size check in geneve6_xmit_skb and geneve_xmit_skb
> to use pskb_inet_may_pull rather than pskb_network_may_pull. This fixes
> two kernel selftest failures introduced by the commit introducing the
> checks:
> IPv4 over geneve6: PMTU exceptions
> IPv4 over geneve6: PMTU exceptions - nexthop objects
> 
> It does this by correctly accounting for the fact that IPv4 packets may
> transit over geneve IPv6 tunnels (and vice versa), and still fixes the
> uninit-value bug fixed by the original commit.
> 
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Fixes: 6628ddfec758 ("net: geneve: check skb is large enough for IPv4/IPv6 header")
> Suggested-by: Sabrina Dubroca <sd@queasysnail.net>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> 
> V2:
> * Incorporated feedback from Sabrina Dubroca regarding pskb_inet_may_pull
> * Added Fixes: tag as requested by Eric Dumazet

Thanks Phillip.

Acked-by: Sabrina Dubroca <sd@queasysnail.net>

Jakub/David, it would be great if this could get in 5.12, otherwise
geneve is a bit broken:
https://bugzilla.kernel.org/show_bug.cgi?id=212749

-- 
Sabrina


  reply	other threads:[~2021-04-23 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 23:49 [PATCH v2] net: geneve: modify IP header check in geneve6_xmit_skb and geneve_xmit_skb Phillip Potter
2021-04-23 13:41 ` Sabrina Dubroca [this message]
2021-04-23 20:44   ` David Miller
2021-04-23 20:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YILOfTt6qKNwYtV6@hog \
    --to=sd@queasysnail.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).