linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: bkkarthik <bkkarthik@pesu.pes.edu>
Cc: Anupama K Patil <anupamakpatil123@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org, gregkh@linuxfoundation.org,
	kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices
Date: Tue, 27 Apr 2021 07:26:27 +0300	[thread overview]
Message-ID: <YIeSc1qePhuQ1XRK@unreal> (raw)
In-Reply-To: <20210426175031.w26ovnffjiow346h@burgerking>

On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote:
> On 21/04/26 08:04AM, Leon Romanovsky wrote:
> > On Sun, Apr 25, 2021 at 01:13:01AM +0530, Anupama K Patil wrote:
> > > isapnp_proc_init() does not look at the return value from
> > > isapnp_proc_attach_device(). Check for this return value in
> > > isapnp_proc_detach_device().
> > > 
> > > Cleanup in isapnp_proc_detach_device and
> > > isapnp_proc_detach_bus() for cleanup.
> > > 
> > > Changed sprintf() to the kernel-space function scnprintf() as it returns
> > > the actual number of bytes written.
> > > 
> > > Removed unnecessary variables de, e of type 'struct proc_dir_entry' to
> > > save memory.

<...>

> > > +static int isapnp_proc_detach_device(struct pnp_dev *dev)
> > > +{
> > > +	proc_remove(dev->procent);
> > > +	dev->procent = NULL;
> > > +	return 0;
> > > +}
> > > +
> > > +static int isapnp_proc_detach_bus(struct pnp_card *bus)
> > > +{
> > > +	proc_remove(bus->procdir);
> > > +	return 0;
> > > +}
> > 
> > Please don't add one line functions that are called only once and have
> > return value that no one care about it.
> 
> These were only intended for a clean-up job, the idea of this function came from how PCI handles procfs.
> Maybe those should be changed?

Probably, the CONFIG_PROC_FS around pci_proc_*() is not needed too.

Thanks

  reply	other threads:[~2021-04-27  4:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 19:43 Anupama K Patil
2021-04-24 20:37 ` Valdis Klētnieks
2021-04-25  1:06 ` Barnabás Pőcze
2021-04-26  5:04 ` Leon Romanovsky
2021-04-26 17:50   ` bkkarthik
2021-04-27  4:26     ` Leon Romanovsky [this message]
2021-04-29  4:31       ` Valdis Klētnieks
2021-04-29  7:05         ` Leon Romanovsky
2021-04-28 12:04     ` Jaroslav Kysela
2021-04-28 12:21       ` Leon Romanovsky
2021-04-28 12:26         ` bkkarthik
2021-04-28 12:30         ` Jaroslav Kysela
2021-04-28 12:37           ` bkkarthik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIeSc1qePhuQ1XRK@unreal \
    --to=leon@kernel.org \
    --cc=anupamakpatil123@gmail.com \
    --cc=bkkarthik@pesu.pes.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=skhan@linuxfoundation.org \
    --subject='Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox