* [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl()
@ 2021-05-08 2:54 Zhen Lei
2021-05-09 20:41 ` Jarkko Sakkinen
0 siblings, 1 reply; 4+ messages in thread
From: Zhen Lei @ 2021-05-08 2:54 UTC (permalink / raw)
To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, James Bottomley,
linux-integrity, linux-kernel
Cc: Zhen Lei
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/char/tpm/tpm2-cmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index eff1f12d981a..c84d23951219 100644
--- a/drivers/char/tpm/tpm2-cmd.c
+++ b/drivers/char/tpm/tpm2-cmd.c
@@ -656,6 +656,7 @@ int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)
if (nr_commands !=
be32_to_cpup((__be32 *)&buf.data[TPM_HEADER_SIZE + 5])) {
+ rc = -EFAULT;
tpm_buf_destroy(&buf);
goto out;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl()
2021-05-08 2:54 [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl() Zhen Lei
@ 2021-05-09 20:41 ` Jarkko Sakkinen
2021-05-12 1:12 ` Leizhen (ThunderTown)
0 siblings, 1 reply; 4+ messages in thread
From: Jarkko Sakkinen @ 2021-05-09 20:41 UTC (permalink / raw)
To: Zhen Lei
Cc: Peter Huewe, Jason Gunthorpe, James Bottomley, linux-integrity,
linux-kernel
On Sat, May 08, 2021 at 10:54:44AM +0800, Zhen Lei wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
In the commit message:
1. Instead of writing "a negative error code", write -EFAULT.
2. Some explanation of the choice.
> ---
> drivers/char/tpm/tpm2-cmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
> index eff1f12d981a..c84d23951219 100644
> --- a/drivers/char/tpm/tpm2-cmd.c
> +++ b/drivers/char/tpm/tpm2-cmd.c
> @@ -656,6 +656,7 @@ int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)
>
> if (nr_commands !=
> be32_to_cpup((__be32 *)&buf.data[TPM_HEADER_SIZE + 5])) {
> + rc = -EFAULT;
> tpm_buf_destroy(&buf);
> goto out;
> }
> --
> 2.25.1
>
>
>
Other than that looks good.
/Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl()
2021-05-09 20:41 ` Jarkko Sakkinen
@ 2021-05-12 1:12 ` Leizhen (ThunderTown)
2021-05-12 1:21 ` Jarkko Sakkinen
0 siblings, 1 reply; 4+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-12 1:12 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Peter Huewe, Jason Gunthorpe, James Bottomley, linux-integrity,
linux-kernel
On 2021/5/10 4:41, Jarkko Sakkinen wrote:
> On Sat, May 08, 2021 at 10:54:44AM +0800, Zhen Lei wrote:
>> Fix to return a negative error code from the error handling
>> case instead of 0, as done elsewhere in this function.
>>
>> Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> In the commit message:
>
> 1. Instead of writing "a negative error code", write -EFAULT.
OK, I will change it.
> 2. Some explanation of the choice.
Do you mean why I choice error code -EFAULT? There's a similar one above this branch.
if (nr_commands > 0xFFFFF) {
rc = -EFAULT;
goto out;
}
>
>> ---
>> drivers/char/tpm/tpm2-cmd.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
>> index eff1f12d981a..c84d23951219 100644
>> --- a/drivers/char/tpm/tpm2-cmd.c
>> +++ b/drivers/char/tpm/tpm2-cmd.c
>> @@ -656,6 +656,7 @@ int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)
>>
>> if (nr_commands !=
>> be32_to_cpup((__be32 *)&buf.data[TPM_HEADER_SIZE + 5])) {
>> + rc = -EFAULT;
>> tpm_buf_destroy(&buf);
>> goto out;
>> }
>> --
>> 2.25.1
>>
>>
>>
>
> Other than that looks good.
>
> /Jarkko
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl()
2021-05-12 1:12 ` Leizhen (ThunderTown)
@ 2021-05-12 1:21 ` Jarkko Sakkinen
0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2021-05-12 1:21 UTC (permalink / raw)
To: Leizhen (ThunderTown)
Cc: Peter Huewe, Jason Gunthorpe, James Bottomley, linux-integrity,
linux-kernel
On Wed, May 12, 2021 at 09:12:26AM +0800, Leizhen (ThunderTown) wrote:
>
>
> On 2021/5/10 4:41, Jarkko Sakkinen wrote:
> > On Sat, May 08, 2021 at 10:54:44AM +0800, Zhen Lei wrote:
> >> Fix to return a negative error code from the error handling
> >> case instead of 0, as done elsewhere in this function.
> >>
> >> Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >
> > In the commit message:
> >
> > 1. Instead of writing "a negative error code", write -EFAULT.
> OK, I will change it.
>
> > 2. Some explanation of the choice.
> Do you mean why I choice error code -EFAULT? There's a similar one above this branch.
>
> if (nr_commands > 0xFFFFF) {
> rc = -EFAULT;
> goto out;
> }
I mean that the commit message must rationalize whatever the commit does,
and choices made.
/Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-12 1:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 2:54 [PATCH 1/1] tpm: fix error return code in tpm2_get_cc_attrs_tbl() Zhen Lei
2021-05-09 20:41 ` Jarkko Sakkinen
2021-05-12 1:12 ` Leizhen (ThunderTown)
2021-05-12 1:21 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).