From: Borislav Petkov <bp@alien8.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: rric@kernel.org, mchehab@kernel.org, tony.luck@intel.com,
james.morse@arm.com, s.temerkhanov@gmail.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] EDAC/thunderx: Fix an error message
Date: Mon, 10 May 2021 10:36:37 +0200 [thread overview]
Message-ID: <YJjwlTI30S9PfD4I@zn.tnic> (raw)
In-Reply-To: <0c046ef5cfb367a3f707ef4270e21a2bcbf44952.1620280098.git.christophe.jaillet@wanadoo.fr>
On Thu, May 06, 2021 at 07:49:34AM +0200, Christophe JAILLET wrote:
> 'ret' is known to be 0 here.
> No error code is available, so just remove it from the error message.
>
> Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/edac/thunderx_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index 0eb5eb97fd74..f13674081cb6 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -1368,7 +1368,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev,
> name, 1, "CCPI", 1,
> 0, NULL, 0, idx);
> if (!edac_dev) {
> - dev_err(&pdev->dev, "Cannot allocate EDAC device: %d\n", ret);
> + dev_err(&pdev->dev, "Cannot allocate EDAC device\n");
> return -ENOMEM;
> }
> ocx = edac_dev->pvt_info;
> @@ -1380,7 +1380,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev,
>
> ocx->regs = pcim_iomap_table(pdev)[0];
> if (!ocx->regs) {
> - dev_err(&pdev->dev, "Cannot map PCI resources: %d\n", ret);
> + dev_err(&pdev->dev, "Cannot map PCI resources\n");
> ret = -ENODEV;
> goto err_free;
> }
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-05-10 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 5:49 [PATCH] EDAC/thunderx: Fix an error message Christophe JAILLET
2021-05-10 8:36 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJjwlTI30S9PfD4I@zn.tnic \
--to=bp@alien8.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=s.temerkhanov@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).