* [PATCH] EDAC/thunderx: Fix an error message
@ 2021-05-06 5:49 Christophe JAILLET
2021-05-10 8:36 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-05-06 5:49 UTC (permalink / raw)
To: rric, bp, mchehab, tony.luck, james.morse, s.temerkhanov
Cc: linux-edac, linux-kernel, kernel-janitors, Christophe JAILLET
'ret' is known to be 0 here.
No error code is available, so just remove it from the error message.
Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/edac/thunderx_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
index 0eb5eb97fd74..f13674081cb6 100644
--- a/drivers/edac/thunderx_edac.c
+++ b/drivers/edac/thunderx_edac.c
@@ -1368,7 +1368,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev,
name, 1, "CCPI", 1,
0, NULL, 0, idx);
if (!edac_dev) {
- dev_err(&pdev->dev, "Cannot allocate EDAC device: %d\n", ret);
+ dev_err(&pdev->dev, "Cannot allocate EDAC device\n");
return -ENOMEM;
}
ocx = edac_dev->pvt_info;
@@ -1380,7 +1380,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev,
ocx->regs = pcim_iomap_table(pdev)[0];
if (!ocx->regs) {
- dev_err(&pdev->dev, "Cannot map PCI resources: %d\n", ret);
+ dev_err(&pdev->dev, "Cannot map PCI resources\n");
ret = -ENODEV;
goto err_free;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EDAC/thunderx: Fix an error message
2021-05-06 5:49 [PATCH] EDAC/thunderx: Fix an error message Christophe JAILLET
@ 2021-05-10 8:36 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2021-05-10 8:36 UTC (permalink / raw)
To: Christophe JAILLET
Cc: rric, mchehab, tony.luck, james.morse, s.temerkhanov, linux-edac,
linux-kernel, kernel-janitors
On Thu, May 06, 2021 at 07:49:34AM +0200, Christophe JAILLET wrote:
> 'ret' is known to be 0 here.
> No error code is available, so just remove it from the error message.
>
> Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/edac/thunderx_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index 0eb5eb97fd74..f13674081cb6 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -1368,7 +1368,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev,
> name, 1, "CCPI", 1,
> 0, NULL, 0, idx);
> if (!edac_dev) {
> - dev_err(&pdev->dev, "Cannot allocate EDAC device: %d\n", ret);
> + dev_err(&pdev->dev, "Cannot allocate EDAC device\n");
> return -ENOMEM;
> }
> ocx = edac_dev->pvt_info;
> @@ -1380,7 +1380,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev,
>
> ocx->regs = pcim_iomap_table(pdev)[0];
> if (!ocx->regs) {
> - dev_err(&pdev->dev, "Cannot map PCI resources: %d\n", ret);
> + dev_err(&pdev->dev, "Cannot map PCI resources\n");
> ret = -ENODEV;
> goto err_free;
> }
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-10 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 5:49 [PATCH] EDAC/thunderx: Fix an error message Christophe JAILLET
2021-05-10 8:36 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).