* [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin
@ 2021-04-10 19:35 Grzegorz Szymaszek
2021-05-27 19:59 ` Grzegorz Szymaszek
2021-06-01 9:27 ` Alexandre TORGUE
0 siblings, 2 replies; 3+ messages in thread
From: Grzegorz Szymaszek @ 2021-04-10 19:35 UTC (permalink / raw)
Cc: Grzegorz Szymaszek, Ahmad Fatoum, Alexandre Torgue,
Marcin Słoniewski, Maxime Coquelin, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-stm32
The microSD card detect pin is physically connected to the MPU pin PI3.
The Device Tree configuration of the card detect pin was wrong—it was
set to pin PB7 instead. If such configuration was used, the kernel would
hang on “Waiting for root device” when booting from a microSD card.
Signed-off-by: Grzegorz Szymaszek <gszymaszek@short.pl>
---
arch/arm/boot/dts/stm32mp157c-odyssey.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey.dts b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
index a7ffec8f1516..be1dd5e9e744 100644
--- a/arch/arm/boot/dts/stm32mp157c-odyssey.dts
+++ b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
@@ -64,7 +64,7 @@ &sdmmc1 {
pinctrl-0 = <&sdmmc1_b4_pins_a>;
pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
- cd-gpios = <&gpiob 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+ cd-gpios = <&gpioi 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
disable-wp;
st,neg-edge;
bus-width = <4>;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin
2021-04-10 19:35 [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin Grzegorz Szymaszek
@ 2021-05-27 19:59 ` Grzegorz Szymaszek
2021-06-01 9:27 ` Alexandre TORGUE
1 sibling, 0 replies; 3+ messages in thread
From: Grzegorz Szymaszek @ 2021-05-27 19:59 UTC (permalink / raw)
Cc: Grzegorz Szymaszek, Ahmad Fatoum, Alexandre Torgue,
Marcin Słoniewski, Maxime Coquelin, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-stm32
On Sat, Apr 10, 2021 at 09:35:21PM +0200, Grzegorz Szymaszek wrote:
> The microSD card detect pin is physically connected to the MPU pin PI3.
> The Device Tree configuration of the card detect pin was wrong—it was
> set to pin PB7 instead. If such configuration was used, the kernel would
> hang on “Waiting for root device” when booting from a microSD card.
>
> Signed-off-by: Grzegorz Szymaszek <gszymaszek@short.pl>
> ---
> arch/arm/boot/dts/stm32mp157c-odyssey.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey.dts b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> index a7ffec8f1516..be1dd5e9e744 100644
> --- a/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> @@ -64,7 +64,7 @@ &sdmmc1 {
> pinctrl-0 = <&sdmmc1_b4_pins_a>;
> pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
> pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
> - cd-gpios = <&gpiob 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> + cd-gpios = <&gpioi 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> disable-wp;
> st,neg-edge;
> bus-width = <4>;
> --
> 2.30.2
>
A gentle ping. FWIW, there was another patch that would deal with the
same issue:
<https://st-md-mailman.stormreply.com/pipermail/linux-stm32/2021-April/011132.html>,
but it took the more radical approach of of replacing cd-gpios with
broken-cd.
--
Grzegorz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin
2021-04-10 19:35 [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin Grzegorz Szymaszek
2021-05-27 19:59 ` Grzegorz Szymaszek
@ 2021-06-01 9:27 ` Alexandre TORGUE
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre TORGUE @ 2021-06-01 9:27 UTC (permalink / raw)
To: Grzegorz Szymaszek
Cc: Ahmad Fatoum, Marcin Słoniewski, Maxime Coquelin,
Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
linux-stm32
On 4/10/21 9:35 PM, Grzegorz Szymaszek wrote:
> The microSD card detect pin is physically connected to the MPU pin PI3.
> The Device Tree configuration of the card detect pin was wrong—it was
> set to pin PB7 instead. If such configuration was used, the kernel would
> hang on “Waiting for root device” when booting from a microSD card.
>
> Signed-off-by: Grzegorz Szymaszek <gszymaszek@short.pl>
> ---
> arch/arm/boot/dts/stm32mp157c-odyssey.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey.dts b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> index a7ffec8f1516..be1dd5e9e744 100644
> --- a/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> @@ -64,7 +64,7 @@ &sdmmc1 {
> pinctrl-0 = <&sdmmc1_b4_pins_a>;
> pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
> pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
> - cd-gpios = <&gpiob 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> + cd-gpios = <&gpioi 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> disable-wp;
> st,neg-edge;
> bus-width = <4>;
>
Hi Grzegorz
Applied on stm32-next.
Thanks.
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-01 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-10 19:35 [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin Grzegorz Szymaszek
2021-05-27 19:59 ` Grzegorz Szymaszek
2021-06-01 9:27 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).