From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: swboyd@chromium.org, mka@chromium.org, evgreen@chromium.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
agross@kernel.org, dianders@chromium.org, linux@roeck-us.net,
rnayak@codeaurora.org, lsrao@codeaurora.org,
Mahesh Sivasubramanian <msivasub@codeaurora.org>,
Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH v7 2/5] soc: qcom: Add SoC sleep stats driver
Date: Tue, 25 May 2021 23:00:46 -0500 [thread overview]
Message-ID: <YK3H7m7bpL2DJt9R@builder.lan> (raw)
In-Reply-To: <cd54214e-8c60-8f92-3c0b-f7367f1bd42e@codeaurora.org>
On Fri 21 May 06:10 CDT 2021, Maulik Shah wrote:
> On 4/13/2021 5:13 AM, Bjorn Andersson wrote:
> > On Tue 06 Apr 05:27 CDT 2021, Maulik Shah wrote:
[..]
> > > diff --git a/drivers/soc/qcom/soc_sleep_stats.c b/drivers/soc/qcom/soc_sleep_stats.c
[..]
> > > +MODULE_SOFTDEP("pre: smem");
> > I believe this should be "qcom_smem",
> the module has smem.ko file so "smem" looks proper.
> > but given that you call
> > qcom_smem_get() in your code you have a hard dependency in place
> > already. So, can you help me understand what use this softdep provide?
>
> If both smem and soc_sleep_stats are compiled as DLKMs, this is to make sure
> smem module was loaded first by keeping pre soft dependency.
>
But we're making a direct function call into the qcom_smem driver, so we
already have a hard dependency on qcom_smem.ko being loaded.
Regards,
Bjorn
next prev parent reply other threads:[~2021-05-26 4:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 10:27 [PATCH v7 0/5] Introduce SoC sleep stats driver Maulik Shah
2021-04-06 10:27 ` [PATCH v7 1/5] dt-bindings: Introduce SoC sleep stats bindings Maulik Shah
2021-04-06 10:27 ` [PATCH v7 2/5] soc: qcom: Add SoC sleep stats driver Maulik Shah
2021-04-12 23:43 ` Bjorn Andersson
2021-05-21 11:10 ` Maulik Shah
2021-05-26 4:00 ` Bjorn Andersson [this message]
2021-04-06 10:27 ` [PATCH v7 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats Maulik Shah
2021-04-06 10:27 ` [PATCH v7 4/5] arm64: defconfig: Enable SoC sleep stats driver Maulik Shah
2021-04-06 10:27 ` [PATCH v7 5/5] arm64: dts: qcom: sc7280: Enable SoC sleep stats Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK3H7m7bpL2DJt9R@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lsrao@codeaurora.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=msivasub@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).