From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
mihai.carabas@oracle.com, pizhenwei@bytedance.com,
pbonzini@redhat.com, linqiheng@huawei.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()'
Date: Mon, 17 May 2021 13:34:20 +0300 [thread overview]
Message-ID: <YKJGrGTHz+DzfiHN@smile.fi.intel.com> (raw)
In-Reply-To: <ada55e25-5eb3-9b6b-5783-d2303db9bf83@wanadoo.fr>
On Mon, May 17, 2021 at 12:02:24PM +0200, Christophe JAILLET wrote:
> Le 17/05/2021 à 10:01, Andy Shevchenko a écrit :
> > On Sun, May 16, 2021 at 04:36:55PM +0200, Christophe JAILLET wrote:
> > > There is no error handling path in the probe function.
> > > Switch to managed resource so that errors in the probe are handled easily
> > > and simplify the remove function accordingly.
> >
> > Yes, that's what I suggested earlier to another contributor.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Thanks!
> >
> > P.S. You may consider the following things as well:
> > 1) converting to use pci_set_drvdata() / pci_get_drvdata()
>
> I can send a patch for that if you want.
> But it looks really low value for a driver that is already very short and
> clean.
Yep, that's why 2) below came to my mind (then you will remove drvdata call).
> > 2) providing devm_pvpanic_probe() [via devm_add_action() /
> > devm_add_action_or_reset()]
>
> I don't follow you here.
> The goal would be to avoid the remove function and "record" the needed
> action directly in the probe?
>
> If this is it, I would only see an unusual pattern and a harder to follow
> logic.
> Did I miss something?
> What would be the benefit?
First of all it's a usual pattern when one, often used in ->probe(), function
gains its devm variant. See, for example, `return devm_gpiochip_add_data(...);`
used in the code.
Benefit is to have everything under managed resources and yes, no ->remove()
will be needed in the individual drivers.
But it's up to you. It was just a proposal that you may simply refuse to follow,
it's fine.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-17 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 14:36 [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()' Christophe JAILLET
2021-05-16 14:37 ` [PATCH 2/2] misc/pvpanic: Use GFP_KERNEL instead of GFP_ATOMIC Christophe JAILLET
2021-05-17 8:01 ` [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()' Andy Shevchenko
2021-05-17 10:02 ` Christophe JAILLET
2021-05-17 10:34 ` Andy Shevchenko [this message]
2021-05-17 11:24 ` Christophe JAILLET
2021-05-21 12:36 ` Greg KH
2021-05-21 12:41 ` Christophe JAILLET
2021-05-21 13:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKJGrGTHz+DzfiHN@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linqiheng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).