From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
mihai.carabas@oracle.com, pizhenwei@bytedance.com,
pbonzini@redhat.com, linqiheng@huawei.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()'
Date: Mon, 17 May 2021 12:02:24 +0200 [thread overview]
Message-ID: <ada55e25-5eb3-9b6b-5783-d2303db9bf83@wanadoo.fr> (raw)
In-Reply-To: <YKIi1hljnjvqMCVA@smile.fi.intel.com>
Le 17/05/2021 à 10:01, Andy Shevchenko a écrit :
> On Sun, May 16, 2021 at 04:36:55PM +0200, Christophe JAILLET wrote:
>> There is no error handling path in the probe function.
>> Switch to managed resource so that errors in the probe are handled easily
>> and simplify the remove function accordingly.
>
> Yes, that's what I suggested earlier to another contributor.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks!
>
> P.S. You may consider the following things as well:
> 1) converting to use pci_set_drvdata() / pci_get_drvdata()
I can send a patch for that if you want.
But it looks really low value for a driver that is already very short
and clean.
> 2) providing devm_pvpanic_probe() [via devm_add_action() /
> devm_add_action_or_reset()]
I don't follow you here.
The goal would be to avoid the remove function and "record" the needed
action directly in the probe?
If this is it, I would only see an unusual pattern and a harder to
follow logic.
Did I miss something?
What would be the benefit?
CJ
>
>> Fixes: db3a4f0abefd ("misc/pvpanic: add PCI driver")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> drivers/misc/pvpanic/pvpanic-pci.c | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
>> index 9ecc4e8559d5..046ce4ecc195 100644
>> --- a/drivers/misc/pvpanic/pvpanic-pci.c
>> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
>> @@ -78,15 +78,15 @@ static int pvpanic_pci_probe(struct pci_dev *pdev,
>> void __iomem *base;
>> int ret;
>>
>> - ret = pci_enable_device(pdev);
>> + ret = pcim_enable_device(pdev);
>> if (ret < 0)
>> return ret;
>>
>> - base = pci_iomap(pdev, 0, 0);
>> + base = pcim_iomap(pdev, 0, 0);
>> if (!base)
>> return -ENOMEM;
>>
>> - pi = kmalloc(sizeof(*pi), GFP_ATOMIC);
>> + pi = devm_kmalloc(&pdev->dev, sizeof(*pi), GFP_ATOMIC);
>> if (!pi)
>> return -ENOMEM;
>>
>> @@ -107,9 +107,6 @@ static void pvpanic_pci_remove(struct pci_dev *pdev)
>> struct pvpanic_instance *pi = dev_get_drvdata(&pdev->dev);
>>
>> pvpanic_remove(pi);
>> - iounmap(pi->base);
>> - kfree(pi);
>> - pci_disable_device(pdev);
>> }
>>
>> static struct pci_driver pvpanic_pci_driver = {
>> --
>> 2.30.2
>>
>
next prev parent reply other threads:[~2021-05-17 10:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 14:36 [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()' Christophe JAILLET
2021-05-16 14:37 ` [PATCH 2/2] misc/pvpanic: Use GFP_KERNEL instead of GFP_ATOMIC Christophe JAILLET
2021-05-17 8:01 ` [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()' Andy Shevchenko
2021-05-17 10:02 ` Christophe JAILLET [this message]
2021-05-17 10:34 ` Andy Shevchenko
2021-05-17 11:24 ` Christophe JAILLET
2021-05-21 12:36 ` Greg KH
2021-05-21 12:41 ` Christophe JAILLET
2021-05-21 13:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada55e25-5eb3-9b6b-5783-d2303db9bf83@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linqiheng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).