From: Greg KH <gregkh@linuxfoundation.org>
To: 马强 <maqianga@uniontech.com>
Cc: jikos <jikos@kernel.org>,
"benjamin.tissoires " <benjamin.tissoires@redhat.com>,
linux-usb <linux-usb@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Re: Re: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse
Date: Mon, 17 May 2021 13:19:08 +0200 [thread overview]
Message-ID: <YKJRLMoohNUp4I/t@kroah.com> (raw)
In-Reply-To: <440071991.120491.1621248757251.JavaMail.xmail@bj-wm-cp-4>
On Mon, May 17, 2021 at 06:52:37PM +0800, 马强 wrote:
>
> > >
>
> > > > >
> > >
> > > > > Thanks for the prompt response.
> > > > >
> > > > > We can change "dev->power.should_wakeup" to enabled,
> > > >
> > > > I do not understand this statement.
> > > >
> > > > > but ultimately it depends on the hardware and BIOS for wakeup.
> > > >
> > > > Yes, and the hardware here (USB mice), do not all support this, so you
> > > > can not enable it universally as it will cause problems, right?
> > >
> > > I mean, the kernel should set should_wakeup to enabled
> > >
> > > so that system can be awakened when the hardware here(USB mice) supports
> the
> > > wake-up ability.
> >
> > And how do you determine, in the kernel, if the mouse can do that?
> >
> > What range of hardware did you test this change with?
>
> At the kernel level, "dev->power.should_wakeup" is the device property
>
> that should enable the wake-up capability.
>
Given that you have not tested this change, why should we take this?
next prev parent reply other threads:[~2021-05-17 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 6:01 [PATCH] HID: usbhid: enable remote wakeup for mouse Qiang Ma
2021-05-17 8:31 ` Oliver Neukum
2021-05-17 13:32 ` Alan Stern
[not found] ` <1209199573.51584.1621492845444.JavaMail.xmail@bj-wm-cp-1>
2021-05-25 9:55 ` Oliver Neukum
2021-05-17 8:58 ` Greg KH
[not found] ` <1547909475.114060.1621244274064.JavaMail.xmail@bj-wm-cp-4>
2021-05-17 9:46 ` Greg KH
[not found] ` <1781917892.119659.1621247946603.JavaMail.xmail@bj-wm-cp-4>
2021-05-17 10:42 ` Greg KH
[not found] ` <440071991.120491.1621248757251.JavaMail.xmail@bj-wm-cp-4>
2021-05-17 11:19 ` Greg KH [this message]
[not found] ` <671637326.122188.1621250895330.JavaMail.xmail@bj-wm-cp-4>
2021-05-17 11:44 ` Re: " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKJRLMoohNUp4I/t@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maqianga@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).