From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Wang Qing <wangqing@vivo.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: fix some formatting issues
Date: Thu, 20 May 2021 14:13:56 -0300 [thread overview]
Message-ID: <YKaY1GAKkqXnAUrq@smtp.gmail.com> (raw)
In-Reply-To: <1621389170-5850-1-git-send-email-wangqing@vivo.com>
Hi Wang,
Nice patch for a start. Yet, I think there is room for some improvement.
On 05/19, Wang Qing wrote:
> fixing:
If you wish, you may add here that this style check is reported by
checkpatch.
> CHECK: Alignment should match open parenthesis
> #1351: FILE: drivers/staging/iio/addac/adt7316.c:1351:
Checkpatch warns that commit log lines starting with '#' are dropped by
git as comments. Is this intentional?
>
> CHECK: Alignment should match open parenthesis
> #1378: FILE: drivers/staging/iio/addac/adt7316.c:1378:
Same warning here.
Its probably not a requirement, but the subject line could be more
specific about where the changes are for. Maybe start with
staging: iio: addac:
or even
staging: iio: addac: adt7316:
Regards,
Marcelo
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/staging/iio/addac/adt7316.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index ccbafca..79467f0 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -1348,9 +1348,9 @@ static ssize_t adt7316_show_in_analog_temp_offset(struct device *dev,
> }
>
> static ssize_t adt7316_store_in_analog_temp_offset(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + struct device_attribute *attr,
> + const char *buf,
> + size_t len)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
> @@ -1375,9 +1375,9 @@ static ssize_t adt7316_show_ex_analog_temp_offset(struct device *dev,
> }
>
> static ssize_t adt7316_store_ex_analog_temp_offset(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + struct device_attribute *attr,
> + const char *buf,
> + size_t len)
> {
> struct iio_dev *dev_info = dev_to_iio_dev(dev);
> struct adt7316_chip_info *chip = iio_priv(dev_info);
> --
> 2.7.4
>
prev parent reply other threads:[~2021-05-20 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 1:52 [PATCH] staging: iio: fix some formatting issues Wang Qing
2021-05-20 17:13 ` Marcelo Schmitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKaY1GAKkqXnAUrq@smtp.gmail.com \
--to=marcelo.schmitt1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).