linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb: dwc2: Fix build in periphal-only mode
@ 2021-05-28  8:18 Phil Elwell
  2021-05-28  8:54 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Elwell @ 2021-05-28  8:18 UTC (permalink / raw)
  To: Minas Harutyunyan, Greg Kroah-Hartman, Sasha Levin,
	Artur Petrosyan, linux-usb, linux-kernel
  Cc: Phil Elwell

The bus_suspended member of struct dwc2_hsotg is only present in builds
that support host-mode.

Fixes: 62bb46f51f91 ("usb: dwc2: Fix hibernation between host and device modes.")
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
---
 drivers/usb/dwc2/core_intr.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
index a5ab03808da6..03d0c034cf57 100644
--- a/drivers/usb/dwc2/core_intr.c
+++ b/drivers/usb/dwc2/core_intr.c
@@ -725,7 +725,11 @@ static inline void dwc_handle_gpwrdn_disc_det(struct dwc2_hsotg *hsotg,
 	dwc2_writel(hsotg, gpwrdn_tmp, GPWRDN);
 
 	hsotg->hibernated = 0;
+
+#if IS_ENABLED(CONFIG_USB_DWC2_HOST) ||	\
+	IS_ENABLED(CONFIG_USB_DWC2_DUAL_ROLE)
 	hsotg->bus_suspended = 0;
+#endif
 
 	if (gpwrdn & GPWRDN_IDSTS) {
 		hsotg->op_state = OTG_STATE_B_PERIPHERAL;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: dwc2: Fix build in periphal-only mode
  2021-05-28  8:18 [PATCH] usb: dwc2: Fix build in periphal-only mode Phil Elwell
@ 2021-05-28  8:54 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-28  8:54 UTC (permalink / raw)
  To: Phil Elwell
  Cc: Minas Harutyunyan, Sasha Levin, Artur Petrosyan, linux-usb, linux-kernel

On Fri, May 28, 2021 at 09:18:18AM +0100, Phil Elwell wrote:
> The bus_suspended member of struct dwc2_hsotg is only present in builds
> that support host-mode.
> 
> Fixes: 62bb46f51f91 ("usb: dwc2: Fix hibernation between host and device modes.")

That commit id is not in Linus's tree :(

Please fix it with the real commit id and resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-28  8:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28  8:18 [PATCH] usb: dwc2: Fix build in periphal-only mode Phil Elwell
2021-05-28  8:54 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).