From: Borislav Petkov <bp@alien8.de>
To: Qiheng Lin <linqiheng@huawei.com>
Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern
Date: Mon, 31 May 2021 12:39:54 +0200 [thread overview]
Message-ID: <YLS8+gMRp62s4WEY@zn.tnic> (raw)
In-Reply-To: <20210531031009.21737-1-linqiheng@huawei.com>
> Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern
The condensed patch description in the subject line should start with a
uppercase letter and should be written in imperative tone.
Also, the subject is wrong. Hint: "declaration" vs "definition".
On Mon, May 31, 2021 at 11:10:09AM +0800, Qiheng Lin wrote:
> The function declaration in kprobes.h is already marked extern, thus its
> definition should not have the keyword.
>
> This quiets the following sparse warning:
> function 'arch_unoptimize_kprobes' with external linkage has definition
This sounds like you're fixing something just because some tool
complains and not because there's a real problem you're fixing.
Please rewrite your commit messages to state what the problem is and
why you're fixing that problem. The tool output can be used to say
something along the lines of "this problem was caught by this tool" but
not as "see, tool X complains and creates a warning and I must fix that
warning immediately."
Ok?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-05-31 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 3:10 [PATCH -next] x86/kprobes: functions should not be declared extern Qiheng Lin
2021-05-31 10:39 ` Borislav Petkov [this message]
2021-06-01 6:16 ` Qiheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLS8+gMRp62s4WEY@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linqiheng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).