From: Qiheng Lin <linqiheng@huawei.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <x86@kernel.org>,
<hpa@zytor.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern
Date: Tue, 1 Jun 2021 14:16:40 +0800 [thread overview]
Message-ID: <b0a08543-1ec6-f559-a6d8-fb2d49fadb5d@huawei.com> (raw)
In-Reply-To: <YLS8+gMRp62s4WEY@zn.tnic>
在 2021/5/31 18:39, Borislav Petkov 写道:
>> Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern
>
> The condensed patch description in the subject line should start with a
> uppercase letter and should be written in imperative tone.
>
> Also, the subject is wrong. Hint: "declaration" vs "definition".
>
> On Mon, May 31, 2021 at 11:10:09AM +0800, Qiheng Lin wrote:
>> The function declaration in kprobes.h is already marked extern, thus its
>> definition should not have the keyword.
>>
>> This quiets the following sparse warning:
>> function 'arch_unoptimize_kprobes' with external linkage has definition
>
> This sounds like you're fixing something just because some tool
> complains and not because there's a real problem you're fixing.
>
> Please rewrite your commit messages to state what the problem is and
> why you're fixing that problem. The tool output can be used to say
> something along the lines of "this problem was caught by this tool" but
> not as "see, tool X complains and creates a warning and I must fix that
> warning immediately."
Thank you for the review. I will send the v2.
prev parent reply other threads:[~2021-06-01 6:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 3:10 [PATCH -next] x86/kprobes: functions should not be declared extern Qiheng Lin
2021-05-31 10:39 ` Borislav Petkov
2021-06-01 6:16 ` Qiheng Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0a08543-1ec6-f559-a6d8-fb2d49fadb5d@huawei.com \
--to=linqiheng@huawei.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).