* [PATCH v2] phy: phy-mtk-tphy: Fix some resource leaks in mtk_phy_init()
@ 2021-05-19 10:37 Tiezhu Yang
2021-05-31 8:28 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2021-05-19 10:37 UTC (permalink / raw)
To: Chunfeng Yun, Kishon Vijay Abraham I, Vinod Koul, Matthias Brugger
Cc: linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel, lkp,
Dan Carpenter, Heiko Stuebner, kbuild
Use clk_disable_unprepare() in the error path of mtk_phy_init() to fix
some resource leaks.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: remove Fixes tag and add Reviewed-by tag
drivers/phy/mediatek/phy-mtk-tphy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
index cdbcc49..731c483 100644
--- a/drivers/phy/mediatek/phy-mtk-tphy.c
+++ b/drivers/phy/mediatek/phy-mtk-tphy.c
@@ -949,6 +949,8 @@ static int mtk_phy_init(struct phy *phy)
break;
default:
dev_err(tphy->dev, "incompatible PHY type\n");
+ clk_disable_unprepare(instance->ref_clk);
+ clk_disable_unprepare(instance->da_ref_clk);
return -EINVAL;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] phy: phy-mtk-tphy: Fix some resource leaks in mtk_phy_init()
2021-05-19 10:37 [PATCH v2] phy: phy-mtk-tphy: Fix some resource leaks in mtk_phy_init() Tiezhu Yang
@ 2021-05-31 8:28 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-05-31 8:28 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Chunfeng Yun, Kishon Vijay Abraham I, Matthias Brugger,
linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel, lkp,
Dan Carpenter, Heiko Stuebner, kbuild
On 19-05-21, 18:37, Tiezhu Yang wrote:
> Use clk_disable_unprepare() in the error path of mtk_phy_init() to fix
> some resource leaks.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-31 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 10:37 [PATCH v2] phy: phy-mtk-tphy: Fix some resource leaks in mtk_phy_init() Tiezhu Yang
2021-05-31 8:28 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).